What the developer wrote
Authored by Hao Xu
test: add a chunk test for txgraph
Add a test for GetWorstMainChunk(), which picks the worst chunk from
txgraph.
Co-developed-by: rkrux <rkrux.connect@gmail.com>
What changed, and why it matters
This commit only adds a new unit test for an existing internal function in Bitcoin Core's transaction graph code. It does not change any production code, so it cannot introduce a security vulnerability or fix one.
No security action needed; treat as routine test coverage improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds a single BOOST_AUTO_TEST_CASE to src/test/txgraph_tests.cpp exercising GetWorstMainChunk() on a TxGraph object. It constructs a chain of dependent transactions with known feerates, verifies the returned worst chunk and its aggregate feerate, then removes transactions and checks again. No source files outside the test suite are modified.
Changed components
src/test/txgraph_tests.cppInspect captured patch +59 / −0
diff --git a/src/test/txgraph_tests.cpp b/src/test/txgraph_tests.cpp
index 3fb20d8d..3472f699 100644
--- a/src/test/txgraph_tests.cpp
+++ b/src/test/txgraph_tests.cpp
@@ -291,4 +291,63 @@ BOOST_AUTO_TEST_CASE(txgraph_trim_big_singletons)
}
}
+BOOST_AUTO_TEST_CASE(txgraph_get_worst_chunk_chain)
+{
+ // Create a new graph for the test.
+ auto graph = MakeTxGraph(50, 1000, NUM_ACCEPTABLE_ITERS);
+
+ auto chunk_check_helper = [&graph](const std::vector<FeePerWeight>& expected_chunk_txs_feerates, FeePerWeight expected_chunk_feerate) {
+ auto chunk = graph->GetWorstMainChunk();
+ BOOST_CHECK_EQUAL(chunk.first.size(), expected_chunk_txs_feerates.size());
+ for (size_t i = 0; i < expected_chunk_txs_feerates.size(); i++)
+ BOOST_CHECK(graph->GetIndividualFeerate(*chunk.first[i]) == expected_chunk_txs_feerates[i]);
+
+ BOOST_CHECK_EQUAL(chunk.second.fee, expected_chunk_feerate.fee);
+ BOOST_CHECK_EQUAL(chunk.second.size, expected_chunk_feerate.size);
+ };
+
+ std::vector<TxGraph::Ref> refs;
+ refs.reserve(4);
+
+ FeePerWeight feerateA{2, 10};
+ FeePerWeight feerateB{1, 10};
+ FeePerWeight feerateC{2, 10};
+ FeePerWeight feerateD{4, 10};
+
+ // everytime adding a transaction, test the chunk status
+ // [A]
+ refs.push_back(graph->AddTransaction(feerateA));
+ BOOST_CHECK_EQUAL(graph->GetTransactionCount(TxGraph::Level::TOP), 1);
+ chunk_check_helper({feerateA}, feerateA);
+ // [A, B]
+ refs.push_back(graph->AddTransaction(feerateB));
+ graph->AddDependency(/*parent=*/refs[0], /*child=*/refs[1]);
+ BOOST_CHECK_EQUAL(graph->GetTransactionCount(TxGraph::Level::TOP), 2);
+ chunk_check_helper({feerateB}, feerateB);
+
+ // [A, BC]
+ refs.push_back(graph->AddTransaction(feerateC));
+ graph->AddDependency(/*parent=*/refs[1], /*child=*/refs[2]);
+ BOOST_CHECK_EQUAL(graph->GetTransactionCount(TxGraph::Level::TOP), 3);
+ chunk_check_helper({feerateC, feerateB}, FeePerWeight{3, 20});
+
+ // [ABCD]
+ refs.push_back(graph->AddTransaction(feerateD));
+ graph->AddDependency(/*parent=*/refs[2], /*child=*/refs[3]);
+ BOOST_CHECK_EQUAL(graph->GetTransactionCount(TxGraph::Level::TOP), 4);
+ chunk_check_helper({feerateD, feerateC, feerateB, feerateA}, FeePerWeight{9, 40});
+
+ graph->SanityCheck();
+
+ // D->C->A
+ graph->RemoveTransaction(refs[1]);
+ // txgraph is not responsible for removing the descendants or ancestors
+ BOOST_CHECK_EQUAL(graph->GetTransactionCount(TxGraph::Level::TOP), 3);
+ // only A remains there
+ graph->RemoveTransaction(refs[2]);
+ graph->RemoveTransaction(refs[3]);
+ BOOST_CHECK_EQUAL(graph->GetTransactionCount(TxGraph::Level::TOP), 1);
+ chunk_check_helper({feerateA}, feerateA);
+}
+
BOOST_AUTO_TEST_SUITE_END()
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.