AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 34 Bitcoin

mining: reject invalid block create options

Public commit record

What the developer wrote

Authored by Sjors Provoost

68/100 · Adequate
mining: reject invalid block create options

Check BlockCreateOptions before block template creation instead of
clamping runtime values. This makes invalid runtime block creation
options, including those passed by IPC mining clients, fail explicitly
instead of silently mining with different values than the caller
requested.

Runtime option validation now uses the same error wording as startup
option validation. Startup validation also rejects -blockmaxweight
values lower than -blockreservedweight instead of allowing them to be
clamped later.

Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This Bitcoin Core commit changes how mining options are validated. Previously, invalid values for things like block weight limits were silently adjusted (clamped) to valid values, which could cause a miner or an external mining client to unknowingly produce a block different from what they requested. Now the code explicitly rejects invalid options with an error. This is a defensive hardening change that prevents silent misbehavior, especially for external mining clients communicating over IPC.

Recommended action

Treat as a hardening improvement. No emergency action required. Reviewers should verify that all callers of BlockAssembler and createNewBlock handle the new runtime errors gracefully, and that external IPC mining clients are prepared to receive explicit errors instead of silently adjusted block templates.

Security signals we found

01

Silent value clamping replaced with explicit validation errors

02

Runtime/IPC mining options now validated before block template creation

03

Startup -blockmaxweight lower than -blockreservedweight now rejected

04

Validation extended to coinbase_output_max_additional_sigops limit

05

Tests added for IPC and startup option rejection paths

Risk score

Why this scored 34/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 6/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.