AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 22 Bitcoin

Merge bitcoin/bitcoin#35037: ipc: support per-address max-connections options on -ipcbind

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#35037: ipc: support per-address max-connections options on -ipcbind

856f9ea158055460764883dfca01491951554d2e doc: add ipcbind max-connections release note (Enoch Azariah)
bdd381b8ed475b114d6a8ac25bb448515a2a42f9 ipc: test per-address connection limiting over unix sockets (Enoch Azariah)
8761d53b250e9bb81e59a21d48598c1b62fa0e65 ipc: support per-address max-connections on ipcbind (Enoch Azariah)
3d2b65d050962a35b071618a3f32f7a78831e8e3 ipc: add default connection limit for ipcbind listeners (Enoch Azariah)

Pull request description:

The branch extends `-ipcbind` to accept `,max-connections=<n>` options, for example `-ipcbind=unix:,max-connections=8` or `-ipcbind=unix:/custom/path,max-connections=8`, instead of introducing a separate global `-ipcmaxconnections` option.

This keeps the connection limit attached to each IPC listener instead of introducing a global `-ipcmaxconnections` option (https://github.com/bitcoin/bitcoin/pull/34978). A global option would not allow different limits for different `-ipcbind` addresses, and the inline option format can be extended in the future with additional options.

ACKs for top commit:
ryanofsky:
Code review ACK 856f9ea158055460764883dfca01491951554d2e. Only change since last review is wrapping the `-ipcbind` help text in `strprintf` so the default and maximum values are shown. Thanks for all the updates!
sedited:
ACK 856f9ea158055460764883dfca01491951554d2e
ViniciusCestarii:
re-ACK 856f9ea158055460764883dfca01491951554d2e

Tree-SHA512: dd39479372bb5e30d6faedcc3c5f82ba03dbce3a8e082c03c3baf79bca66979554826fab001ca208cefd25955b02f22e6c9cd5bcea7aca1b784f93187f12ab7e
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This change adds a per-listener connection limit for Bitcoin Core's local inter-process communication (IPC) socket option `-ipcbind`. Previously, IPC listeners had no enforced cap on simultaneous connections. The patch lets users specify `,max-connections=<n>` (default 16, maximum 256) and reserves matching file descriptors at startup. It is a hardening improvement rather than a fix for an active vulnerability, and it includes tests and release notes.

Recommended action

Treat as a routine hardening improvement. Reviewers should verify that `MAX_CONNECTIONS` plus listener count does not exceed the startup FD reservation on typical systems, and that URL decoding of socket paths does not introduce path-traversal issues when combined with custom `-ipcbind` paths.

Security signals we found

01

Adds resource-limiting controls to a local unauthenticated IPC listener

02

Enforces per-address max-connections with a hard upper bound

03

Reserves file descriptors at startup to avoid runtime exhaustion

04

Includes unit and functional tests covering boundary values and connection limiting behavior

05

No mention of a CVE, bug report, or external security disclosure

Risk score

Why this scored 22/100

Our methodology →
Potential impact 3/30
Exploitability 2/25
Stealth signal 2/15
Affected reach 3/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.