AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

Merge bitcoin-core/gui#970: Remove legacy BIP70 merchant name from tx details window

Public commit record

What the developer wrote

Authored by Hennadii Stepanov

91/100 · Strong
Merge bitcoin-core/gui#970: Remove legacy BIP70 merchant name from tx details window

fa917ddcb1c7a2612dd8e57c3ef75e443cc8a962 Remove legacy BIP70 merchant name from tx details window (MarcoFalke)

Pull request description:

BIP70 is now dead for roughly half a decade. There is no need to print the merchant name in the tx details window, so remove that feature.

The parser has no tests, nor fuzzing, so removing it will likely also fix some parsing issues with corrupt data.

ACKs for top commit:
l0rinc:
lightweight code review ACK fa917ddcb1c7a2612dd8e57c3ef75e443cc8a962
fanquake:
ACK fa917ddcb1c7a2612dd8e57c3ef75e443cc8a962

Tree-SHA512: 082f8ae958f616f5b344c0da4800ceaafb7bbcf44180eb3f0915b9d4cfb3834e39e943186e383026b90ad3245ce4f61d529c568e2477be6f5b28e7fd9b6a55fe
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit removes an old feature in the Bitcoin Core wallet's transaction details window that displayed a merchant name for BIP70 payment requests. BIP70 is an outdated payment protocol that is no longer used. The removed code parsed certificate data in a simple, untested way. The change is described as a cleanup, but it also eliminates a small bit of code that handled untrusted data without proper validation.

Recommended action

Treat as a hardening/cleanup change rather than an urgent security fix. Users should upgrade through normal release channels. If running older versions, avoid opening transaction details for BIP70 payment requests from untrusted sources. No immediate incident response is warranted based on the supplied materials.

Security signals we found

01

Removal of untested/unfuzzed parser for externally supplied BIP70 payment request data

02

Parser relied on byte-string searches and length fields from untrusted input

03

GUI display path rendered parsed string in HTML after HtmlEscape

04

PR description mentions 'likely also fix some parsing issues with corrupt data'

05

No explicit security claim or CVE from the vendor

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 3/25
Stealth signal 2/15
Affected reach 3/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.