test: update feature_rbf.py replacement test
What the developer wrote
Authored by Suhas Daftuar
test: update feature_rbf.py replacement test
Preparatory commit to the rbf functional test, before changes are made to the
rbf rules as part of cluster mempool.
What changed, and why it matters
This is a minor test-only change in Bitcoin Core's functional test suite. It adds a constant and changes one test variable from 100 to 64 in preparation for future mempool work. It does not modify any production code, consensus rules, or network behavior, and presents no security issue.
No action required; this is a benign test-only refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit updates test/functional/feature_rbf.py, introducing MAX_CLUSTER_LIMIT = 64 and using it in place of MAX_REPLACEMENT_LIMIT when building a transaction tree for RBF replacement tests. The commit message explicitly describes this as a preparatory test change ahead of cluster mempool RBF rule changes. No C++/Python node logic is altered.
Changed components
test/functional/feature_rbf.pyInspect captured patch +3 / −1
diff --git a/test/functional/feature_rbf.py b/test/functional/feature_rbf.py
index 443910c0..91d90efe 100755
--- a/test/functional/feature_rbf.py
+++ b/test/functional/feature_rbf.py
@@ -21,6 +21,8 @@ from test_framework.wallet import MiniWallet
from test_framework.address import ADDRESS_BCRT1_UNSPENDABLE
MAX_REPLACEMENT_LIMIT = 100
+MAX_CLUSTER_LIMIT = 64
+
class ReplaceByFeeTest(BitcoinTestFramework):
def set_test_params(self):
self.num_nodes = 2
@@ -216,7 +218,7 @@ class ReplaceByFeeTest(BitcoinTestFramework):
yield x
fee = int(0.00001 * COIN)
- n = MAX_REPLACEMENT_LIMIT
+ n = MAX_CLUSTER_LIMIT
tree_txs = list(branch(tx0_outpoint, initial_nValue, n, fee=fee))
assert_equal(len(tree_txs), n)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.