wallet, test: remove -deprecatedrpc=bip125 from wallet_basic.py
What the developer wrote
Authored by rkrux
wallet, test: remove -deprecatedrpc=bip125 from wallet_basic.py
What changed, and why it matters
This is a minor test-only cleanup. It removes a deprecated command-line flag and an obsolete field name from a single automated test script. There is no change to Bitcoin Core's actual wallet or network code, and no security relevance.
No action required. This is a routine test maintenance commit with no security implications.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes -deprecatedrpc=bip125 from extra_args in test/functional/wallet_basic.py and drops 'bip125-replaceable' from the expected field set in a gettransaction RPC test. These adjustments follow the prior removal/deprecation of the BIP125-related RPC field; the test is simply being updated to match current behavior. No production code is modified.
Changed components
test/functional/wallet_basic.pyInspect captured patch +2 / −2
diff --git a/test/functional/wallet_basic.py b/test/functional/wallet_basic.py
index 11f27ed7..e2ec2cfa 100755
--- a/test/functional/wallet_basic.py
+++ b/test/functional/wallet_basic.py
@@ -510,7 +510,7 @@ class WalletTest(BitcoinTestFramework):
# Try with walletrejectlongchains
# Double chain limit but require combining inputs, so we pass AttemptSelection
self.stop_node(0)
- extra_args = ["-deprecatedrpc=bip125", "-walletrejectlongchains", "-limitclustercount=" + str(2 * chainlimit), "-limitancestorcount=" + str(2*chainlimit)]
+ extra_args = ["-walletrejectlongchains", "-limitclustercount=" + str(2 * chainlimit), "-limitancestorcount=" + str(2*chainlimit)]
self.start_node(0, extra_args=extra_args)
# wait until the wallet has submitted all transactions to the mempool
@@ -562,7 +562,7 @@ class WalletTest(BitcoinTestFramework):
"amount": baz["amount"],
"category": baz["category"],
"vout": baz["vout"]}
- expected_fields = frozenset({'amount', 'bip125-replaceable', 'confirmations', 'details', 'fee',
+ expected_fields = frozenset({'amount', 'confirmations', 'details', 'fee',
'hex', 'lastprocessedblock', 'time', 'timereceived', 'trusted', 'txid', 'wtxid', 'walletconflicts', 'mempoolconflicts'})
verbose_field = "decoded"
expected_verbose_fields = expected_fields | {verbose_field}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.