depends: remove xinerama extension from libxcb
What the developer wrote
Authored by fanquake
depends: remove xinerama extension from libxcb
This is listed on https://doc.qt.io/qt-5.15/linux-requirements.html as
"recommended", however doesn't seem to be needed, and the fact that it's
no-longer installed by default on modern linux distros, is
annoying/confusing for users. See:
https://github.com/bitcoin/bitcoin/issues/30061
https://bitcoin.stackexchange.com/questions/122646/libxcb-xinerama0-library-required-by-bitcoin-qt
https://github.com/bitcoin/bitcoin/pull/33197
https://github.com/bitcoin/bitcoin/issues/32097
What changed, and why it matters
This commit removes an optional X11 screen-extension feature (Xinerama) from the list of components built into Bitcoin Core's bundled copy of the libxcb library. The change is purely a build-system cleanup to avoid requiring a dependency that is no longer installed by default on modern Linux distributions. There is no security-relevant change here.
No security action needed. This is a routine build-system maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In depends/packages/libxcb.mk, the commit adds –disable-xinerama to the libxcb configure options. Xinerama is an X11 extension for multi-monitor support and is listed by Qt 5.15 as ‘recommended’ but not required. The patch simply stops building it into the vendored libxcb, reducing build friction on systems that lack the xcb-xinerama headers. No code behavior of Bitcoin Core is altered.
Changed components
depends/packages/libxcb.mkInspect captured patch +1 / −1
diff --git a/depends/packages/libxcb.mk b/depends/packages/libxcb.mk
index 036eaf65..c256ea65 100644
--- a/depends/packages/libxcb.mk
+++ b/depends/packages/libxcb.mk
@@ -16,7 +16,7 @@ $(package)_config_opts += --disable-dri2 --disable-dri3 --disable-glx
$(package)_config_opts += --disable-present --disable-record --disable-resource
$(package)_config_opts += --disable-screensaver --disable-xevie --disable-xfree86-dri
$(package)_config_opts += --disable-xinput --disable-xprint --disable-selinux
-$(package)_config_opts += --disable-xtest --disable-xv --disable-xvmc
+$(package)_config_opts += --disable-xtest --disable-xv --disable-xvmc --disable-xinerama
endef
define $(package)_preprocess_cmds
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.