AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36446: test: remove some avoidable test waits

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36446: test: remove some avoidable test waits

ce1d88b2632cc3950f47d8b191bdd74b806eb3ae test: avoid unused wallet test chains (will)
40619d068741ec609ddd3148f13234cbdc54161c bench: honor configured wallet epochs (will)
79bb94f09244ef5745d3c83a8839eec3fcbf2f74 test: cap expected IPC timeouts (will)
06cb869112da6bb1c43f938b2e5a9794f825ff92 test: shorten network limited negative wait (will)

Pull request description:

A few of our longer-running tests have some unnecessary waits and timeouts in them. Reduce or replace them to shorten test times:

- in `p2p_node_network_limited` replace the expected sync timeout with header/ping barriers and a bounded negative check. At CI timeout factor 40, saves roughly 195 seconds per transport.
- in `interface_ipc_mining` cap three expected no-event waits at five seconds, saving roughly 105 seconds at factor 40 in CI.
- in `WalletLoadingDescriptors` honor sanity mode’s single epoch, avoiding four unnecessary wallet unload/load cycles.
- two wallet unit tests switch to `BasicTestingSetup` avoiding construction of two unused 100-block chains.

The timeout changes alone save approximately eight minutes of accumulated test-worker time on CI jobs running both transports and IPC mining. Wall-clock savings depend on parallel scheduling, CPU etc.

ACKs for top commit:
Ayoazeez26:
tACK ce1d88b263
maflcko:
review ACK ce1d88b2632cc3950f47d8b191bdd74b806eb3ae 🐠
ViniciusCestarii:
ACK ce1d88b2632cc3950f47d8b191bdd74b806eb3ae

Tree-SHA512: 77a78ff05327cf08273618ed3f1601d60a0d8533459e3beecd56ed36f0f743ee4cdb6c227d9eee2a48c46831f92b0ab64e74faa536e56a28c5281c7e1eacdae2
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit only changes Bitcoin Core's test and benchmark code to remove unnecessary waiting periods and honor existing test settings. It does not alter the production Bitcoin node software that users run, so it cannot directly affect live network security, wallets, or consensus behavior. The changes make CI tests run faster and avoid some redundant setup work.

Recommended action

No security action required. Treat as a normal test-quality/CI-performance improvement.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.