AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

Merge bitcoin/bitcoin#36294: mempool: Remove -persistmempoolv1 option

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36294: mempool: Remove -persistmempoolv1 option

731b89c09bbc286801eebf5061b161c3d5091150 test: Check that importmempool fails on a malformed mempool.dat (Fabian Jahr)
4c01625f798b4017ab83f86ab8815d56b4d18042 doc: Add release note for -persistmempoolv1 removal (Fabian Jahr)
d1dfdf827619bd06ff9c52e42f2c370e6e70504f mempool: Remove -persistmempoolv1 option (Fabian Jahr)
86a31b93d0db7f01e5c1a61fb014b89b2506fe54 test: Use v31.0 as old node in mempool_compatibility.py (Fabian Jahr)

Pull request description:

`-persistmempoolv1` was added in #28207 as a temporary option to allow downgrading to v26 and earlier, which can't read the XOR'ed `mempool.dat`. v26 has now been EOL for a while. So any version this option could help downgrade to is unsupported now. It seems ready for removal. I don't think this requires an additional deprecation cycle since the feature is useless for any maintained version and docs have always stated that this was a "temporary option that will be removed in the future".

Reading v1 files is still supported, so upgrading directly from an old version keeps the persisted mempool.

`mempool_compatibility.py` now uses v28.2 as the old node, the oldest release in `get_previous_releases.py` that writes the current format.

ACKs for top commit:
maflcko:
review ACK 731b89c09bbc286801eebf5061b161c3d5091150 🐋
ismaelsadeeq:
ACK 731b89c09bbc286801eebf5061b161c3d5091150

Tree-SHA512: 6a61812ef722033f883143a2e9f456bd5c1b348d6e90376220ca13799a1545a5210803dd33f7d6a3da1dac77361f6961f07f5c55cb4a972ddecf80578e0394f0
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit removes an old command-line option called -persistmempoolv1 that let users write the mempool file in a legacy format. The option was always documented as temporary, and the only versions it helped downgrade to are no longer supported. Reading the old format is still supported, so users upgrading from old versions are not affected. A new test was added to check that importing a corrupted mempool file is rejected safely. There is no direct security vulnerability here; it is a cleanup of obsolete functionality.

Recommended action

No immediate action required. Operators who previously used -persistmempoolv1 should be aware the option is gone and that mempool.dat will always be written in the current format. If downgrading to Bitcoin Core v26.x or earlier is still needed, users must manage their mempool manually. Review the new malformed-file test for completeness if desired.

Security signals we found

01

Removal of a legacy, un-XORed mempool serialization option that was documented as temporary

02

Addition of a negative test ensuring malformed mempool.dat files are rejected during import

03

No change to consensus, P2P, wallet encryption, or RPC authorization logic

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 2/15
Confidence 9/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.