What the developer wrote
Authored by Hennadii Stepanov
iwyu: Drop backported mapping
See https://github.com/include-what-you-use/include-what-you-use/pull/1706.
What changed, and why it matters
This commit removes a small, outdated workaround from a developer-only tool configuration file. It has no effect on the Bitcoin Core software that users run, on network behavior, or on funds. It is purely a cleanup for the include-what-you-use (IWYU) static-analysis helper used during development.
No security action needed. This is a routine development-tooling cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change deletes three symbol mappings in contrib/devtools/iwyu/bitcoin.core.imp that told IWYU to treat SEEK_CUR, SEEK_END, and SEEK_SET as belonging to
Changed components
contrib/devtools/iwyu/bitcoin.core.impInspect captured patch +0 / −5
diff --git a/contrib/devtools/iwyu/bitcoin.core.imp b/contrib/devtools/iwyu/bitcoin.core.imp
index 9067bc32..03bafc3d 100644
--- a/contrib/devtools/iwyu/bitcoin.core.imp
+++ b/contrib/devtools/iwyu/bitcoin.core.imp
@@ -9,11 +9,6 @@
{ "symbol": ["AT_HWCAP", "private", "<sys/auxv.h>", "public"] },
{ "symbol": ["AT_HWCAP2", "private", "<sys/auxv.h>", "public"] },
- # Fixed in https://github.com/include-what-you-use/include-what-you-use/pull/1706.
- { "symbol": ["SEEK_CUR", "private", "<cstdio>", "public"] },
- { "symbol": ["SEEK_END", "private", "<cstdio>", "public"] },
- { "symbol": ["SEEK_SET", "private", "<cstdio>", "public"] },
-
# IWYU bug.
# See: https://github.com/include-what-you-use/include-what-you-use/issues/1863.
{ "symbol": ["std::vector", "private", "<vector>", "public"] },
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.