doc: Fix typo "eviction criterium" -> "eviction criterion"
What changed, and why it matters
This commit only fixes spelling and wording in code comments. It changes 'criterium' to 'criterion' and rephrases 'round-trip time' to 'round-trip duration' in documentation-style comments. No program logic, behavior, or security properties are changed.
No security action needed. This is a documentation/comment cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is limited to comment-only changes in src/net.h. It converts Doxygen /** blocks to /// comments, corrects a typo, and clarifies terminology. There are no code, data structure, or algorithm changes. No security vulnerability is introduced or fixed.
Changed components
src/net.h (comments only)Inspect captured patch +13 / −13
diff --git a/src/net.h b/src/net.h
index d923e7b2..5f19074b 100644
--- a/src/net.h
+++ b/src/net.h
@@ -876,24 +876,24 @@ public:
* eviction logic. */
std::atomic_bool m_bloom_filter_loaded{false};
- /** UNIX epoch time of the last block received from this peer that we had
- * not yet seen (e.g. not already received from another peer), that passed
- * preliminary validity checks and was saved to disk, even if we don't
- * connect the block or it eventually fails connection. Used as an inbound
- * peer eviction criterium in CConnman::AttemptToEvictConnection. */
+ /// UNIX epoch time of the last block received from this peer that we had
+ /// not yet seen (e.g. not already received from another peer), that passed
+ /// preliminary validity checks and was saved to disk, even if we don't
+ /// connect the block or it eventually fails to connect. Used as an inbound
+ /// peer eviction criterion in CConnman::AttemptToEvictConnection.
std::atomic<std::chrono::seconds> m_last_block_time{0s};
- /** UNIX epoch time of the last transaction received from this peer that we
- * had not yet seen (e.g. not already received from another peer) and that
- * was accepted into our mempool. Used as an inbound peer eviction criterium
- * in CConnman::AttemptToEvictConnection. */
+ /// UNIX epoch time of the last transaction received from this peer that we
+ /// had not yet seen (e.g. not already received from another peer) and that
+ /// was accepted into our mempool. Used as an inbound peer eviction criterion
+ /// in CConnman::AttemptToEvictConnection.
std::atomic<std::chrono::seconds> m_last_tx_time{0s};
- /** Last measured round-trip time. Used only for RPC/GUI stats/debugging.*/
+ /// Last measured round-trip duration. Used only for stats.
std::atomic<std::chrono::microseconds> m_last_ping_time{0us};
- /** Lowest measured round-trip time. Used as an inbound peer eviction
- * criterium in CConnman::AttemptToEvictConnection. */
+ /// Lowest measured round-trip duration. Used as an inbound peer eviction
+ /// criterion in CConnman::AttemptToEvictConnection.
std::atomic<std::chrono::microseconds> m_min_ping_time{std::chrono::microseconds::max()};
CNode(NodeId id,
@@ -980,7 +980,7 @@ public:
*/
std::string DisconnectMsg() const;
- /** A ping-pong round trip has completed successfully. Update latest and minimum ping times. */
+ /// A ping-pong round trip has completed successfully. Update latest and minimum ping durations.
void PongReceived(std::chrono::microseconds ping_time) {
m_last_ping_time = ping_time;
m_min_ping_time = std::min(m_min_ping_time.load(), ping_time);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.