guix: Drop redundant CMake `--verbose` options
What the developer wrote
Authored by Hennadii Stepanov
guix: Drop redundant CMake `--verbose` options
CMake's verbose output is already controlled by the `VERBOSE`
environment variable, which has been exported since commit 85f4a4b0822e.
What changed, and why it matters
This commit removes redundant '--verbose' flags from Guix build scripts. The verbose output is already controlled by an environment variable, so these flags were unnecessary. There is no security relevance.
No security action required. This is a routine build-script cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit drops ${V:+–verbose} from cmake –build and cmake –install invocations in contrib/guix/libexec/build.sh and contrib/guix/libexec/package.sh. The VERBOSE environment variable already controls CMake verbose output since a prior commit, making the explicit –verbose flags redundant. This is a build-system cleanup with no functional or security impact.
Changed components
contrib/guix/libexec/build.shcontrib/guix/libexec/package.shInspect captured patch +5 / −5
diff --git a/contrib/guix/libexec/build.sh b/contrib/guix/libexec/build.sh
index 000b4901..0bc3888a 100755
--- a/contrib/guix/libexec/build.sh
+++ b/contrib/guix/libexec/build.sh
@@ -169,14 +169,14 @@ mkdir -p "$DISTSRC"
"${CMAKE_EXE_LINKER_FLAGS}"
# Build Bitcoin Core
- cmake --build build -j "$JOBS" ${V:+--verbose}
+ cmake --build build -j "$JOBS"
mkdir -p "$OUTDIR"
# Make the os-specific installers
case "$HOST" in
*mingw*)
- cmake --build build -j "$JOBS" -t deploy ${V:+--verbose}
+ cmake --build build -j "$JOBS" -t deploy
mv build/bitcoin-win64-setup.exe "${OUTDIR}/${DISTNAME}-win64-setup-unsigned.exe"
;;
esac
@@ -188,10 +188,10 @@ mkdir -p "$DISTSRC"
# Install built Bitcoin Core to $INSTALLPATH
case "$HOST" in
*darwin*)
- cmake --install build --strip --prefix "${INSTALLPATH}" ${V:+--verbose}
+ cmake --install build --strip --prefix "${INSTALLPATH}"
;;
*)
- cmake --install build --prefix "${INSTALLPATH}" ${V:+--verbose}
+ cmake --install build --prefix "${INSTALLPATH}"
;;
esac
diff --git a/contrib/guix/libexec/package.sh b/contrib/guix/libexec/package.sh
index 56bd957e..7228346a 100755
--- a/contrib/guix/libexec/package.sh
+++ b/contrib/guix/libexec/package.sh
@@ -95,7 +95,7 @@ set -e -o pipefail
)
;;
*darwin*)
- cmake --build build --target deploy ${V:+--verbose}
+ cmake --build build --target deploy
mv build/dist/bitcoin-macos-app.zip "${OUTDIR}/${DISTNAME}-${HOST}-unsigned.zip"
mkdir -p "unsigned-app-${HOST}"
cp --target-directory="unsigned-app-${HOST}" \
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.