wallet, test: remove -deprecatedrpc=bip125 from wallet_send.py
What the developer wrote
Authored by rkrux
wallet, test: remove -deprecatedrpc=bip125 from wallet_send.py
What changed, and why it matters
This commit only changes a test file. It removes the use of a deprecated RPC option and deletes test assertions that checked whether transactions were marked as replaceable. There is no change to the actual Bitcoin Core wallet or network code, and no security issue is evident.
No action needed. This is a test-only cleanup change with no security relevance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies test/functional/wallet_send.py to stop passing -deprecatedrpc=bip125 to test nodes and removes related assertions on the bip125-replaceable field. This appears to be routine test cleanup following the removal/deprecation of the bip125 RPC field, not a fix for a vulnerability.
Changed components
test/functional/wallet_send.pyInspect captured patch +1 / −10
diff --git a/test/functional/wallet_send.py b/test/functional/wallet_send.py
index ffd3e46d..062c360f 100755
--- a/test/functional/wallet_send.py
+++ b/test/functional/wallet_send.py
@@ -31,7 +31,7 @@ class WalletSendTest(BitcoinTestFramework):
# whitelist peers to speed up tx relay / mempool sync
self.noban_tx_relay = True
self.supports_cli = False
- self.extra_args = [["-datacarriersize=16", "-deprecatedrpc=bip125"]] * self.num_nodes
+ self.extra_args = [["-datacarriersize=16"]] * self.num_nodes
getcontext().prec = 8 # Satoshi precision for Decimal
def skip_test_if_missing_module(self):
@@ -167,7 +167,6 @@ class WalletSendTest(BitcoinTestFramework):
# Ensure transaction exists in the wallet:
tx = from_wallet.gettransaction(res["txid"])
assert tx
- assert_equal(tx["bip125-replaceable"], "yes" if replaceable else "no")
if nonmempool:
assert_raises_rpc_error(-5, "No such mempool transaction", from_wallet.getrawtransaction, res["txid"])
assert from_wallet.getbalances()["mine"]["nonmempool"] < 0
@@ -431,14 +430,6 @@ class WalletSendTest(BitcoinTestFramework):
res = self.test_send(from_wallet=w0, to_wallet=w1, amount=1, inputs=[utxo1], add_to_wallet=False)
assert res["complete"]
- self.log.info("Replaceable...")
- res = self.test_send(from_wallet=w0, to_wallet=w1, amount=1, add_to_wallet=True, replaceable=True)
- assert res["complete"]
- assert_equal(self.nodes[0].gettransaction(res["txid"])["bip125-replaceable"], "yes")
- res = self.test_send(from_wallet=w0, to_wallet=w1, amount=1, add_to_wallet=True, replaceable=False)
- assert res["complete"]
- assert_equal(self.nodes[0].gettransaction(res["txid"])["bip125-replaceable"], "no")
-
self.log.info("Subtract fee from output")
self.test_send(from_wallet=w0, to_wallet=w1, amount=1, subtract_fee_from_outputs=[0])
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.