doc: unify `datacarriersize` warning with release notes
What the developer wrote
Authored by Lőrinc
doc: unify `datacarriersize` warning with release notes
Unified the deprecation warning for the recently deprecated datacarrier[size] options to match the phrasing of release-notes-32406.md.
What changed, and why it matters
This commit only changes the wording of a user-facing deprecation warning and updates the matching test. It does not alter any behavior, logic, or security-sensitive code. There is no security issue here.
No action needed; this is a documentation/test-only wording change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies a single InitWarning string in src/init.cpp to add the phrase ‘and are expected’ and updates the expected stderr strings in the functional test mempool_datacarrier.py accordingly. No code paths, validation rules, or configuration handling are changed.
Changed components
src/init.cpp (deprecation warning text only)test/functional/mempool_datacarrier.py (expected warning text only)Inspect captured patch +4 / −4
diff --git a/src/init.cpp b/src/init.cpp
index b6b52e2c..b2f59a60 100644
--- a/src/init.cpp
+++ b/src/init.cpp
@@ -904,7 +904,7 @@ bool AppInitParameterInteraction(const ArgsManager& args)
}
if (args.IsArgSet("-datacarriersize") || args.IsArgSet("-datacarrier")) {
- InitWarning(_("Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated. They will be removed in a future version."));
+ InitWarning(_("Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated and are expected to be removed in a future version."));
}
// We no longer limit the orphanage based on number of transactions but keep the option to warn users who still have it in their config.
diff --git a/test/functional/mempool_datacarrier.py b/test/functional/mempool_datacarrier.py
index 629bac20..40d3d2b3 100755
--- a/test/functional/mempool_datacarrier.py
+++ b/test/functional/mempool_datacarrier.py
@@ -103,9 +103,9 @@ class DataCarrierTest(BitcoinTestFramework):
# Clean shutdown boilerplate due to deprecation
self.expected_stderr = [
"", # node 0 has no deprecated options
- "Warning: Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated. They will be removed in a future version.",
- "Warning: Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated. They will be removed in a future version.",
- "Warning: Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated. They will be removed in a future version.",
+ "Warning: Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated and are expected to be removed in a future version.",
+ "Warning: Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated and are expected to be removed in a future version.",
+ "Warning: Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated and are expected to be removed in a future version.",
]
for i in range(self.num_nodes):
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.