What the developer wrote
Authored by ismaelsadeeq
fees: delete unused dummy field
- This commit deletes a dummy field that is
"dummy" and unused.
What changed, and why it matters
This commit removes an unused placeholder value from the fee estimator's saved data file format. It is a cleanup change with no apparent security relevance.
No security action required; treat as routine code cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes a dummy integer field that was written to and read from the fee estimator persistence file. The field was explicitly documented as unused, and its removal simplifies the serialization format. No logic changes affect security boundaries, consensus, networking, or cryptography.
Changed components
src/policy/fees/block_policy_estimator.cppInspect captured patch +2 / −3
diff --git a/src/policy/fees/block_policy_estimator.cpp b/src/policy/fees/block_policy_estimator.cpp
index def101f9..d716e0f8 100644
--- a/src/policy/fees/block_policy_estimator.cpp
+++ b/src/policy/fees/block_policy_estimator.cpp
@@ -980,7 +980,6 @@ bool CBlockPolicyEstimator::Write(AutoFile& fileout) const
try {
LOCK(m_cs_fee_estimator);
fileout << CURRENT_FEES_FILE_VERSION;
- fileout << int{0}; // Unused dummy field. Written files may contain any value in [0, 289900]
fileout << nBestSeenHeight;
if (BlockSpan() > HistoricalBlockSpan()/2) {
fileout << firstRecordedHeight << nBestSeenHeight;
@@ -1004,8 +1003,8 @@ bool CBlockPolicyEstimator::Read(AutoFile& filein)
{
try {
LOCK(m_cs_fee_estimator);
- int nVersionRequired, dummy;
- filein >> nVersionRequired >> dummy;
+ int nVersionRequired;
+ filein >> nVersionRequired;
if (nVersionRequired > CURRENT_FEES_FILE_VERSION) {
throw std::runtime_error{strprintf("File version (%d) too high to be read.", nVersionRequired)};
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.