signals: Temporarily add boost headers to bitcoind and bitcoin-node builds
What the developer wrote
Authored by Cory Fields
signals: Temporarily add boost headers to bitcoind and bitcoin-node builds
The current code forward-declares boost::signals2, which avoids the need for
these includes.
An upcoming commit will (temporarily) include boost headers directly instead.
A follow-up commit will then replace boost with an internal signals
implementation, which will allow this commit to be reverted.
What changed, and why it matters
This commit only changes build instructions to add Boost header files as a dependency for two Bitcoin Core programs. It does not change any program logic, fix a bug, or alter how the software behaves at runtime. There is no security issue here.
No security action needed. Review as a normal build-system dependency change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit adds Boost::headers to the CMake link targets for bitcoind and bitcoin-node. The commit message explains this is a temporary build-system change to support an upcoming commit that will include Boost.Signals2 headers directly, before later replacing Boost with an internal signals implementation. The diff contains no code changes, only build dependency declarations.
Changed components
src/CMakeLists.txtInspect captured patch +2 / −0
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index cf1f26c9..1eb61f13 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -307,6 +307,7 @@ if(BUILD_DAEMON)
target_link_libraries(bitcoind
core_interface
bitcoin_node
+ Boost::headers
$<TARGET_NAME_IF_EXISTS:bitcoin_wallet>
)
install_binary_component(bitcoind HAS_MANPAGE)
@@ -320,6 +321,7 @@ if(ENABLE_IPC AND BUILD_DAEMON)
core_interface
bitcoin_node
bitcoin_ipc
+ Boost::headers
$<TARGET_NAME_IF_EXISTS:bitcoin_wallet>
)
install_binary_component(bitcoin-node INTERNAL)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.