Merge bitcoin/bitcoin#36674: Update leveldb subtree to latest master
What changed, and why it matters
This commit removes an unreachable 'return false;' statement from a LevelDB log-reading function. In some build configurations, compilers warn about code that can never execute; removing it silences those warnings and makes the function's actual control flow clearer. The change itself does not alter program behavior in normal operation.
No security action required. Treat as routine code-quality / compiler-warning cleanup.
Security signals we found
No security-relevant logic change in the diff
Change is a single-line removal of unreachable code
No input validation, memory handling, or cryptographic code modified
Evidence from the diff
The diff deletes a trailing ‘return false;’ at the end of ‘leveldb::log::Reader::ReadRecord’. That statement was unreachable because every path through the function already returns a boolean value. The removal is a cleanup change that avoids compiler diagnostics about unreachable code and does not change the function’s observable logic.
Changed components
src/leveldb/db/log_reader.ccInspect captured patch +0 / −1
### src/leveldb/db/log_reader.cc
@@ -170,7 +170,6 @@ bool Reader::ReadRecord(Slice* record, std::string* scratch) {
}
}
}
- return false;
}
uint64_t Reader::LastRecordOffset() { return last_record_offset_; }Why this scored 23/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.