AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 33 Bitcoin

Merge bitcoin/bitcoin#36489: wallet: rpc: Add snake_case aliases for wallet funding options

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36489: wallet: rpc: Add snake_case aliases for wallet funding options

faeb073ca68348bc663c80b3f2b70d7014466b07 test: Use new named arg aliases in tests (MarcoFalke)
fac8ef10f4c618136dd318f642fd7ccb4587d509 wallet: rpc: Add snake_case aliases for wallet funding options (MarcoFalke)

Pull request description:

The options for wallet funding RPCs have several issues:

* snake_case aliases are accepted by the server, but unsupported by bitcoin-cli, not mentioned in the docs and rejected by the schema.
* If both the snake_case and camelCase are provided, the camelCase is silently ignored.
* The server silently ignores `subtract_fee_from_outputs`. (reported by stutxo in https://github.com/bitcoin/bitcoin/pull/35317)

Fix all issues, by:

* Adding the snake_case aliases to the CLI, docs and the schema.
* Rejecting if both are supplied.
* Reading `subtract_fee_from_outputs` instead of silently ignoring it.

ACKs for top commit:
Conradgabe:
tACK faeb073ca68348bc663c80b3f2b70d7014466b07
sedited:
ACK faeb073ca68348bc663c80b3f2b70d7014466b07
willcl-ark:
ACK faeb073ca68348bc663c80b3f2b70d7014466b07

Tree-SHA512: d434c98d9a2aacf3d547d727f7d31a052beea7079f6ca32ed08877523f28231ae0bc7f1ff9a909856b7b14f7e89560058ec723918277d259b2810bcb90982804
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This update fixes a quirk in Bitcoin Core's wallet commands where some option names using underscores (like subtract_fee_from_outputs) were accepted by the server but not properly handled by the command-line tool or documentation. More importantly, the server was silently ignoring subtract_fee_from_outputs, meaning a user who thought they had told the wallet to deduct the transaction fee from a recipient's payment would actually end up paying the fee themselves. The patch also now rejects supplying both the old camelCase name and the new snake_case name at the same time, preventing confusion. It is a bug fix with a mild financial-impact risk rather than a direct theft or remote-code-execution vulnerability.

Recommended action

Treat as a low-severity wallet bug fix. Users and integrators relying on fundrawtransaction or walletcreatefundedpsbt with snake_case options should upgrade to ensure subtract_fee_from_outputs is honored and to avoid ambiguous parameter errors. No emergency response is warranted; review release notes for the new alias behavior.

Security signals we found

01

Silent option ignore bug fixed: subtract_fee_from_outputs was previously parsed but not acted on, causing unintended fee payer behavior

02

New helper GetOptionWithAlias enforces that canonical and deprecated option names cannot both be supplied, preventing ambiguous parameter handling

03

CLI conversion table and help docs updated to recognize snake_case aliases, reducing mismatches between client and server parameter handling

04

Functional tests added for duplicate subtract_fee_from_outputs/subtractFeeFromOutputs error and existing tests migrated to snake_case aliases

Risk score

Why this scored 33/100

Our methodology →
Potential impact 5/30
Exploitability 5/25
Stealth signal 3/15
Affected reach 8/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.