What the developer wrote
Authored by will
ci: fix lint docker caching
Fixes: 33735
Correct runner type selection for the lint job.
This was erroneously left-out during refactor of the runner selection
mechanism in #33302 causing the lint job to run on GH hosts (and
therefore not be able to acces local cirrus caches).
What changed, and why it matters
This is a tiny GitHub Actions CI configuration fix. A previous code reorganization accidentally made the lint job run on GitHub's own virtual machines instead of the project's dedicated Cirrus runner machines. The fix changes the condition used to pick the runner so the lint job again uses the Cirrus runners and can access their local caches. It has no effect on the Bitcoin Core software users run, on wallets, transactions, consensus, or network security.
No security action required. Treat as normal CI maintenance.
Security signals we found
No security-relevant code change
CI workflow infrastructure fix only
No modification to source code, build scripts shipped to users, or consensus logic
Evidence from the diff
The commit changes one line in .github/workflows/ci.yml. The lint job’s runs-on expression previously checked needs.runners.outputs.use-cirrus-runners == ‘true’, but that output was removed during refactor in PR #33302. The correct output is needs.runners.outputs.provider == ‘cirrus’. Without this fix the lint job falls back to ‘ubuntu-24.04’ (GitHub-hosted runner), losing access to local Cirrus caches and potentially running slower or failing cache lookups. This is purely an infrastructure/CI correctness fix.
Changed components
.github/workflows/ci.yml lint job runner selectionInspect captured patch +1 / −1
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 1c69cc54..b0fb3c59 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -566,7 +566,7 @@ jobs:
lint:
name: 'lint'
needs: runners
- runs-on: ${{ needs.runners.outputs.use-cirrus-runners == 'true' && 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-xs' || 'ubuntu-24.04' }}
+ runs-on: ${{ needs.runners.outputs.provider == 'cirrus' && 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-xs' || 'ubuntu-24.04' }}
if: ${{ vars.SKIP_BRANCH_PUSH != 'true' || github.event_name == 'pull_request' }}
timeout-minutes: 20
env:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.