What the developer wrote
Authored by Matthew Zipkin
Modernize GetBindAddress()
Replace the C-style casting with C++ reinterpret_cast
What changed, and why it matters
This commit is a minor code cleanup in Bitcoin Core's networking code. It replaces an old-style C cast with a modern C++ reinterpret_cast and renames a few local variables. There is no functional change and no security issue.
No security action needed. Treat as a normal code-quality refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch refactors GetBindAddress() in src/netbase.cpp. It renames sockaddr_bind/storage and len, switches (struct sockaddr*) to reinterpret_cast
Changed components
src/netbase.cpp::GetBindAddress()Inspect captured patch +7 / −4
diff --git a/src/netbase.cpp b/src/netbase.cpp
index 43d9d04b..c1c03c57 100644
--- a/src/netbase.cpp
+++ b/src/netbase.cpp
@@ -951,10 +951,13 @@ CService MaybeFlipIPv6toCJDNS(const CService& service)
CService GetBindAddress(const Sock& sock)
{
CService addr_bind;
- struct sockaddr_storage sockaddr_bind;
- socklen_t sockaddr_bind_len = sizeof(sockaddr_bind);
- if (!sock.GetSockName((struct sockaddr*)&sockaddr_bind, &sockaddr_bind_len)) {
- addr_bind.SetSockAddr((const struct sockaddr*)&sockaddr_bind, sockaddr_bind_len);
+ sockaddr_storage storage;
+ socklen_t len = sizeof(storage);
+
+ auto sa = reinterpret_cast<sockaddr*>(&storage);
+
+ if (sock.GetSockName(sa, &len) == 0) {
+ addr_bind.SetSockAddr(sa, len);
} else {
LogWarning("getsockname failed\n");
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.