signals: re-add forward-declares to interface headers
What the developer wrote
Authored by Cory Fields
signals: re-add forward-declares to interface headers
The real includes were only needed temporarily while supporting btcsignals as
an alias for boost::signals2.
What changed, and why it matters
This is a routine code cleanup commit. It replaces a full header include with a simple forward declaration in two interface header files. There is no security-relevant change and no indication of a vulnerability being fixed.
No action required. This is a benign refactoring/cleanup change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes the real #include
Changed components
src/interfaces/handler.hsrc/node/interface_ui.hInspect captured patch +8 / −4
diff --git a/src/interfaces/handler.h b/src/interfaces/handler.h
index 09c23638..a68af21a 100644
--- a/src/interfaces/handler.h
+++ b/src/interfaces/handler.h
@@ -5,11 +5,13 @@
#ifndef BITCOIN_INTERFACES_HANDLER_H
#define BITCOIN_INTERFACES_HANDLER_H
-#include <btcsignals.h>
-
#include <functional>
#include <memory>
+namespace btcsignals {
+ class connection;
+} // namespace btcsignals
+
namespace interfaces {
//! Generic interface for managing an event handler or callback function
diff --git a/src/node/interface_ui.h b/src/node/interface_ui.h
index c33df59a..8175683f 100644
--- a/src/node/interface_ui.h
+++ b/src/node/interface_ui.h
@@ -6,8 +6,6 @@
#ifndef BITCOIN_NODE_INTERFACE_UI_H
#define BITCOIN_NODE_INTERFACE_UI_H
-#include <btcsignals.h>
-
#include <cstdint>
#include <functional>
#include <string>
@@ -17,6 +15,10 @@ class CBlockIndex;
enum class SynchronizationState;
struct bilingual_str;
+namespace btcsignals {
+ class connection;
+} // namespace btcsignals
+
/** Signals for UI communication. */
class CClientUIInterface
{
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.