AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36553: test: Add missing sync_mempools in wallet_conflicts.py

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36553: test: Add missing sync_mempools in wallet_conflicts.py

fa1061481bb1cb6bb7d5ca7ea6674f349f2baed8 test: Add missing sync_mempools in wallet_conflicts.py (MarcoFalke)
fa3986f5c1d512f5e8a320ccbbd84bde3c9e2575 test: Remove redundant sync call after self.generate called sync_all (MarcoFalke)

Pull request description:

Fix https://github.com/bitcoin/bitcoin/actions/runs/38882212577/job/116911393791?pr=36545#step:11:3700:

```
2026-10-16T09:48:01.724540Z TestFramework (INFO): Test a scenario where a transaction has a mempool conflict
2026-10-16T09:48:02.100649Z TestFramework (INFO): Test scenario where a mempool conflict is removed
2026-10-16T10:28:02.397150Z TestFramework (ERROR): Unexpected exception:
Traceback (most recent call last):
File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 146, in main
self.run_test()
~~~~~~~~~~~~~^^
File "/home/runner/work/_temp/build_ ₿🧪_/test/functional/wallet_conflicts.py", line 38, in run_test
self.test_mempool_conflict()
~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/runner/work/_temp/build_ ₿🧪_/test/functional/wallet_conflicts.py", line 202, in test_mempool_conflict
self.generate(self.nodes[2], 1)
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 668, in generate
sync_fun() if sync_fun else self.sync_all()
~~~~~~~~~~~~~^^
File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 750, in sync_all
self.sync_mempools(nodes)
~~~~~~~~~~~~~~~~~~^^^^^^^
File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 743, in sync_mempools
raise AssertionError("Mempool sync timed out after {}s:{}".format(
...<2 lines>...
))
AssertionError: Mempool sync timed out after 2400s:
{'ed4cecf5b16f82ce48b2c56b6a20feac3f83e6043b262a74f356e07a451dda34'}
{'47de6fdef43b22320dc0114c2104e3dee58de9591799ff5e48ff29efaa5cf88f', 'ed4cecf5b16f82ce48b2c56b6a20feac3f83e6043b262a74f356e07a451dda34'}
{'ed4cecf5b16f82ce48b2c56b6a20feac3f83e6043b262a74f356e07a451dda34'}
```

by adding the missing `sync_mempools`.

ACKs for top commit:
fanquake:
ACK fa1061481bb1cb6bb7d5ca7ea6674f349f2baed8

Tree-SHA512: 526a216228f87976c5a41b8fffb8eab0728d23c70c642a54ed2f2cc58c93875119c5c294b151bab5ff70994f657091a6db879f4aae63b0cde356466685fcd084
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a flaky automated test in Bitcoin Core. It adds missing mempool synchronization calls in a wallet-conflict test and removes a couple of redundant block-sync calls. There is no change to production code, no security vulnerability, and no risk to users' funds or node safety.

Recommended action

No security action needed. This is a routine test-maintenance change.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.