AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 18 Bitcoin

rust: clean up wally_sha512 remnants

Public commit record

What the developer wrote

Authored by Marko Bencun

68/100 · Adequate
rust: clean up wally_sha512 remnants

Since bitbox02::sha512 now uses bitcoin::hashes and is not wrapping
the wally C function, we can remove that function and inline it.

bitbox-aes does not need the feature switch anymore as a result.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit is a routine code cleanup in the BitBox02 hardware wallet firmware. It removes an old wrapper around a C-language SHA-512 function and switches the Rust code to use a pure-Rust SHA-512 implementation from the `bitcoin::hashes` library. It also removes an unused feature flag and simplifies dependencies. There is no direct evidence in the commit that this fixes a security vulnerability.

Recommended action

No immediate security action required. Treat as a normal refactoring commit. If auditing, verify that `bitcoin::hashes` SHA-512 and HMAC-SHA256 outputs match the previous implementations in unit tests, and confirm the removed `use-wally-sha512` feature is no longer referenced in build scripts or CI.

Security signals we found

01

Removal of C FFI wrapper for SHA-512

02

Migration to pure-Rust `bitcoin::hashes` SHA-512/HMAC-SHA256 implementations

03

Dependency simplification: dropping `sha2`, `hmac`, optional `bitbox02` from `bitbox-aes`

04

No new unsafe code, no input validation changes, no algorithm change

Risk score

Why this scored 18/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 2/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.