Merge remote-tracking branch 'agent/benma-agent/usb-poll-interval'
What changed, and why it matters
This commit updates the BitBox02 firmware to poll its USB communication channel more frequently (every 1 millisecond instead of every 4 milliseconds) and bundles newer signed bootloader files for development builds. The stated goal is to speed up firmware upgrades over USB. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a performance/usability improvement.
No immediate security action is indicated by this commit. Treat as a routine performance/maintenance update. If reviewing the new v1.2.3 bootloader binaries for security, inspect their source diff separately, since the binary contents are not shown here.
Security signals we found
USB HID endpoint bInterval reduced from 4 ms to 1 ms (performance tuning)
Bootloader stage1 development binaries bumped from v1.2.0 to v1.2.3 with updated checksums
CMakeLists.txt updated to reference new signed bootloader binaries
CHANGELOG frames the change as a firmware-upgrade speed improvement, not a security fix
Evidence from the diff
The change reduces the USB HID endpoint polling interval (bInterval) from 4 ms to 1 ms in both usb_desc.h and usb_desc_common.h. It also replaces v1.2.0 development bootloader stage1 binaries with v1.2.3 signed binaries and updates CMakeLists.txt references and checksums accordingly. The CHANGELOG describes the user-visible effect as ‘Speed up firmware upgrades over USB.’ No security-relevant bug, buffer handling, cryptographic, or access-control change is visible in the diff.
Changed components
src/usb/class/usb_desc.hsrc/usb/class/usb_desc_common.hsrc/bootloader_upgrade/bin/* development stage1 bootloader binariessrc/CMakeLists.txtCHANGELOG.mdInspect captured patch +11 / −10
### CHANGELOG.md
@@ -231,6 +231,7 @@ recorded separately.
## Bootloader
### Unreleased
+- Speed up firmware upgrades over USB.
- Hold the screen reset pin low until bootloader is ready to initalize it.
### v1.2.2
### src/CMakeLists.txt
@@ -483,10 +483,10 @@ if(CMAKE_CROSSCOMPILING)
set(BB02_BLUPD_STAGE1_BITBOX02_MULTI_PRODUCTION_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02-multi-production.v1.2.2.signed.bin)
set(BB02_BLUPD_STAGE1_BITBOX02NOVA_BTCONLY_PRODUCTION_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02nova-btconly-production.v1.2.2.signed.bin)
set(BB02_BLUPD_STAGE1_BITBOX02NOVA_MULTI_PRODUCTION_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02nova-multi-production.v1.2.2.signed.bin)
- set(BB02_BLUPD_STAGE1_BITBOX02_BTCONLY_DEVELOPMENT_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02-btconly-development.v1.2.0.signed.bin)
- set(BB02_BLUPD_STAGE1_BITBOX02_MULTI_DEVELOPMENT_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02-multi-development.v1.2.0.signed.bin)
- set(BB02_BLUPD_STAGE1_BITBOX02NOVA_BTCONLY_DEVELOPMENT_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02nova-btconly-development.v1.2.0.signed.bin)
- set(BB02_BLUPD_STAGE1_BITBOX02NOVA_MULTI_DEVELOPMENT_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02nova-multi-development.v1.2.0.signed.bin)
+ set(BB02_BLUPD_STAGE1_BITBOX02_BTCONLY_DEVELOPMENT_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02-btconly-development.v1.2.3.signed.bin)
+ set(BB02_BLUPD_STAGE1_BITBOX02_MULTI_DEVELOPMENT_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02-multi-development.v1.2.3.signed.bin)
+ set(BB02_BLUPD_STAGE1_BITBOX02NOVA_BTCONLY_DEVELOPMENT_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02nova-btconly-development.v1.2.3.signed.bin)
+ set(BB02_BLUPD_STAGE1_BITBOX02NOVA_MULTI_DEVELOPMENT_BIN ${BB02_BLUPD_BIN_DIR}/bootloader-stage1-bitbox02nova-multi-development.v1.2.3.signed.bin)
set(BB02_BLUPD_FIRMWARE_TARGETS
firmware-blupgrade-bitbox02-btconly
### src/bootloader_upgrade/bin/bootloader-stage1-bitbox02-btconly-development.v1.2.0.signed.bin
[binary or diff unavailable]
### src/bootloader_upgrade/bin/bootloader-stage1-bitbox02-btconly-development.v1.2.3.signed.bin
[binary or diff unavailable]
### src/bootloader_upgrade/bin/bootloader-stage1-bitbox02-multi-development.v1.2.0.signed.bin
[binary or diff unavailable]
### src/bootloader_upgrade/bin/bootloader-stage1-bitbox02-multi-development.v1.2.3.signed.bin
[binary or diff unavailable]
### src/bootloader_upgrade/bin/bootloader-stage1-bitbox02nova-btconly-development.v1.2.0.signed.bin
[binary or diff unavailable]
### src/bootloader_upgrade/bin/bootloader-stage1-bitbox02nova-btconly-development.v1.2.3.signed.bin
[binary or diff unavailable]
### src/bootloader_upgrade/bin/bootloader-stage1-bitbox02nova-multi-development.v1.2.0.signed.bin
[binary or diff unavailable]
### src/bootloader_upgrade/bin/bootloader-stage1-bitbox02nova-multi-development.v1.2.3.signed.bin
[binary or diff unavailable]
### src/bootloader_upgrade/bin/checksums.txt
@@ -6,11 +6,11 @@ f0ec9169c81e8b6d9667aedf8a21ca53a744a9a7a544d27b1647b796c524be40 bootloader-sta
cf0c8eb9eb85560bc67d5da11504aa73a52e210fc0c3b8c72f9d4fc6d7acbe3f bootloader-stage0-bitbox02nova-btconly-production.v3.bin
cc7e648ff012261b753a463f4a9172b30f6692dd9ec82b9dedb033a3362ab660 bootloader-stage0-bitbox02nova-multi-development.v3.bin
3838773d8969e94f475fd291c7ed9e552ca99f7d33ef81aa8e87d623898ac13e bootloader-stage0-bitbox02nova-multi-production.v3.bin
-e12efe809ad9a17098979242eb762cf9b682ed4208e44fb21748c2256aa4489b bootloader-stage1-bitbox02-btconly-development.v1.2.0.signed.bin
+c58996d5e36c6dba3d00b77b756341fd0dce722b85257537d67193d62ec6e7d4 bootloader-stage1-bitbox02-btconly-development.v1.2.3.signed.bin
ebb93bb2c23b5266fccb93ca623fe9aadf15dd166999ba8380de37eb1ff26cae bootloader-stage1-bitbox02-btconly-production.v1.2.2.signed.bin
-662b663a7fe41550a56fa76defa06f54f40d599e4416082ebab77eae35878279 bootloader-stage1-bitbox02-multi-development.v1.2.0.signed.bin
+3007072deeb349dd507a31e359045d879f23c7836c894a24a95bdcadc15f6057 bootloader-stage1-bitbox02-multi-development.v1.2.3.signed.bin
1b7e8eaa9ad6945512299202c99878da7473b7da851eeb986c3846a62470c78f bootloader-stage1-bitbox02-multi-production.v1.2.2.signed.bin
-348962dbf9c70205abe15f5beb5fee7fecc34b94782106510973a7f26dc1f6d1 bootloader-stage1-bitbox02nova-btconly-development.v1.2.0.signed.bin
+52c96d7c1bb9631c949f863c8935a011f465a1d6e8c6ae1ea83e9c11a88b8e3b bootloader-stage1-bitbox02nova-btconly-development.v1.2.3.signed.bin
d91e5816d259c059bb062a1ecb7407d79734852d715f3aecc2ddd7f32f96aded bootloader-stage1-bitbox02nova-btconly-production.v1.2.2.signed.bin
-b3568f9b473f3505d1fa925dc026b4b7e222ee971b695793485fb107d0c283cc bootloader-stage1-bitbox02nova-multi-development.v1.2.0.signed.bin
+2d44cddef68a16a4237c862420727390d580048d511cbf19c0fa692a78e295e1 bootloader-stage1-bitbox02nova-multi-development.v1.2.3.signed.bin
e51688c9a1719f2cba1cbaa1ca61d7b6339cf5904d65bc3e799d332f62ca7cf7 bootloader-stage1-bitbox02nova-multi-production.v1.2.2.signed.bin
### src/usb/class/usb_desc.h
@@ -99,7 +99,7 @@
USB_DESC_HWW_EP_OUT, /* ep_out.bEndpointAddress */ \
0x03, /* ep_out.bmAttributes */ \
USB_DESC_LE16(USB_DESC_HID_EP_SIZE), /* ep_out.wMaxPacketSize */ \
- 4 /* ep_out.bInterval */
+ 1 /* ep_out.bInterval */
#define USB_DESC_CONFIG \
USB_DESC_CONFIG_LEN, /* bLength */ \
### src/usb/class/usb_desc_common.h
@@ -96,7 +96,7 @@
USB_DESC_HWW_EP_OUT, /* ep_out.bEndpointAddress */ \
0x03, /* ep_out.bmAttributes */ \
USB_DESC_LE16(USB_DESC_HID_EP_SIZE), /* ep_out.wMaxPacketSize */ \
- 4 /* ep_out.bInterval */
+ 1 /* ep_out.bInterval */
#define USB_DESC_CONFIG \
USB_DESC_CONFIG_LEN, /* bLength */ \Why this scored 17/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.