← Watch feed
hww: remove empty function hww_process()
What changed, and why it matters
This commit removes an empty placeholder function called hww_process() that did nothing. It is a routine code cleanup with no security relevance.
Recommended action
No action needed; this is a non-functional cleanup change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes the empty implementation and declaration of hww_process() and removes its call from firmware_main_loop(). The function’s own comment stated it did nothing, and the commit message confirms this. No functional behavior changes.
Changed components
src/firmware_main_loop.csrc/hww.csrc/hww.hInspect captured patch +0 / −13
diff --git a/src/firmware_main_loop.c b/src/firmware_main_loop.c
index 742aa5e..faa58a9 100644
--- a/src/firmware_main_loop.c
+++ b/src/firmware_main_loop.c
@@ -176,7 +176,6 @@ void firmware_main_loop(void)
* If USB has generated events at the application level,
* process them now.
*/
- hww_process();
#if APP_U2F == 1
u2f_process();
#endif
diff --git a/src/hww.c b/src/hww.c
index 59bf2f6..c85046c 100644
--- a/src/hww.c
+++ b/src/hww.c
@@ -227,11 +227,6 @@ void hww_abort_outstanding_op(void)
rust_async_usb_cancel();
}
-void hww_process(void)
-{
- /** Nothing to do. */
-}
-
void hww_setup(void)
{
const CMD_Callback hww_cmd_callbacks[] = {{HWW_MSG, _msg}};
diff --git a/src/hww.h b/src/hww.h
index ef5a7dd..2403a4d 100644
--- a/src/hww.h
+++ b/src/hww.h
@@ -32,13 +32,6 @@ bool hww_blocking_request_can_go_through(const Packet* in_packet);
*/
void hww_blocked_req_error(Packet* out_packet, const Packet* in_packet);
-/**
- * Processes the async operations on the HWW USB stack.
- * This is not doing anything at the moment, as all user operations
- * are handled with blocking operations upon packet reception.
- */
-void hww_process(void);
-
/**
* Called to abort any operation that blocked the HWW stack.
*/
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.