What the developer wrote
Authored by Marko Bencun
rust/cbindgen: remove APP_ETH defines
What changed, and why it matters
This commit removes leftover build configuration lines related to Ethereum support from a code-generation config file. It does not change any firmware behavior, fix a bug, or alter how user funds or secrets are handled. It appears to be a cleanup change with no security relevance.
No security action needed. Treat as routine build/config cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes conditional APP_ETH preprocessor directives and a cbindgen ‘[defines]’ mapping from src/rust/bitbox02-cbindgen.toml. These lines told the cbindgen tool to define RUST_APP_ETHEREUM when the ‘app-ethereum’ Rust feature was enabled. Removing them likely reflects that the corresponding Rust code no longer relies on this define, or that the define was already unused. There is no runtime code change.
Changed components
src/rust/bitbox02-cbindgen.tomlInspect captured patch +0 / −8
diff --git a/src/rust/bitbox02-cbindgen.toml b/src/rust/bitbox02-cbindgen.toml
index 961f6af..0948dda 100644
--- a/src/rust/bitbox02-cbindgen.toml
+++ b/src/rust/bitbox02-cbindgen.toml
@@ -11,11 +11,6 @@ header = '''
#include "securechip/securechip.h"
#include "util.h"
#include <ui/components/confirm.h>
-
-#if APP_ETH == 1
-#define RUST_APP_ETHEREUM
-#endif
-
'''
[parse]
@@ -36,6 +31,3 @@ exclude = [
"free",
"Abort",
]
-
-[defines]
-"feature=app-ethereum" = "RUST_APP_ETHEREUM"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.