bitbox02_rust/ui: inline status wrapper
What the developer wrote
Authored by Marko Bencun
bitbox02_rust/ui: inline status wrapper
Inline status display into the BB02 HAL UI and remove the
obsolete workflow::status module.
What changed, and why it matters
This commit is a simple internal code cleanup: it removes a tiny wrapper function that displayed status messages and calls the underlying status function directly instead. There is no user-facing change, no bug fix, and no security relevance visible in the code.
No security action needed. Treat as ordinary refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change inlines workflow::status::status() into hal::bitbox02::ui::BitBox02Ui::status(). The deleted wrapper merely forwarded its arguments to bitbox02::ui::status(). The call chain is shortened by one hop, but behavior is identical. No logic, input handling, or trust boundary changes are present.
Changed components
src/rust/bitbox02-rust/src/hal/bitbox02/ui.rssrc/rust/bitbox02-rust/src/workflow.rssrc/rust/bitbox02-rust/src/workflow/status.rsInspect captured patch +2 / −9
diff --git a/src/rust/bitbox02-rust/src/hal/bitbox02/ui.rs b/src/rust/bitbox02-rust/src/hal/bitbox02/ui.rs
index a652976..128a80f 100644
--- a/src/rust/bitbox02-rust/src/hal/bitbox02/ui.rs
+++ b/src/rust/bitbox02-rust/src/hal/bitbox02/ui.rs
@@ -4,8 +4,7 @@ use alloc::string::String;
use crate::hal::Ui;
use crate::workflow::{
- cancel, confirm, menu, mnemonic, sdcard, status, transaction, trinary_choice,
- trinary_input_string,
+ cancel, confirm, menu, mnemonic, sdcard, transaction, trinary_choice, trinary_input_string,
};
pub(crate) struct BitBox02Ui;
@@ -46,7 +45,7 @@ impl Ui for BitBox02Ui {
#[inline(always)]
async fn status(&mut self, title: &str, status_success: bool) {
- status::status(title, status_success).await
+ bitbox02::ui::status(title, status_success).await
}
#[inline(always)]
diff --git a/src/rust/bitbox02-rust/src/workflow.rs b/src/rust/bitbox02-rust/src/workflow.rs
index b48ccc2..bb81e7a 100644
--- a/src/rust/bitbox02-rust/src/workflow.rs
+++ b/src/rust/bitbox02-rust/src/workflow.rs
@@ -12,7 +12,6 @@ pub mod orientation_screen;
pub mod pairing;
pub mod password;
pub mod sdcard;
-pub mod status;
pub mod transaction;
pub mod trinary_choice;
pub mod trinary_input_string;
diff --git a/src/rust/bitbox02-rust/src/workflow/status.rs b/src/rust/bitbox02-rust/src/workflow/status.rs
deleted file mode 100644
index 09d71ed..0000000
--- a/src/rust/bitbox02-rust/src/workflow/status.rs
+++ /dev/null
@@ -1,5 +0,0 @@
-// SPDX-License-Identifier: Apache-2.0
-
-pub async fn status(title: &str, status_success: bool) {
- bitbox02::ui::status(title, status_success).await;
-}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.