What the developer wrote
Authored by Marko Bencun
AGENTS.md: remove run-rust-unit-tests
What changed, and why it matters
This commit is a documentation-only change in the project's AGENTS.md file. It removes a shorthand make target ('make run-rust-unit-tests') and replaces it with the longer underlying cargo command that developers should run directly. There is no code change, no firmware change, and no security fix or vulnerability introduced.
No security action needed. Treat as a normal documentation/maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies AGENTS.md, a developer-facing instructions file. It deletes the bullet documenting ‘make run-rust-unit-tests’ and updates the pre-PR checklist to invoke ‘cargo test –manifest-path src/rust/Cargo.toml –all-features – –test-threads 1’ instead of the removed make target. No source code, build system logic, tests, or cryptographic code is altered.
Changed components
AGENTS.mdInspect captured patch +2 / −3
diff --git a/AGENTS.md b/AGENTS.md
index a0402ba..a355001 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -43,7 +43,6 @@ an explicit shell as the command, e.g. `./scripts/dev_exec.sh bash -lc 'cat vers
- `make firmware` / `make bootloader`: compile firmware or bootloader ELFs into `build/`.
- `make simulator`: build the Linux simulator under `build-build-noasan/bin/`.
- `make unit-test && make run-unit-tests`: build and run the C cmocka/CTest suite with ASan/UBSan.
-- `make run-rust-unit-tests`: build and run the Rust unit tests
- `make run-rust-clippy`: lint Rust code with the workspace configuration.
- When invoking the above `make` targets from the host, prefer
`./scripts/dev_exec.sh make <target>`.
@@ -69,8 +68,8 @@ bindings (`cbindgen`, protobuf) when interfaces change.
Place new C specs in `test/unit-test` and add doubles to `test/hardware-fakes` when hardware
behavior is mocked; follow the `test_<feature>.c` naming pattern and update CMake lists. Rust crates
use standard `tests/` modules or `#[cfg(test)]` blocks. Before opening a PR, run both `make
-run-unit-tests` and `make run-rust-unit-tests`, and refresh `make coverage` for cryptography or
-security-sensitive areas.
+run-unit-tests` and `cargo test --manifest-path src/rust/Cargo.toml --all-features -- --test-threads 1`,
+and refresh `make coverage` for cryptography or security-sensitive areas.
- in Rust unit tests, prefer .unwrap() over .expect().
- In Rust unit tests, if testing a function foo, name the test `test_foo` (or `test_foo_xyz` if it
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.