Merge remote-tracking branch 'agent/benma-agent/factory-context-size-comment'
What changed, and why it matters
This commit only updates a code comment to correct the stated memory savings from using a static secp256k1 verification context. No actual code behavior, logic, or security properties changed. It is a documentation-only fix.
No action required. This is a non-functional comment correction.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff changes one line in a comment within src/rust/bitbox02-rust-c/src/secp256k1.rs. The original comment claimed that avoiding the signing precomputation table saved roughly 35 kB in the factory image; the new comment states the saving is roughly 6.5 kB with a 2 KiB signing table. The surrounding code, including the use of ffi::secp256k1_context_no_precomp for signature verification, is unchanged.
Changed components
src/rust/bitbox02-rust-c/src/secp256k1.rsInspect captured patch +1 / −1
### src/rust/bitbox02-rust-c/src/secp256k1.rs
@@ -51,7 +51,7 @@ pub extern "C" fn rust_secp256k1_verify(
};
// Signature verification does not need a dynamically allocated signing context. Using the
// static context also avoids linking the signing precomputation table into factory setup,
- // saving roughly 35 kB in the image.
+ // saving roughly 6.5 kB in the image with the 2 KiB signing table.
unsafe {
ffi::secp256k1_ecdsa_verify(
ffi::secp256k1_context_no_precomp,Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.