btc: fix high-fee wording cutoff in vectors
What changed, and why it matters
This commit only updates test data and test expectations for the BitBox02 firmware. It changes which firmware versions are expected to show an old versus new high-fee warning message, because the real firmware already started showing the new wording in version 9.27.2, not 9.28.0. There is no change to the actual device firmware or to user-facing security behavior.
No security action needed. Treat as a normal test-maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch adjusts version cutoffs in Bitcoin transaction test vectors from 9.28.0 to 9.27.2 so that automated tests match the firmware’s actual high-fee warning wording. It touches only test-vector Rust code and JSON test data; no production firmware logic is modified. The change is purely a test-suite alignment.
Changed components
bitbox-test-vectors Rust crateBitcoin transaction test vectors JSONInspect captured patch +65 / −112
### src/rust/bitbox-test-vectors/src/btc_transaction/cases/screens.rs
@@ -26,10 +26,10 @@ const PSBT_OTHER_ACCOUNT_ADDRESS_GROUPED: &str =
// cannot be mistaken for the screens shown by the device.
const COMPLETE_TRANSACTION_SCREEN_CAPTURE_VERSION: &str = "9.20.0";
const LOCKTIME_CONFIRMATION_UPDATE_VERSION: &str = "9.27.0";
-const HIGH_FEE_WORDING_UPDATE_VERSION: &str = "9.28.0";
+const HIGH_FEE_WORDING_UPDATE_VERSION: &str = "9.27.2";
pub const DEVICE_POLICY_XPUB: &str = "[4c00739d/48'/1'/0'/3']tpubDF5MSzQdK2GfjmkNvrCZzpJhFt3if1HmrAdimugmGqWDCXYpkjxHpFZYuDxYYDAnnFMLMjLkMGvij2XV8pLtHBejgGy5RvNW4875nFGBDWv";
-/// Preserve the pre-v9.28 fee wording, splitting only ranges that span the wording change.
+/// Preserve the old fee wording, splitting only ranges that span the wording change.
pub(super) fn with_historical_fee_warnings(
expectations: Vec<VersionExpectation>,
) -> Vec<VersionExpectation> {
### src/rust/bitbox-test-vectors/src/btc_transaction/mod.rs
@@ -471,12 +471,12 @@ mod tests {
),
(
"high-fee-rounding",
- "9.27.2",
+ "9.27.1",
Some("The fee is 18.1%\nthe send amount.\nProceed?"),
),
(
"high-fee-rounding",
- "9.28.0",
+ "9.27.2",
Some("Fee is 18.1%\nof the send amount.\nProceed?"),
),
(
@@ -492,7 +492,7 @@ mod tests {
),
(
"all-change-high-fee",
- "9.28.0",
+ "9.27.2",
Some("Fee is 70.0%\nof all inputs.\nProceed?"),
),
(
### src/rust/bitbox-test-vectors/testdata/btc-transaction-test-vectors.json
@@ -41,7 +41,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -69,7 +69,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -152,7 +152,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -180,7 +180,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -344,7 +344,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -384,7 +384,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -544,7 +544,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -608,7 +608,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -792,7 +792,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -850,7 +850,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1034,7 +1034,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1098,7 +1098,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1231,7 +1231,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1259,7 +1259,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1355,7 +1355,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1383,7 +1383,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1504,7 +1504,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1532,7 +1532,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1638,7 +1638,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1666,7 +1666,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -1786,53 +1786,6 @@
},
{
"min_version": "9.27.2",
- "max_version_exclusive": "9.28.0",
- "outcome": "success",
- "screens": [
- {
- "type": "transaction_address",
- "amount": "0.20000000 TBTC",
- "address": "Test Merchant"
- },
- {
- "type": "confirm",
- "title": "",
- "body": "Memo from: Test Merchant",
- "longtouch": false
- },
- {
- "type": "confirm",
- "title": "Memo 1/2",
- "body": "TextMemo line1",
- "longtouch": false
- },
- {
- "type": "confirm",
- "title": "Memo 2/2",
- "body": "TextMemo line2",
- "longtouch": false
- },
- {
- "type": "transaction_fee",
- "amount": "0.50000000 TBTC",
- "fee": "0.30000000 TBTC",
- "longtouch": false
- },
- {
- "type": "confirm",
- "title": "High fee",
- "body": "The fee is 150.0%\nthe send amount.\nProceed?",
- "longtouch": true
- },
- {
- "type": "status",
- "title": "Transaction",
- "body": "confirmed"
- }
- ]
- },
- {
- "min_version": "9.28.0",
"outcome": "success",
"screens": [
{
@@ -2365,7 +2318,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -2414,7 +2367,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -2523,7 +2476,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -2557,7 +2510,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -2696,7 +2649,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -2724,7 +2677,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -2801,7 +2754,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -2829,7 +2782,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -2906,7 +2859,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -2934,7 +2887,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3052,7 +3005,7 @@
},
{
"min_version": "9.27.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3086,7 +3039,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3210,7 +3163,7 @@
},
{
"min_version": "9.27.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3244,7 +3197,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3368,7 +3321,7 @@
},
{
"min_version": "9.27.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3402,7 +3355,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3526,7 +3479,7 @@
},
{
"min_version": "9.27.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3560,7 +3513,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3643,7 +3596,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3671,7 +3624,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3884,7 +3837,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -3918,7 +3871,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -4083,7 +4036,7 @@
},
{
"min_version": "9.27.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -4106,7 +4059,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -4179,7 +4132,7 @@
},
{
"min_version": "9.27.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -4208,7 +4161,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -4379,7 +4332,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -4419,7 +4372,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -4564,7 +4517,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -4604,7 +4557,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -4783,7 +4736,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -4847,7 +4800,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -5049,7 +5002,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -5119,7 +5072,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -5333,7 +5286,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -5403,7 +5356,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -5539,7 +5492,7 @@
},
{
"min_version": "9.27.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -5603,7 +5556,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -5787,7 +5740,7 @@
},
{
"min_version": "9.26.0",
- "max_version_exclusive": "9.28.0",
+ "max_version_exclusive": "9.27.2",
"outcome": "success",
"screens": [
{
@@ -5851,7 +5804,7 @@
]
},
{
- "min_version": "9.28.0",
+ "min_version": "9.27.2",
"outcome": "success",
"screens": [
{Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.