AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 40 Bitcoin

btc: warn on high all-change fees

Public commit record

What the developer wrote

Authored by benma's agent

78/100 · Adequate
btc: warn on high all-change fees

Use the verified input total as the fee-warning denominator when a
transaction has no external output value. This covers all-change and
OP_RETURN-only transactions without introducing an absolute fee policy.

Label the denominator explicitly and add regression coverage for both
high-fee and below-threshold cases.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit fixes a fee-warning gap in the BitBox02 Bitcoin signing flow. Previously, transactions that only sent money back to yourself (change outputs) or only carried an OP_RETURN message had no 'send amount' to compare the fee against, so the device would not warn even if the fee was huge. The patch now compares the fee to the total value of all transaction inputs in those cases, and still warns the user when the fee exceeds 10% of that total. It also updates the on-screen wording to say whether the percentage is relative to the send amount or to all inputs.

Recommended action

Treat as a security-hardening fix and include in the next firmware release. No immediate incident response is indicated, but users should be advised to update so that abnormal all-change/OP_RETURN fees trigger the usual on-device warning.

Security signals we found

01

Missing fee sanity check for edge-case transaction shapes

02

User-interface warning now covers all-change and OP_RETURN-only transactions

03

Fee denominator changed from external outputs to verified input total for no-external-output transactions

04

Regression tests added for high-fee and below-threshold cases

Risk score

Why this scored 40/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 6/15
Affected reach 7/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.