Merge branch 'nickez-agent/delete-wallet-copy'
What changed, and why it matters
This commit only changes the on-screen wording shown when resetting a BitBox02 device. Phrases like 'factory reset' are replaced with 'delete wallet from this device'. The actual reset behavior, code flow, and security checks are unchanged. There is no security fix or vulnerability here.
No security action needed. Treat as a normal localization/UX wording change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch updates translation strings and their matching Rust unit-test expectations in the reset/factory-reset code path. No functional logic, confirmation requirements, secure-element operations, or API behavior are modified. It is a pure UI-string refactor.
Changed components
device reset UI stringsi18n translation files (en/de)reset module unit testsInspect captured patch +20 / −20
### src/i18n/locales/de/firmware.json
@@ -197,9 +197,9 @@
}
},
"reset": {
- "body": "In Werkszustand\nzurücksetzen?",
- "status": "Zurückgesetzt",
- "title": "Zurücksetzen"
+ "body": "Wallet vom\nGerät löschen?",
+ "status": "Wallet vom Gerät\ngelöscht",
+ "title": "Löschen"
},
"restore": {
"backupName": "Name: {}. ID: {}",
### src/i18n/locales/en/firmware.json
@@ -197,9 +197,9 @@
}
},
"reset": {
- "body": "Proceed to\nfactory reset?",
- "status": "Device reset",
- "title": "RESET"
+ "body": "Delete your wallet\nfrom this device?",
+ "status": "Wallet deleted\nfrom this device",
+ "title": "Delete"
},
"restore": {
"backupName": "Name: {}. ID: {}",
### src/rust/bitbox02-rust/src/hww.rs
@@ -626,12 +626,12 @@ mod tests {
mock_hal.ui.screens,
vec![
Screen::Confirm {
- title: "RESET".into(),
- body: "Proceed to\nfactory reset?".into(),
+ title: "Delete".into(),
+ body: "Delete your wallet\nfrom this device?".into(),
longtouch: true,
},
Screen::Status {
- title: "Device reset".into(),
+ title: "Wallet deleted\nfrom this device".into(),
success: true,
}
]
### src/rust/bitbox02-rust/src/hww/api/reset.rs
@@ -10,8 +10,8 @@ use pb::response::Response;
use crate::hal::Ui;
pub async fn process(hal: &mut impl crate::hal::Hal) -> Result<Response, Error> {
- let title = crate::tr!(hal, "RESET");
- let body = crate::tr!(hal, "Proceed to\nfactory reset?");
+ let title = crate::tr!(hal, "Delete");
+ let body = crate::tr!(hal, "Delete your wallet\nfrom this device?");
let params = ConfirmParams {
title: &title,
body: &body,
@@ -44,8 +44,8 @@ mod tests {
assert_eq!(
mock_hal.ui.screens,
vec![Screen::Confirm {
- title: "RESET".into(),
- body: "Proceed to\nfactory reset?".into(),
+ title: "Delete".into(),
+ body: "Delete your wallet\nfrom this device?".into(),
longtouch: true,
}],
);
@@ -65,12 +65,12 @@ mod tests {
mock_hal.ui.screens,
vec![
Screen::Confirm {
- title: "RESET".into(),
- body: "Proceed to\nfactory reset?".into(),
+ title: "Delete".into(),
+ body: "Delete your wallet\nfrom this device?".into(),
longtouch: true,
},
Screen::Status {
- title: "Device reset".into(),
+ title: "Wallet deleted\nfrom this device".into(),
success: true,
}
],
### src/rust/bitbox02-rust/src/reset.rs
@@ -9,11 +9,11 @@ use crate::i18n::I18n as _;
/// - Resets the securechip EEPROM (U2F counter).
/// - Resets MCU flash app memory.
/// - Disables SmartEEPROM memory (will be erased/setup on next boot).
-/// - Shows a "Device reset" status message.
+/// - Shows a "Wallet deleted from this device" status message.
///
/// `status` selects whether the status message indicates success or failure (user invoked vs forced).
pub(crate) async fn reset(hal: &mut impl crate::hal::Hal, status: bool) {
- let status_title = crate::tr!(hal, "Device reset");
+ let status_title = crate::tr!(hal, "Wallet deleted\nfrom this device");
crate::keystore::lock();
// Resetting takes longer than the default 500 ms watchdog. Bump the watchdog timeout to roughly
// 7 seconds (longer than needed) so we don't assume communication was lost and this task gets
@@ -123,7 +123,7 @@ mod tests {
assert_eq!(
hal.ui.screens,
vec![Screen::Status {
- title: "Device reset".into(),
+ title: "Wallet deleted\nfrom this device".into(),
success: true,
}],
);
@@ -137,7 +137,7 @@ mod tests {
assert_eq!(
hal.ui.screens,
vec![Screen::Status {
- title: "Device reset".into(),
+ title: "Wallet deleted\nfrom this device".into(),
success: false,
}],
);Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.