chore: Move args to black one level up
What the developer wrote
Authored by Niklas Dusenlund
chore: Move args to black one level up
`./scripts/format-python` wasn't working because the configration wasn't
applied. Move the args so that `format-python` can be used.
What changed, and why it matters
This is a trivial developer tooling change. It moves command-line options for the Python code formatter (black) from one script into another so that the formatting script works correctly. There is no change to firmware, cryptography, wallet behavior, or anything user-facing.
No security action needed. Treat as normal code-quality/maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit relocates the --config py/pyproject.toml --fast arguments from .ci/check-pep8 into scripts/format-python. Previously format-python did not pass the project configuration, causing it to fail or behave inconsistently. The CI check now simply calls ./scripts/format-python --check --diff <files>. This is a build/development workflow fix only.
Changed components
.ci/check-pep8scripts/format-pythonInspect captured patch +2 / −2
diff --git a/.ci/check-pep8 b/.ci/check-pep8
index b037f33..a59a785 100755
--- a/.ci/check-pep8
+++ b/.ci/check-pep8
@@ -16,7 +16,7 @@ if [ -z "${FILES}" ] ; then
exit 0
fi
-./scripts/format-python --config py/pyproject.toml --check --fast --diff ${FILES}
+./scripts/format-python --check --diff ${FILES}
# We lint all default Python files, as linting only a subset can lead to errors (e.g. if
# send_message.py only is linted without the bitbox02 dep).
./scripts/lint-python
diff --git a/scripts/format-python b/scripts/format-python
index 035f9e8..1daf9a8 100755
--- a/scripts/format-python
+++ b/scripts/format-python
@@ -19,4 +19,4 @@ if [ $# -eq 0 ] ; then
ARGS=($(find py -name '*.py' | grep -v -e generated -e old))
fi
-LC_ALL=C.UTF-8 ${BLACK} "${ARGS[@]}"
+LC_ALL=C.UTF-8 ${BLACK} --config py/pyproject.toml --fast "${ARGS[@]}"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.