What the developer wrote
Authored by Niklas Dusenlund
da14531: avoid swd in unit tests
What changed, and why it matters
This commit adjusts build conditions so that a low-level hardware reset routine for the Bluetooth chip is skipped during automated unit-test builds. It is a build/test hygiene change rather than a fix for an exploitable security flaw in production firmware. There is no direct evidence that this change was made in response to a security incident or vulnerability report.
No immediate action required. Treat as routine build/test maintenance. If auditing, verify that production release builds still define `NDEBUG` and do not define `FACTORYSETUP`, ensuring SWD reset remains excluded from shipping firmware.
Security signals we found
Build configuration hardening: removes debug/hardware interface code from test build paths
No change to production runtime behavior
No input validation, memory safety, or cryptographic changes
Evidence from the diff
The patch adds && !defined(TESTING) to two preprocessor guards that previously enabled an SWD (Serial Wire Debug) reset routine for the DA14531 Bluetooth chip only in factory-setup or non-debug (NDEBUG not defined) builds. The change prevents that routine from being compiled into unit-test builds, presumably because unit tests cannot exercise physical SWD/JTAG operations. The production condition remains unchanged: SWD reset is still excluded from release/production builds where NDEBUG is defined and FACTORYSETUP is not set.
Changed components
src/da14531/da14531_protocol.cDA14531 Bluetooth protocol initialization and pollingUnit-test build targetInspect captured patch +2 / −2
diff --git a/src/da14531/da14531_protocol.c b/src/da14531/da14531_protocol.c
index 1f70d2c..d0efdc2 100644
--- a/src/da14531/da14531_protocol.c
+++ b/src/da14531/da14531_protocol.c
@@ -416,7 +416,7 @@ struct da14531_protocol_frame* da14531_protocol_poll(
return frame;
}
-#if FACTORYSETUP == 1 || !defined(NDEBUG)
+#if (FACTORYSETUP == 1 || !defined(NDEBUG)) && !defined(TESTING)
static bool _swd_reset_da14531(void)
{
dap_init();
@@ -460,7 +460,7 @@ void da14531_protocol_init(void)
// Only attempt swd reset in factory setup or debug builds. In production swd is turned off and
// this is therefore useless.
-#if FACTORYSETUP == 1 || !defined(NDEBUG)
+#if (FACTORYSETUP == 1 || !defined(NDEBUG)) && !defined(TESTING)
// Load the firmware from external flash to RAM so that we are ready to flash.
if (ble_fw == NULL) {
if (!memory_spi_get_active_ble_firmware(&ble_fw, &ble_fw_size, &ble_fw_checksum)) {
Why this scored 17/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.