← Watch feed
simulator-graphical-bb03: remove bitbox02_rust_c dep
Public commit record
50/100 · Thin
What the developer wrote
Authored by Marko Bencun
simulator-graphical-bb03: remove bitbox02_rust_c dep
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
What changed, and why it matters
This commit removes an unused Rust library dependency from a graphical simulator test program. It is a routine cleanup change with no security relevance.
Recommended action
No security action required. Treat as routine maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes the bitbox02-rust-c dependency from test/simulator-graphical-bb03. It deletes the crate from Cargo.toml, removes the extern crate bitbox02_rust_c; statement from main.rs, and updates Cargo.lock to drop the crate and its transitive dependencies. This is a build/test cleanup with no functional or security changes to the firmware.
Changed components
test/simulator-graphical-bb03/Cargo.tomltest/simulator-graphical-bb03/Cargo.locktest/simulator-graphical-bb03/src/main.rsInspect captured patch +2 / −169
diff --git a/test/simulator-graphical-bb03/Cargo.lock b/test/simulator-graphical-bb03/Cargo.lock
index bcd6c8f..8d21a86 100644
--- a/test/simulator-graphical-bb03/Cargo.lock
+++ b/test/simulator-graphical-bb03/Cargo.lock
@@ -293,17 +293,6 @@ version = "0.1.4"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "383d29d513d8764dcdc42ea295d979eb99c3c9f00607b3692cf68a431f7dca72"
-[[package]]
-name = "bip32-ed25519"
-version = "0.2.1"
-source = "git+https://github.com/BitBoxSwiss/rust-bip32-ed25519?tag=v0.2.1#385d8a907f694aab7ca3f61ad603804c72ac520a"
-dependencies = [
- "curve25519-dalek",
- "digest",
- "hmac",
- "zeroize",
-]
-
[[package]]
name = "bip39"
version = "2.2.0"
@@ -436,7 +425,6 @@ name = "bitbox02-rust"
version = "0.1.0"
dependencies = [
"binascii",
- "bip32-ed25519",
"bip39",
"bitbox-aes",
"bitbox-bytequeue",
@@ -450,47 +438,15 @@ dependencies = [
"bitbox02-noise",
"bitcoin",
"bitcoin_hashes",
- "blake2",
- "crc",
"digest",
- "ed25519-dalek",
- "erc20_params",
"futures-lite",
"hex",
"hex_lit",
"hmac",
- "keccak",
- "minicbor",
- "miniscript",
- "num-bigint",
"num-traits",
"prost",
"serde_json",
"sha2",
- "sha3",
- "streaming-silent-payments",
- "util",
- "zeroize",
-]
-
-[[package]]
-name = "bitbox02-rust-c"
-version = "0.1.0"
-dependencies = [
- "bip39",
- "bitbox-aes",
- "bitbox-bytequeue",
- "bitbox-da14531",
- "bitbox-framed-serial-link",
- "bitbox-hal",
- "bitbox-usb-report-queue",
- "bitbox02",
- "bitbox02-noise",
- "bitbox02-rust",
- "cortex-m",
- "der",
- "grounded",
- "hex",
"util",
"zeroize",
]
@@ -527,7 +483,7 @@ dependencies = [
"bitcoin-io",
"bitcoin-units",
"bitcoin_hashes",
- "hex-conservative 0.2.2",
+ "hex-conservative",
"hex_lit",
"secp256k1",
]
@@ -560,7 +516,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "26ec84b80c482df901772e931a9a681e26a1b9ee2302edeff23cb30328745c8b"
dependencies = [
"bitcoin-io",
- "hex-conservative 0.2.2",
+ "hex-conservative",
]
[[package]]
@@ -590,15 +546,6 @@ dependencies = [
"core2",
]
-[[package]]
-name = "blake2"
-version = "0.10.6"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "46502ad458c9a52b69d4d4d32775c788b7a1b85e8bc9d482d92250fc0e3f8efe"
-dependencies = [
- "digest",
-]
-
[[package]]
name = "block-buffer"
version = "0.10.4"
@@ -1016,7 +963,6 @@ dependencies = [
"cfg-if",
"cpufeatures",
"curve25519-dalek-derive",
- "digest",
"fiat-crypto",
"rustc_version 0.4.1",
"subtle",
@@ -1033,12 +979,6 @@ dependencies = [
"syn",
]
-[[package]]
-name = "der"
-version = "0.7.10"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "e7c1832837b905bbfb5101e07cc24c8deddf52f93225eee6ead5f4d63d53ddcb"
-
[[package]]
name = "deranged"
version = "0.5.5"
@@ -1096,28 +1036,6 @@ version = "0.1.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "d8b14ccef22fc6f5a8f4d7d768562a182c04ce9a3b3157b91390b52ddfdf1a76"
-[[package]]
-name = "ed25519"
-version = "2.2.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "115531babc129696a58c64a4fef0a8bf9e9698629fb97e9e40767d235cfbcd53"
-dependencies = [
- "signature",
-]
-
-[[package]]
-name = "ed25519-dalek"
-version = "2.2.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "70e796c081cee67dc755e1a36a0a172b897fab85fc3f6bc48307991f64e4eca9"
-dependencies = [
- "curve25519-dalek",
- "ed25519",
- "sha2",
- "signature",
- "subtle",
-]
-
[[package]]
name = "either"
version = "1.15.0"
@@ -1160,13 +1078,6 @@ version = "1.0.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "877a4ace8713b0bcf2a4e7eec82529c029f1d0619886d18145fea96c3ffe5c0f"
-[[package]]
-name = "erc20_params"
-version = "0.1.0"
-dependencies = [
- "hex",
-]
-
[[package]]
name = "errno"
version = "0.3.14"
@@ -1527,12 +1438,6 @@ dependencies = [
"arrayvec",
]
-[[package]]
-name = "hex-conservative"
-version = "1.0.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "366fa3443ac84474447710ec17bb00b05dfbd096137817981e86f992f21a2793"
-
[[package]]
name = "hex_lit"
version = "0.1.1"
@@ -1681,15 +1586,6 @@ dependencies = [
"wasm-bindgen",
]
-[[package]]
-name = "keccak"
-version = "0.1.5"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ecc2af9a1119c51f12a14607e783cb977bde58bc069ff0c3da1095e635d70654"
-dependencies = [
- "cpufeatures",
-]
-
[[package]]
name = "khronos_api"
version = "3.1.0"
@@ -1818,37 +1714,6 @@ dependencies = [
"libc",
]
-[[package]]
-name = "minicbor"
-version = "0.24.4"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "29be4f60e41fde478b36998b88821946aafac540e53591e76db53921a0cc225b"
-dependencies = [
- "minicbor-derive",
-]
-
-[[package]]
-name = "minicbor-derive"
-version = "0.15.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "bd2209fff77f705b00c737016a48e73733d7fbccb8b007194db148f03561fb70"
-dependencies = [
- "proc-macro2",
- "quote",
- "syn",
-]
-
-[[package]]
-name = "miniscript"
-version = "13.0.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "867b1f11e0545ad5ebbddd8a9f18756d9657a6758bf10d96cf15ddd0b726b650"
-dependencies = [
- "bech32",
- "bitcoin",
- "hex-conservative 1.0.1",
-]
-
[[package]]
name = "miniz_oxide"
version = "0.8.9"
@@ -2907,16 +2772,6 @@ dependencies = [
"digest",
]
-[[package]]
-name = "sha3"
-version = "0.10.8"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "75872d278a8f37ef87fa0ddbda7802605cb18344497949862c0d4dcb291eba60"
-dependencies = [
- "digest",
- "keccak",
-]
-
[[package]]
name = "sharded-slab"
version = "0.1.7"
@@ -2932,15 +2787,6 @@ version = "1.3.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "0fda2ff0d084019ba4d7c6f371c95d8fd75ce3524c3cb8fb653a3023f6323e64"
-[[package]]
-name = "signature"
-version = "2.2.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "77549399552de45a898a580c1b41d445bf730df867cc44e6c0233bbc4b8329de"
-dependencies = [
- "digest",
-]
-
[[package]]
name = "simd-adler32"
version = "0.3.8"
@@ -2965,7 +2811,6 @@ dependencies = [
"bitbox-lvgl",
"bitbox-usb-report-queue",
"bitbox02-rust",
- "bitbox02-rust-c",
"bitbox03",
"clap",
"critical-section",
@@ -3041,14 +2886,6 @@ version = "1.2.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "6ce2be8dc25455e1f91df71bfa12ad37d7af1092ae736f3a6cd0e37bc7810596"
-[[package]]
-name = "streaming-silent-payments"
-version = "0.1.0"
-dependencies = [
- "bitbox-secp256k1",
- "bitcoin",
-]
-
[[package]]
name = "strict-num"
version = "0.1.1"
@@ -3358,7 +3195,6 @@ dependencies = [
"critical-section",
"hex",
"num-bigint",
- "sha2",
"time",
"zeroize",
]
diff --git a/test/simulator-graphical-bb03/Cargo.toml b/test/simulator-graphical-bb03/Cargo.toml
index 98a2e28..d1baac9 100644
--- a/test/simulator-graphical-bb03/Cargo.toml
+++ b/test/simulator-graphical-bb03/Cargo.toml
@@ -7,7 +7,6 @@ edition = "2024"
bitbox-hal = { path = "../../src/rust/bitbox-hal" }
bitbox-usb-report-queue = { path = "../../src/rust/bitbox-usb-report-queue" }
bitbox02-rust = { path = "../../src/rust/bitbox02-rust", features = ["simulator-graphical"] }
-bitbox02-rust-c = { path = "../../src/rust/bitbox02-rust-c", features = ["simulator-graphical"] }
bitbox-aes = { path = "../../src/rust/bitbox-aes" }
winit = "0.30.12"
tracing = { version = "0.1.41", features = ["log"] }
diff --git a/test/simulator-graphical-bb03/src/main.rs b/test/simulator-graphical-bb03/src/main.rs
index 8923524..070f722 100644
--- a/test/simulator-graphical-bb03/src/main.rs
+++ b/test/simulator-graphical-bb03/src/main.rs
@@ -43,8 +43,6 @@ use bitbox_hal::{Hal, Ui, system::System};
use bitbox03::BitBox03;
use bitbox03::io::touchscreen::{TouchScreen, TouchScreenEvent};
-// Explicitly link library for its C exports
-extern crate bitbox02_rust_c;
use bitbox_lvgl as lvgl;
use lvgl::LvDisplayRenderMode;
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.