What the developer wrote
Authored by Marko Bencun
build: remove used nanopb defs
PB_ defs were from when we used nanopb, which we dropped a long time ago.
What changed, and why it matters
This commit simply removes two leftover compiler definitions that were used by an old library (nanopb) the project no longer uses. It is a cleanup change with no security relevance.
No action needed; this is a benign build cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change deletes -DPB_NO_PACKED_STRUCTS=1 and -DPB_FIELD_16BIT=1 from the definitions vector in src/rust/bitbox02-sys/build.rs. These macros were only meaningful when the firmware used nanopb for Protocol Buffers; the project has since dropped nanopb. The remaining APP_* feature flags are unchanged. There is no functional or security change.
Changed components
src/rust/bitbox02-sys/build.rsInspect captured patch +1 / −8
diff --git a/src/rust/bitbox02-sys/build.rs b/src/rust/bitbox02-sys/build.rs
index 3a947b1..dd98f8d 100644
--- a/src/rust/bitbox02-sys/build.rs
+++ b/src/rust/bitbox02-sys/build.rs
@@ -450,14 +450,7 @@ pub fn main() -> BuildResult<()> {
// Needs to match the definitions in `CMakeList.txt' files (unit tests, hardware fakes and
// simulator)
- let mut definitions = vec![
- "-DPB_NO_PACKED_STRUCTS=1",
- "-DPB_FIELD_16BIT=1",
- "-DAPP_BTC=1",
- "-DAPP_LTC=1",
- "-DAPP_U2F=1",
- "-DAPP_ETH=1",
- ];
+ let mut definitions = vec!["-DAPP_BTC=1", "-DAPP_LTC=1", "-DAPP_U2F=1", "-DAPP_ETH=1"];
definitions.extend(&extra_flags);
run_command(
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.