rust: put critical-section into workspace deps
What the developer wrote
Authored by Marko Bencun
rust: put critical-section into workspace deps
What changed, and why it matters
This commit is a routine housekeeping change in the Rust build configuration. It moves the 'critical-section' library from being declared separately in two sub-crates to a single shared workspace dependency. There is no change to the actual firmware code, behavior, or security logic.
No security action required. Treat as normal build maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch refactors Cargo.toml dependency declarations. It adds ‘critical-section’ to the workspace root (src/rust/Cargo.toml) and replaces two explicit versioned declarations in bitbox-securechip/Cargo.toml and util/Cargo.toml with workspace = true references. The effective version (1.2.0), default-features = false setting, and feature flags (empty) remain identical. No source code, API usage, or runtime behavior is modified.
Changed components
src/rust/Cargo.tomlsrc/rust/bitbox-securechip/Cargo.tomlsrc/rust/util/Cargo.tomlInspect captured patch +4 / −3
diff --git a/src/rust/Cargo.toml b/src/rust/Cargo.toml
index 855b4f8..cabaa45 100644
--- a/src/rust/Cargo.toml
+++ b/src/rust/Cargo.toml
@@ -60,6 +60,7 @@ crc = "3.0.1"
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
grounded = { version = "0.2.0", default-features = false, features = ["critical-section"] }
+critical-section = { version = "1.2.0", default-features = false }
[patch.crates-io]
rtt-target = { git = "https://github.com/probe-rs/rtt-target.git", rev = "117d9519a5d3b1f4bc024bc05f9e3c5dec0a57f5" }
diff --git a/src/rust/bitbox-securechip/Cargo.toml b/src/rust/bitbox-securechip/Cargo.toml
index 4abe17e..f3d7773 100644
--- a/src/rust/bitbox-securechip/Cargo.toml
+++ b/src/rust/bitbox-securechip/Cargo.toml
@@ -10,7 +10,7 @@ license = "Apache-2.0"
[dependencies]
bitbox-securechip-sys = { path = "../bitbox-securechip-sys" }
-critical-section = { version = "1.2.0", default-features = false, features = [] }
+critical-section = { workspace = true }
grounded = { workspace = true }
util = { path = "../util" }
zeroize = { workspace = true }
diff --git a/src/rust/util/Cargo.toml b/src/rust/util/Cargo.toml
index 7717372..49aeb92 100644
--- a/src/rust/util/Cargo.toml
+++ b/src/rust/util/Cargo.toml
@@ -14,8 +14,8 @@ cortex-m = { workspace = true }
hex = {workspace = true}
sha2 = { workspace = true, optional = true }
p256 = { version = "0.13.2", default-features = false, features = ["arithmetic", "ecdsa"], optional = true }
-bitcoin = {workspace = true}
-critical-section = { version = "1.2.0", default-features = false, features = [] }
+bitcoin = { workspace = true }
+critical-section = { workspace = true }
zeroize = { workspace = true }
time = { version = "0.3.44", default-features = false }
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.