What the developer wrote
Authored by Niklas Dusenlund
cmake: Remove unused variable
What changed, and why it matters
This commit removes an unused CMake variable and the code that built it. It is a routine cleanup with no apparent security relevance.
No security action needed. Treat as normal build-system maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes a block in src/CMakeLists.txt that collected INTERFACE_INCLUDE_DIRECTORIES from several targets (samd51a-ds, asf4-drivers-min, asf4-drivers, CMSIS, wallycore, secp256k1) and assembled them into RUST_INCLUDES. The variable RUST_INCLUDES is no longer used elsewhere, so this is dead-code removal. No functional or security behavior changes.
Changed components
src/CMakeLists.txtInspect captured patch +0 / −17
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 750cf21..6307d1c 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -275,23 +275,6 @@ add_custom_target(rust-cbindgen
${CMAKE_CURRENT_BINARY_DIR}/rust/rust.h
)
-if(CMAKE_CROSSCOMPILING)
- get_property(SAMD51A_INCLUDES TARGET samd51a-ds PROPERTY INTERFACE_INCLUDE_DIRECTORIES)
- get_property(ASF4_MIN_INCLUDES TARGET asf4-drivers-min PROPERTY INTERFACE_INCLUDE_DIRECTORIES)
- get_property(ASF4_INCLUDES TARGET asf4-drivers PROPERTY INTERFACE_INCLUDE_DIRECTORIES)
- get_property(CMSIS_INCLUDES TARGET CMSIS PROPERTY INTERFACE_INCLUDE_DIRECTORIES)
-endif()
-get_property(WALLY_INCLUDES TARGET wallycore PROPERTY INTERFACE_INCLUDE_DIRECTORIES)
-get_property(SECP256k1_INCLUDES TARGET secp256k1 PROPERTY INTERFACE_INCLUDE_DIRECTORIES)
-
-foreach(include ${INCLUDES} ${SAMD51A_INCLUDES} ${ASF4_INCLUDES} ${ASF4_MIN_INCLUDES} ${CMSIS_INCLUDES} ${WALLY_INCLUDES} ${SECP256k1_INCLUDES})
- list(APPEND RUST_INCLUDES -I${include})
-endforeach()
-if(NOT (CMAKE_CROSSCOMPILING AND NOT ${CMAKE_SYSTEM_NAME} MATCHES "Darwin"))
- list(APPEND RUST_INCLUDES -I${CMAKE_SOURCE_DIR}/test/unit-test/framework/includes)
-endif()
-
-
# Test rust crates that contain business logic. Avoid testing crates that depend on hardware.
if(NOT CMAKE_CROSSCOMPILING)
# Since we build with all features we need to use a separate build directory.
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.