simulator-graphical-bb03: remove test screen pop
What the developer wrote
Authored by Marko Bencun
simulator-graphical-bb03: remove test screen pop
What changed, and why it matters
This commit removes a leftover test/debug feature from the graphical simulator for the BitBox03 hardware wallet. The simulator used to automatically switch to the logo screen after 5,000 internal 'wake-up' events. That behavior was only for local testing and never affected real devices or user funds.
No security action required. This is a routine cleanup of simulator test code.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In test/simulator-graphical-bb03/src/main.rs, the commit deletes a counter field and the conditional call to self.bitbox.ui().switch_to_logo() after 5,000 UserEvent::WakeUp events. The Ui trait import is also removed because it is no longer needed. This is a cleanup of simulator-only test code; no firmware logic, cryptographic operations, or device behavior is changed.
Changed components
test/simulator-graphical-bb03/src/main.rsInspect captured patch +1 / −8
diff --git a/test/simulator-graphical-bb03/src/main.rs b/test/simulator-graphical-bb03/src/main.rs
index 11ad687..59237b5 100644
--- a/test/simulator-graphical-bb03/src/main.rs
+++ b/test/simulator-graphical-bb03/src/main.rs
@@ -42,7 +42,7 @@ use glutin_winit::DisplayBuilder;
use tracing::{debug, error, info};
use tracing_subscriber::{EnvFilter, filter::LevelFilter, fmt, prelude::*};
-use bitbox_hal::{Hal, Ui, system::System};
+use bitbox_hal::{Hal, system::System};
use bitbox03::io::touchscreen::{TouchScreen, TouchScreenEvent};
use hal::BitBox03;
@@ -252,7 +252,6 @@ struct App {
outbound_in: Option<mpsc::Sender<[u8; 64]>>,
inbound_out: Option<mpsc::Receiver<[u8; 64]>>,
startup_task: Option<util::bb02_async::Task<'static, ()>>,
- counter: usize,
transport: Option<bitbox02_rust::hww::transport::HwwTransport<BitBox03>>,
started_at: Instant,
}
@@ -273,7 +272,6 @@ impl App {
outbound_in: Default::default(),
inbound_out: Default::default(),
startup_task: Default::default(),
- counter: 0,
transport: Default::default(),
started_at: Instant::now(),
}
@@ -612,11 +610,6 @@ impl ApplicationHandler<UserEvent> for App {
fn user_event(&mut self, _event_loop: &ActiveEventLoop, event: UserEvent) {
match event {
UserEvent::WakeUp => {
- self.counter += 1;
- if self.counter == 5000 {
- info!("test switch to logo (pop)");
- self.bitbox.ui().switch_to_logo();
- }
let now_ms = self.started_at.elapsed().as_millis() as u64;
// Read data from TCP client
let mut inbound_out = self.inbound_out.take();
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.