maintenance: upload simulator artifact in CI.
What the developer wrote
Authored by Nikolas De Giorgis
maintenance: upload simulator artifact in CI.
This way we can iteratively use new versions of the simulator without
the need for a new release.
We remove the old step that just built the simulator, but did nothing
with it, and include the simulator in the process that builds and
uploads artifact for several targets.
What changed, and why it matters
This is a routine GitHub Actions CI maintenance change. It removes a separate build-only step for the BitBox02 simulator and instead adds the simulator to the existing CI job that builds and uploads artifacts for several targets. There is no change to firmware code, cryptography, or any user-facing behavior.
No security action needed. This is a benign CI workflow change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies .github/workflows/ci-common.yml. It deletes the standalone ‘simulator’ job that only ran ‘make simulator’ without producing artifacts, and adds ‘simulator’ to the matrix of the existing ‘artifacts’ job. The artifacts job’s upload step now also includes build*/bin/simulator. This is purely a CI pipeline consolidation to publish simulator binaries as CI artifacts.
Changed components
.github/workflows/ci-common.ymlInspect captured patch +2 / −17
diff --git a/.github/workflows/ci-common.yml b/.github/workflows/ci-common.yml
index 61f2004..8aa3cd8 100644
--- a/.github/workflows/ci-common.yml
+++ b/.github/workflows/ci-common.yml
@@ -109,23 +109,6 @@ jobs:
- name: run ATECC608 unit tests
run: (cd tools/atecc608; go test ./...)
- simulator:
- runs-on: ubuntu-22.04
- container: ${{ inputs.container-repo }}:${{ inputs.container-version }}
- steps:
- - name: Clone the repo
- uses: actions/checkout@v4
- with:
- fetch-depth: 0
- fetch-tags: true
- submodules: recursive
-
- - name: Mark directory as safe
- run: git config --global --add safe.directory $GITHUB_WORKSPACE
-
- - name: Build simulator
- run: make -j$(($(nproc) + 1)) simulator
-
leakcheck:
runs-on: ubuntu-22.04
container: ${{ inputs.container-repo }}:${{ inputs.container-version }}
@@ -183,6 +166,7 @@ jobs:
- firmware-btc
- factory-setup
- firmware-debug
+ - simulator
runs-on: ubuntu-22.04
container:
image: ${{ inputs.container-repo }}:${{ inputs.container-version }}
@@ -221,6 +205,7 @@ jobs:
build*/bin/*.bin
build*/bin/*.elf
build*/bin/*.map
+ build*/bin/simulator
doc:
runs-on: ubuntu-22.04
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.