What the developer wrote
Authored by Marko Bencun
AGENTS: add review guidelines
Document review guidance for removed function calls.
What changed, and why it matters
This commit only adds two sentences of documentation to the project's AGENTS.md file, giving reviewers guidance on what to check when a function call is removed in a code change. It does not modify any firmware code, cryptographic logic, build scripts, tests, or configuration. There is no security issue in this change.
No action needed; this is a documentation-only commit with no security relevance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is a pure documentation addition to AGENTS.md under a new ‘Review Guidelines’ section. It instructs reviewers to verify that removed function calls were intentionally removed and that any now-unused callees are also removed. No source code, interfaces, or behavior changed.
Changed components
AGENTS.md (project documentation)Inspect captured patch +5 / −0
diff --git a/AGENTS.md b/AGENTS.md
index 42b5f77..dfb1ca6 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -54,6 +54,11 @@ security-sensitive areas.
- In Rust unit tests, if testing a function foo, name the test `test_foo` (or `test_foo_xyz` if it needs qualifiers).
- in Rust unit tests, prefer .as_slice() instead of `&*` for wrapped/zeroized Vec<u8>.
+## Review Guidelines
+
+- when reviewing a removed function call, check that the removed behavior was not required and was not dropped by accident during a refactor.
+- when reviewing a removed function call, check if the callee became unused and should also be removed.
+
## Commit & Pull Request Guidelines
Write commits with a ≤50 character subject, blank line, and explanatory body per `CONTRIBUTING.md`;
reference issues via `refs #1234` or `fixes #1234`. Keep patches atomic—avoid mixing formatting and
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.