build: upload graphical simulator branch builds
What changed, and why it matters
This commit changes the project's automated build workflow so that graphical simulator programs are packaged and uploaded for every successful build, not just for direct pushes to the main branch. It is a build/CI convenience improvement with no apparent security relevance.
No security action required. Treat as a routine CI/build workflow enhancement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies .github/workflows/ci-common.yml. It adds conditional steps to package the graphical simulator as a tar.gz archive for Linux x86_64 and macOS ARM64, verifies the simulator starts with –help before packaging, and uploads the archive as a CI artifact. It also adjusts the existing artifact upload step to skip the old binary upload for simulator-graphical targets. No source code, cryptographic, authentication, or firmware logic is changed.
Changed components
.github/workflows/ci-common.ymlInspect captured patch +30 / −2
### .github/workflows/ci-common.yml
@@ -270,7 +270,7 @@ jobs:
} | xargs -0 -r sha256sum
- name: Upload artifact
- if: github.event_name == 'push' && !cancelled()
+ if: github.event_name == 'push' && matrix.target != 'simulator-graphical' && !cancelled()
uses: actions/upload-artifact@v4
with:
name: ${{matrix.product}}-${{matrix.edition}}-${{matrix.target}}${{ matrix.debug == 'yes' && '-debug' || '' }}-locked-${{ matrix.locked || 'no' }}-development-${{ matrix.development || 'yes' }}-${{github.sha}}.bin
@@ -282,6 +282,20 @@ jobs:
build-bitbox03-cargo/thumbv8m.main-none-eabihf/debug/bitbox03-*
build-bitbox03-cargo/thumbv8m.main-none-eabihf/release/bitbox03-*
+ - name: Package graphical simulator
+ if: matrix.target == 'simulator-graphical'
+ run: |
+ build-build-noasan/bin/simulator-graphical --help
+ tar -czf simulator-graphical-linux-x86_64.tar.gz -C build-build-noasan/bin simulator-graphical
+
+ - name: Upload graphical simulator
+ if: matrix.target == 'simulator-graphical'
+ uses: actions/upload-artifact@v4
+ with:
+ name: simulator-graphical-linux-x86_64-${{ github.sha }}
+ path: simulator-graphical-linux-x86_64.tar.gz
+ if-no-files-found: error
+
# Build simulators for macos aarch64
build-macos:
strategy:
@@ -326,13 +340,27 @@ jobs:
run: sha256sum build*/bin/*
- name: Upload artifact
- if: github.event_name == 'push' && !cancelled()
+ if: github.event_name == 'push' && matrix.target != 'simulator-graphical' && !cancelled()
uses: actions/upload-artifact@v4
with:
name: ${{matrix.target}}-apple-aarch64-darwin-${{github.sha}}.bin
path: |
build*/bin/simulator*
+ - name: Package graphical simulator
+ if: matrix.target == 'simulator-graphical'
+ run: |
+ build-build-noasan/bin/simulator-graphical --help
+ tar -czf simulator-graphical-macos-aarch64.tar.gz -C build-build-noasan/bin simulator-graphical
+
+ - name: Upload graphical simulator
+ if: matrix.target == 'simulator-graphical'
+ uses: actions/upload-artifact@v4
+ with:
+ name: simulator-graphical-macos-aarch64-${{ github.sha }}
+ path: simulator-graphical-macos-aarch64.tar.gz
+ if-no-files-found: error
+
doc:
runs-on: ubuntu-22.04
container: ${{ inputs.container-repo }}:${{ inputs.container-version }}Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.