AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 28 Bitcoin

ethereum: support payment requests for eip1559

Public commit record

What the developer wrote

Authored by Cedric Wiese

45/100 · Thin
ethereum: support payment requests for eip1559
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds support for EIP-1559 Ethereum transactions in the BitBox02's payment-request (swap) feature. It lets users verify and sign Ethereum and ERC-20 token swaps that include a merchant payment request, similar to what already existed for Bitcoin. The change is a feature addition, not a fix for a known vulnerability.

Recommended action

Review the payment_request::validate_eth implementation and the new signing paths to ensure the source-side amount normalization, address derivation checks, and signature verification are correct. Run the new unit tests and perform manual QA on EIP-1559 swap flows for both native ETH and ERC-20 tokens.

Security signals we found

01

New user-facing signing path for EIP-1559 payment requests

02

Payment-request validation now covers both BTC and ETH/ERC-20 source assets

03

Plain ETH swaps require empty transaction data

04

ERC-20 swaps decode transfer(...) recipient and amount for validation

05

Validation failures show an 'Invalid payment request' status and abort signing

06

Refactored common validation logic into validate_common()

Risk score

Why this scored 28/100

Our methodology →
Potential impact 5/30
Exploitability 5/25
Stealth signal 5/15
Affected reach 5/15
Confidence 5/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.