factorysetup: update comment about auto_enter/upside_down
What the developer wrote
Authored by Marko Bencun
factorysetup: update comment about auto_enter/upside_down
The old comment was from a time where jlink was already locked when we
flashed this image, so it was required to be able to get into the
bootloader again. Now this is not the case anymore, but we still need
these two flags to be set properly like this regardless.
What changed, and why it matters
This commit only rewrites comments in the factory setup code to explain why two bootloader flags are set the way they are. No code behavior is changed, so it has no security impact on its own.
No action needed; this is a non-functional comment-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff in src/factorysetup.c replaces an outdated comment about re-entering the bootloader with clearer explanations for setting auto_enter=true and upside_down=false during device manufacturing. The executable code remains identical; only inline documentation changed.
Changed components
src/factorysetup.cInspect captured patch +4 / −2
diff --git a/src/factorysetup.c b/src/factorysetup.c
index 24185c2..1fa1162 100644
--- a/src/factorysetup.c
+++ b/src/factorysetup.c
@@ -582,11 +582,13 @@ int main(void)
common_main();
{
- // Set to re-enter bootloader again, otherwise we are stuck with this
- // firmware forever.
+ // We set auto_enter = true, as new devices are shipped without firmware, and a new device
+ // should start in the bootloader without trying to boot the firmware.
auto_enter_t auto_enter = {
.value = sectrue_u8,
};
+ // We set upside_down = false, so the default bootloader orientation on a new device is such
+ // that it oriented correctly when inserted into a laptop or iPad from the right hand side.
upside_down_t upside_down = {
.value = false,
};
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.