simulator-graphical-bb03: make communication_timeout_reset a no-op
What the developer wrote
Authored by Marko Bencun
simulator-graphical-bb03: make communication_timeout_reset a no-op
What changed, and why it matters
This commit changes a single placeholder function in the graphical simulator for the BitBox03 hardware wallet. The function, which previously would crash the simulator if called, now does nothing. The change only affects test/simulation code, not real device firmware, and there is no indication it fixes a security issue.
No security action required. This is a benign test/simulator-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In test/simulator-graphical-bb03/src/hal/system.rs, the implementation of communication_timeout_reset for the BitBox03System simulator HAL was changed from todo!() (which panics) to a no-op comment. The commit message explains that the simulator has no blocking operations requiring a timeout reset. This is a test-only simulator stub adjustment.
Changed components
test/simulator-graphical-bb03/src/hal/system.rsInspect captured patch +1 / −1
diff --git a/test/simulator-graphical-bb03/src/hal/system.rs b/test/simulator-graphical-bb03/src/hal/system.rs
index eb20c86..708b842 100644
--- a/test/simulator-graphical-bb03/src/hal/system.rs
+++ b/test/simulator-graphical-bb03/src/hal/system.rs
@@ -24,6 +24,6 @@ impl hal::system::System for BitBox03System {
}
fn communication_timeout_reset(&mut self, _value: i16) {
- todo!()
+ // No-op, there are no blocking operations in the simulator that would require timeout reset.
}
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.