AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 27 Bitcoin

Add coin purchase memo support

Public commit record

What the developer wrote

Authored by cedwies

45/100 · Thin
Add coin purchase memo support
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds a new 'coin purchase memo' feature to BitBox02 payment requests. It lets a payment request include details about a separate coin purchase (e.g., '0.25 ETH to address 0x...') and verifies that the listed Ethereum address really belongs to the wallet by deriving it from a provided keypath. The change is mostly a feature addition, but it introduces cross-currency validation logic and a TODO noting that the user-interface confirmation for this new memo type is not yet implemented.

Recommended action

Treat this as a normal feature commit, but review the TODO in user_verify before release to ensure users are explicitly shown CoinPurchaseMemo details before signing. Audit that the new Ethereum keypath validation cannot be bypassed and that the Disabled error path in signtx.rs is handled correctly in production builds.

Security signals we found

01

New payment-request memo type with address ownership verification via keypath derivation

02

TODO left in user_verify indicating UI confirmation for CoinPurchaseMemo is not yet implemented

03

Cross-module dependency introduced: Bitcoin payment-request validation now calls Ethereum address derivation

04

Compile-time feature gating (app-ethereum) for the new validation path

05

Sighash explicitly excludes address_derivation, which is noted as BitBox-specific and not part of SLIP-24

Risk score

Why this scored 27/100

Our methodology →
Potential impact 5/30
Exploitability 4/25
Stealth signal 3/15
Affected reach 6/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.