RB
← All projectsRust Bitcoin

rust-bitcoin

Rust library for Bitcoin data structures, serialization, consensus encoding, and scripts.

BitcoinCryptographic librariesNormal
Repository coverage

2313 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

532security candidates511second-pass queue2206AI analyses
133commits · 30 days
267commits · 60 days
1103commits · 180 days
2019commits · 365 days
Backfill bands
Aug 5 → Feb 6787 seen32 candidatesComplete
Feb 6 → Jun 6878 seen53 candidatesComplete
Jun 6 → Jul 6211 seen15 candidatesComplete
Jul 6 → Aug 5184 seen2 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
510Strong · 80–100
1085Adequate · 60–79
567Thin · 40–59
151Opaque · 0–39
20security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Andrew Poelstra23179157290
Mitchell Bagot649193645068
Tobin C. Harding41566410063
jrakibi944994068
Nick Johnson19121190060
Jamil Lambert, PhD11919116061
satsfy (Renato Britto)381527066
Fmt Bot331431045
Trevor Arjeski111111069
Shing Him Ng31731056
Martin Habovstiak30628068
Ismail Daif22622050
Analysis record

Published AI watches

Last scanned 27 minutes ago

Moderate 62 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6954: units: serialize unsigned amounts as u64

This commit fixes a mismatch in how unsigned Bitcoin amounts were serialized versus deserialized when using certain compact binary formats. Previously, an unsigned amount (like 100 satoshis) was written as a signed number, which caused for…

Data integrity bug: serialized values decode to different numeric values in varint binary formatsRange-check failure: Amount::MAX and large values near the cap fail deserialization after round-tripSerde serialize/deserialize hint mismatch for unsigned amount types
295c9d8aby Andrew Poelstra+66−112 files
No security note in commit
Low 25 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6955: key_expression: preserve master-key invariants in Xpub Arbitrary

This change fixes a bug in test-only code that generates random fake Bitcoin extended public keys (xpubs). Previously, when generating a master xpub (depth 0), the code could pick random values for the parent fingerprint and child number, …

BIP32 master-key invariant violation in generated test dataEncode/decode round-trip failure for generated master xpubsFix aligns Xpub::arbitrary with existing Xpriv::arbitrary behavior
4116ecc6by Andrew Poelstra+35−31 file
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6947: build(deps): bump cargo-bins/cargo-binstall from 1.21.0 to 1.21.1

This commit updates the version of a helper tool (cargo-binstall) used only inside GitHub Actions automation. It is a routine dependency bump by Dependabot and does not change any code that ships to users. There is no indication of a secur…

c1be49cbby Andrew Poelstra+2−22 files
No security note in commit
High 70 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6919: Sanitize serde size hints before allocating

This commit fixes a denial-of-service weakness in how the library deserializes lists of Bitcoin data (witnesses, amounts, fee rates) from untrusted input. Before the fix, a few bytes of attacker-controlled data could claim a list would con…

Untrusted serde size hint fed directly into Vec::with_capacityPotential memory exhaustion / OOM kill from small malicious inputDenial-of-service vector in deserialization paths
55ddbc0cby Andrew Poelstra+88−105 files
Vendor flagged security relevance
Moderate 60 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6945: bitcoin: handle OP_CODESEPARATOR in legacy

This commit fixes how the Rust Bitcoin library calculates old-style (legacy) transaction signatures when the spending script contains a special opcode called OP_CODESEPARATOR. Previously the library did not handle this opcode at all, which…

Protocol correctness fix for legacy sighash serializationOP_CODESEPARATOR handling added to match Bitcoin Core consensus behaviorPreviously omitted test vectors restored, indicating prior non-compliance
5b815281by Andrew Poelstra+600−3093 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6948: build(deps): bump taiki-e/install-action from 2.83.2 to 2.85.4

This is a routine update by Dependabot to the version of a third-party GitHub Action used in the project's automated testing workflows. The change only affects internal continuous integration (CI) scripts, not the actual Bitcoin library co…

d1431904by Andrew Poelstra+2−22 files
No security note in commit
Low 33 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6946: Fix integer overflow in `get_array`

This commit fixes a small but real bug in a Rust helper that reads fixed-size chunks from a data slice. The helper was supposed to safely return 'nothing' when asked to read past the end of the data, but it accidentally added two numbers t…

Integer overflow in bounds-checking helperContract violation: method documented to return None on out-of-bounds access could panic insteadDebug-build panic (denial of service) possible
c6e80843by Andrew Poelstra+2−11 file
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Fix integer overflow in `get_array`

This commit fixes a bug in a Rust helper method called `get_array`, which is meant to safely read a fixed-size chunk from a slice and return nothing if the requested range is out of bounds. The bug was that the code added the caller's offs…

Integer overflow in bounds calculationPotential panic due to violated internal length expectationCaller-controlled arithmetic used for memory access bounds
56fb1287by Martin Habovstiak+2−11 file
Vendor flagged security relevance
High 71 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6915: primitives: Fix `Witness` handling of oversized items

This commit fixes a bug in how the Rust Bitcoin library counts and compares transaction witness data when a witness contains an oversized item. Previously, several functions relied on an iterator that silently skips oversized items, causin…

Inconsistent serialization/iterator behavior for oversized witness itemswtxid collision risk between transactions differing only in oversized witness bytesIncorrect witness equality for oversized single-item stacks
e1ed5884by Andrew Poelstra+106−273 files
Vendor flagged security relevance
Informational 19 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6922: Use `try_fold` instead of `fold` in `Sum` impl

This is a code-quality and performance improvement, not a security fix. It changes how the library adds up lists of Bitcoin amounts so that it stops early once an overflow is detected, rather than continuing to process the rest of the list…

No security-relevant signal in commit message or diffRefactor preserves overflow-checking behavior (short-circuits instead of continuing)New API method `NumOpResult::from_result` is a pure inverse of existing `into_result`
86e4d5daby Andrew Poelstra+60−562 files
No security note in commit
Moderate 52 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6893: units: Reject malformed amount strings

This update fixes a bug in how the library reads Bitcoin amount strings like '1.5 BTC'. Previously, certain malformed inputs such as '.', '._', '1_', '1_.0', and '1._0' were incorrectly accepted and treated as valid amounts (often zero), i…

Input validation bypass in amount parserMalformed strings silently parsed as zero or ordinary amountsUnderscore separator placement not enforced
fcb14622by Andrew Poelstra+88−343 files
Vendor flagged security relevance
Low 48 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6921: units: fix div_by_fee_rate_ceil precision

This commit fixes a rounding bug in how the rust-bitcoin library calculates the minimum transaction weight needed to pay a given fee at a given fee rate. The old code rounded the fee rate up too early, which could produce a weight slightly…

Incorrect fee-weight calculation due to premature integer roundingPotential transaction fee shortfall when using div_by_fee_rate_ceilOverflow protection added for Amount::MAX * 4_000_000 intermediate value
b31212e0by Andrew Poelstra+38−82 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6898: Release tracking PR: `consensus-encoding 1.3.0`

This is a routine release-management commit that bumps the version number of the `bitcoin-consensus-encoding` crate from 1.2.0 to 1.3.0 and updates lock files accordingly. It contains no code changes that fix or introduce a security issue.…

0cfc7908by Andrew Poelstra+37−349 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6909: build(deps): bump actions/labeler from 6.2.0 to 7.0.0

This commit updates a GitHub Actions automation tool (actions/labeler) used to automatically tag pull requests with labels. It is a routine dependency version bump from 6.2.0 to 7.0.0, with no indication of a security fix or vulnerability.…

4ed7c068by Andrew Poelstra+1−11 file
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6910: build(deps): bump actions/checkout from 7.0.0 to 7.0.1

This commit is a routine update to the GitHub Actions checkout tool used by the project's automated workflows. It only changes version numbers in configuration files and does not alter the actual Bitcoin library code that users run. There …

328c4ae9by Andrew Poelstra+37−3717 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6911: build(deps): bump astral-sh/setup-uv from 8.3.2 to 9.0.0

This commit updates a GitHub Actions helper used to install a Python tool called uv, which runs the zizmor security scanner. The change only bumps the pinned version of the helper from 8.3.2 to 9.0.0. The new version's release notes mentio…

No security-relevant signals in commit or upstream release notesDependency bump in CI only, not in library codeNo CVE or advisory referenced
67600795by Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6912: build(deps): bump github/codeql-action/upload-sarif from 4.37.0 to 4.37.3

This is a routine Dependabot update that changes the pinned version of GitHub's official CodeQL upload-sarif action from 4.37.0 to 4.37.3 in a single CI workflow. The action only uploads static analysis results to GitHub; it does not touch…

b51cec63by Andrew Poelstra+1−11 file
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6913: build(deps): bump dtolnay/rust-toolchain from 6c977a6ca4077a0ceb28ffbe03f59d46e9ac8772 to 02cb101ec7c40f2c49e1d9714d64511d8e1b74de

This is a routine update to a GitHub Actions helper used to install Rust during automated testing. It only changes the pinned version of the dtolnay/rust-toolchain action in workflow files. There is no change to the actual rust-bitcoin lib…

90330d15by Andrew Poelstra+8−84 files
No security note in commit
Informational 20 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6906: consensus_encoding, primitives: expose exact encoding size for block and transaction

This commit adds a way to ask, in advance, exactly how many bytes a Bitcoin block or transaction will take when serialized. It is a feature addition for the library's encoding system, not a fix for a vulnerability. There is no indication i…

No security-relevant signals in commit message or diffFeature addition: expose exact encoded sizeNo mention of vulnerability, CVE, bug bounty, or security report
1a365d53by Andrew Poelstra+129−1068 files
No security note in commit
Informational 15 AI analysisMessage 88 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump dtolnay/rust-toolchain

This is a routine update by Dependabot that changes which version of a popular GitHub Action (dtolnay/rust-toolchain) is used to install Rust in automated CI workflows. The commit only updates pinned commit hashes in workflow files; it doe…

a31e0b0eby dependabot[bot]+8−84 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityAdd missing full stop in rustdocsby Jamil Lambert, PhD · 1a1061ec · Mar 11, 2026 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · Jamil Lambert, PhD

Add missing full stop in rustdocs

All of the modules except internal macros use a full stop at the end of
the title.

Add a full stop to make them all consistent.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a trivial documentation punctuation fix. It adds a missing full stop to a rustdoc comment in an internal macros file. There is no code change and no security relevance.

Lower-priorityMake the crate level title render as a headingby Jamil Lambert, PhD · 5ea703b0 · Mar 11, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Jamil Lambert, PhD

Make the crate level title render as a heading

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit changes a single line of documentation in the source code, adding a '#' character so that the crate's title displays as a proper heading in generated documentation. It has no effect on program behavior, security, or functionality.

AI review queuedAdd missing license commentby Jamil Lambert, PhD · 3dff2d7c · Mar 11, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Jamil Lambert, PhD

Add missing license comment

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only adds a missing software license comment (CC0-1.0) to a test file. It does not change any code behavior, fix any bug, or alter any security-relevant logic.

Lower-priorityWrap rustdocs at a consistent column width of 100by Jamil Lambert, PhD · fd1eba4c · Mar 11, 2026 · 4 filesMessage 60 · AdequateInformational 15Details
Commit message · Jamil Lambert, PhD

Wrap rustdocs at a consistent column width of 100

Run an AI generated python script to reflow all rustdoc paragrapy text
to wrap at column 100.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit only reformats documentation comments (rustdocs) so they wrap at 100 characters per line. It changes line breaks and spacing in comments only, with no changes to actual code logic, APIs, or behavior. There is no security relevance.

AI review queuedAdd missing doc inlineby Jamil Lambert, PhD · 1df9d49e · Mar 11, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jamil Lambert, PhD

Add missing doc inline

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit adds a missing documentation attribute to a public type alias in the rust-bitcoin hashes library. It only affects how the SHA3-256 hash type appears in generated API documentation and has no security or runtime effect.

AI review queuedconsensus_encoding: Introduce decode_from_slice_unboundedby Mitchell Bagot · 7ee482c1 · Mar 11, 2026 · 7 filesMessage 63 · AdequateLow 34Details
Commit message · Mitchell Bagot

consensus_encoding: Introduce decode_from_slice_unbounded

The old consensus code deserialize function returned an error when
decoding failed to consume all bytes in the input slice. The new
nearest-equivalent function, decode_from_slice, does not error on
unconsumed bytes.

Introduce decode_from_slice_unbounded which errors on unconsumed bytes.
Adjust decode_from_slice to error on unconsumed bytes.
Introduce DecodeError type to specify decoder vs unconsumed bytes
errors for decode_from_slice.

63/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Provides detailed explanatory context
Why it was queued
parser or protocol pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 34/100

This commit changes how a Bitcoin library decodes byte slices. Previously, a function called decode_from_slice silently accepted extra bytes after a valid object. Now it rejects leftover bytes, and a new function decode_from_slice_unbounded is provided for cases where callers intentionally want to read only part of the input. This is a defensive correctness fix that prevents accidental acceptance of malformed or padded data, but it also changes the public API behavior and error types, which could break downstream code.

AI review queuedp2p: add serde impls for FilterHash and FilterHeaderby busayo-OD · 5e968d57 · Mar 10, 2026 · 5 filesMessage 65 · AdequateInformational 19Details
Commit message · busayo-OD

p2p: add serde impls for FilterHash and FilterHeader

p2p: update lock files for serde dependency

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 19/100

This commit adds optional serialization/deserialization support (via the serde library) for two data types, FilterHash and FilterHeader, used in Bitcoin peer-to-peer compact block filters. It is a routine feature addition, not a security fix or vulnerability patch. There is no indication of a security issue in the code changes themselves.

AI review queuedUpdate api filesby Jamil Lambert, PhD · 2e8bd11d · Mar 10, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jamil Lambert, PhD

Update api files

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates a generated text file that lists the public API surface of the crate. It adds entries for new serde helper functions that support vectors of amounts and fee rates. There is no source code change, no bug fix, and no security relevance visible in the diff.

AI review queuedAdd serde support for Vec<(Signed)Amount>by Jamil Lambert, PhD · c104a521 · Mar 10, 2026 · 2 filesMessage 78 · AdequateInformational 16Details
Commit message · Jamil Lambert, PhD

Add serde support for Vec<(Signed)Amount>

Expand the serde module to also support Vec<Amount> and
Vec<SignedAmount>.

Add tests of the Vec serialization and
deserialization.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 16/100

This commit adds new Rust code that lets programs serialize and deserialize lists (vectors) of Bitcoin amounts when using the serde data-format library. It is a feature addition with matching tests. There is no indication it fixes a security bug or introduces a vulnerability.

AI review queuedAdd serde support for Vec<FeeRate>by Jamil Lambert, PhD · 1afe0abe · Mar 10, 2026 · 2 filesMessage 78 · AdequateInformational 15Details
Commit message · Jamil Lambert, PhD

Add serde support for Vec<FeeRate>

Serde support for Vec<FeeRate> is needed in corepc to update the bitcoin
dependence to 0.33.0.

Expand the serde support for FeeRate to also support Vec<FeeRate>.

Add tests of Vec<FeeRate> serialization and deserialization.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit adds new serialization/deserialization helpers so that a list of Bitcoin fee-rate values can be converted to and from JSON (or other serde formats). It is a straightforward feature addition with matching unit tests and contains no security fix or vulnerability.

Security candidateMove impl blocks to below struct definitionby Jamil Lambert, PhD · 690da807 · Mar 10, 2026 · 1 fileMessage 80 · StrongInformational 15Details
Commit message · Jamil Lambert, PhD

Move impl blocks to below struct definition

Some of the Hmac impl blocks were seperate from the others.

Move them so that they are all together directly below the struct
definition.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit only moves existing code around in the same file. It takes several implementation blocks for the Hmac type and places them directly below the Hmac struct definition instead of further down after another struct. No code behavior, logic, or public interface was changed.

Security candidateMove hash implementations to the topby Jamil Lambert, PhD · d6a6e0ef · Mar 10, 2026 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · Jamil Lambert, PhD

Move hash implementations to the top

To make all the modules consistent move the hash impl to the top.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit simply moves existing code around in two files. It relocates the implementation blocks for SHA256 and SipHash24 hash types to appear earlier in their respective files, right after the hash type is declared. No code behavior was changed, no bugs were fixed, and no security issues were introduced.

AI review queuedconsensus_encoding: whitelist timeout mutantsby Nick Johnson · 8ab8c465 · Mar 10, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Nick Johnson

consensus_encoding: whitelist timeout mutants

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates a test-tool configuration file. It tells an automated mutation-testing tool (cargo-mutants) to skip testing certain code patterns because they would cause the test suite to loop forever. It does not change any actual library code, fix a bug, or alter how the software behaves in production.

Lower-priorityunits: Replace manual CompactTarget fmt traits with macroby Mitchell Bagot · 418d489f · Mar 10, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Mitchell Bagot

units: Replace manual CompactTarget fmt traits with macro

Now that CompactTarget is in units instead of primitives, we can reuse
the impl_fmt_traits_for_u32_wrapper macro to provide the format traits
for it instead of manual implementations.

Replace Upper/LowerHex, Binary and Octal impls on CompactTarget with
call to impl_fmt_traits_for_u32_wrapper macro.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a routine code cleanup. It replaces four hand-written formatting rules for the CompactTarget type with a single existing macro that does the same thing. There is no functional change and no security relevance.

Lower-priorityunits: Add #[inline] to fmt functions in macroby Mitchell Bagot · ecf07541 · Mar 10, 2026 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · Mitchell Bagot

units: Add #[inline] to fmt functions in macro

In units, we have a macro impl_fmt_traits_for_u32_wrapper to implement
formatting traits on an integer type. Unlike some existing format
trait impls, this doesn't use the #[inline] attribute on the fmt
functions.

Add #[inline] to all fmt functions in all traits in
impl_fmt_traits_for_u32_wrapper macro.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit adds compiler hints (#[inline]) to formatting functions for some numeric wrapper types. It is a routine performance/cleanup change and does not alter program behavior or fix any security issue.

Lower-priorityprimitives: Update API filesby Mitchell Bagot · 1f9d31ba · Mar 10, 2026 · 3 filesMessage 58 · ThinInformational 15Details
Commit message · Mitchell Bagot

primitives: Update API files

Moving the exports from the previous patch yields many changes to the
api files. To keep the review process clean, split the api updates.

Update the primitives api files for the previous patch's changes.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates generated API snapshot text files so they reflect that a type named TxMerkleNodeDecoder was moved from the transaction module to the merkle_tree module. No actual source code, logic, or behavior changed. It is a bookkeeping change to keep automated API checks in sync with a previous code reorganization.

AI review queuedprimitives: Move TxMerkleNodeDecoder/Error to merkle_treeby Mitchell Bagot · 469a9cc7 · Mar 10, 2026 · 4 filesMessage 73 · AdequateInformational 20Details
Commit message · Mitchell Bagot

primitives: Move TxMerkleNodeDecoder/Error to merkle_tree

In primitives the TxMerkleNode and its encoder are exported from the
merkle_tree module. The decoder is exported from the transaction
module.

Move the TxMerkleNodeDecoder and TxMerkleNodeDecoderError re-exports
to the merkle_tree module from the transaction module.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit is a straightforward code organization change. It moves where two helper types (TxMerkleNodeDecoder and TxMerkleNodeDecoderError) are publicly exported so they sit alongside related types in the merkle_tree module instead of the transaction module. There is no change to how data is decoded, no bug fix, and no security impact.

Lower-priorityprimitives: Remove FromHex usage in serde codeby Tobin C. Harding · af4cb011 · Mar 9, 2026 · 1 fileMessage 68 · AdequateInformational 19Details
Commit message · Tobin C. Harding

primitives: Remove FromHex usage in serde code

In the stable `hex` release we made the decision to totally hide error
internals. This breaks our usage of the lib, how ironic.

We have a few choices one of which is to just use
`de::Error::custom()` to pass the received error to `serde` without
digging into it to return more precise information.

It was noted during review that `serde` errors are notoriously opaque.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This commit swaps out a custom hex-decoding helper for a simpler one in the code that turns serialized data back into Bitcoin witness structures. The change is driven by an upstream library hiding its internal error details, not by a known security flaw. The main practical effect is that error messages become less specific when someone feeds in bad hex data. There is no direct evidence this introduces a vulnerability, but it slightly weakens defensive error reporting.

Lower-priorityprimitives: Remove FromHex from test codeby Tobin C. Harding · 30ee49d6 · Mar 9, 2026 · 1 fileMessage 78 · AdequateInformational 15Details
Commit message · Tobin C. Harding

primitives: Remove FromHex from test code

There are some remaining usages of the unstable `FromHex` trait, lets
remove them in favour of the stable decoding functions.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only changes internal test code in the rust-bitcoin library. It replaces an unstable developer-only helper trait with a stable equivalent for converting hexadecimal strings into byte arrays. There is no change to production code, no user-facing behavior change, and no security fix.

AI review queuedprimitives: Use ArrayRefEncoderby Tobin C. Harding · 736adeb9 · Mar 9, 2026 · 2 filesMessage 58 · ThinInformational 15Details
Commit message · Tobin C. Harding

primitives: Use ArrayRefEncoder

No need to copy the hash type when encoding the `TxMerkleNode` or
the `WitnessMerkleNode`.

Use `ArrayRefEncoder` as we do for the other hash types. Props to
claude for noticing this while chugging through some other changes
for me. I did the changes manually though.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a small internal code cleanup in the rust-bitcoin library. It changes how two hash-like types (transaction merkle node and witness merkle node) are encoded so that they reference existing data instead of making a copy. There is no security issue here—it's a performance/maintainability improvement that makes the code consistent with how other hash types are already encoded.

AI review queuedapi: update consensus_encoding traitsby Nick Johnson · 798195df · Mar 9, 2026 · 3 filesMessage 35 · OpaqueInformational 15Details
Commit message · Nick Johnson

api: update consensus_encoding traits

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates generated API text files that list which Rust traits (like Clone and Debug) are implemented by various types in the bitcoin_consensus_encoding crate. No actual source code, logic, or behavior changed. It is a documentation/maintenance update for the public API snapshot, not a security fix.

AI review queuedconsensus_encoding: add common trait implementationsby Nick Johnson · a7519267 · Mar 9, 2026 · 4 filesMessage 85 · StrongInformational 19Details
Commit message · Nick Johnson

consensus_encoding: add common trait implementations

Following API guidelines C-COMMON-TRAITS, adding Debug and Clone
implementations where we can to encoders and decoders.

A lot of the common traits, including PartialEq, Hash, Ord, Display,
Default, and Copy don't have semantic value for the stateful encoders
and decoders. For example, comparing two encoders with PartialEq would
be comparing a buffer and a cursor, not a logical value.

The composite decoders do not implement Clone because it would require a
Clone bound on the intermediate A::Output types, which seems too
constraining.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit adds standard Rust helper traits (Debug for printing, Clone for copying) to the library's byte encoders and decoders. It also adds a few new unit tests. There is no security fix or vulnerability here; it is a routine API-quality improvement.

Security candidatekeys: Remove rng argument from Keypair::generateby Mitchell Bagot · 37c7a197 · Mar 9, 2026 · 1 fileMessage 73 · AdequateInformational 19Details
Commit message · Mitchell Bagot

keys: Remove rng argument from Keypair::generate

The Keypair::generate function follows the signature of the underlying
secp library, in that it takes a rand generator. The existing
PrivateKey generate instead constructs the rand generator internally,
hiding the extra complexity from the user to provide a cleaner
interface.

Remove rng argument from Keypair::generate and adjust call sites
accordingly.

73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomnesssigning boundarycryptography-sensitive path
AI analysis · Informational 19/100

This is a routine API cleanup, not a security fix. The change removes the requirement for callers to supply their own random number generator when creating a new keypair. Instead, the function now creates the generator internally, matching how the related PrivateKey API already works. There is no vulnerability here; it is a convenience and consistency change.

Lower-priorityUpdate the API text filesby Tobin C. Harding · 648e6cda · Mar 9, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Tobin C. Harding

Update the API text files

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates generated text files that list the public API surface of the Rust Bitcoin library. No actual source code, logic, or behavior changed. The files record that the `Block` type now carries a validation-state marker (`Unchecked`/`Checked`) and that some error types were added, but these are documentation artifacts, not a security patch.

Lower-priorityLoosen trait bounds on HexPrimitive trait implsby Tobin C. Harding · 86ff577a · Mar 9, 2026 · 1 fileMessage 80 · StrongInformational 15Details
Commit message · Tobin C. Harding

Loosen trait bounds on HexPrimitive trait impls

Currently the `HexPrimitive` has trait bounds on the struct `Decodable
+ Encodable` and these bounds are also on the `fmt` trait impls. It is
not necessary to be able to decode an object in order to `fmt` it.

Loosen the trait bounds so that we only need `Encodable` for `fmt`'ing
and `Decodable` for parsing.

(This is needed so that the `Block<Checked>` type can be `fmt`'ed when
it intentionally does not implement decoding.)

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This commit is a routine code cleanup. It relaxes unnecessary requirements on an internal helper type so that formatting a value as hexadecimal no longer requires the value to also be decodable. There is no security issue here.