CommitWatch RSS
BS
← All projectsBlockstream

Blockstream Jade

Firmware for Jade and Jade Plus Bitcoin hardware wallets.

BitcoinHardware walletsElevated watch
Source repository ↗
Repository coverage

414 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

93security candidates58second-pass queue75AI analyses
10commits · 30 days
67commits · 60 days
198commits · 180 days
414commits · 365 days
Backfill bands
Aug 5 → Feb 6216 seen38 candidatesComplete
Feb 6 → Jun 6131 seen9 candidatesComplete
Jun 6 → Jul 657 seen10 candidatesComplete
Jul 6 → Aug 510 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
32Strong · 80–100
147Adequate · 60–79
203Thin · 40–59
32Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths2755242157
Mike Tolkachev311110155
Daniel Newton651510055
Mihailo Milenkovic877057
Jamie C. Driver522053
Gustavo Cateim711079
Austin-Fulbright410060
roderico111045
quantpoet111072
tokyovyse110063
cmiguelrn111045
odudex200071
Analysis record

Published AI watches

Last scanned 21 minutes ago

Low 27 AI analysisMessage 86 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

input: release touch handles before deleting the i2c bus

This commit fixes a bug where the touchscreen driver failed to clean up internal handles when shutting down. On newer ESP-IDF firmware, this cleanup failure caused the device to panic and freeze during boot and when using the camera or QR …

Device freeze/DoS-like symptom on affected hardwareMemory leak fixedNo input validation, authentication, or cryptographic weakness visible
36776fecby Gustavo Cateim+3−01 file
No security note in commit
Open full analysis →Source commit ↗
Low 42 AI analysisMessage 95 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

Liquid (taproot): add sign_liquid_tx genesis blockhash support

This commit changes how Blockstream Jade handles the 'genesis blockhash' when signing Liquid transactions. Previously, the device only accepted the network's built-in genesis hash. Now it lets users provide a custom genesis hash for test n…

Adds input validation for caller-supplied genesis blockhashPrevents mainnet genesis hash from being used on Liquid test networksRestricts genesis_hash parameter to Liquid networks only
888eff30by Jon Griffiths+82−264 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: rename get_boolean to get_bool

This commit is a simple rename of two internal helper functions from `rpc_get_boolean`/`rpc_get_boolean_or` to `rpc_get_bool`/`rpc_get_bool_or`, updating all call sites accordingly. There is no change to what the code does, no bug fix, and…

f6e946acby Jon Griffiths+24−2518 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: refactor app code to use getters with default values

This commit is a straightforward code cleanup that replaces verbose 'read this optional value, or leave the default' patterns with shorter helper functions that do the same thing. There is no change in behavior and no security issue visibl…

b6a07147by Mike Tolkachev+22−348 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

Fix M5StickC Plus 2 PIN navigation

This commit fixes a user-interface navigation quirk on the M5StickC Plus 2 hardware for Blockstream Jade. When entering a PIN, the up/down button directions were not inverted to match the rest of the device's menus, making number entry con…

9de1409eby roderico+3−21 file
No security note in commit
Open full analysis →Source commit ↗
Low 36 AI analysisMessage 74 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

build: annotate functions returning error codes to ensure they are checked

This commit is a preventive build-hardening change. It adds compiler annotations (WARN_UNUSED_RESULT) to many functions that return success/failure codes, so the compiler will warn if a caller ignores the result. The goal is to catch futur…

Compiler annotation added to enforce checking of error-returning functionsNo specific vulnerability fixed in the diffNo functional code changes or call-site fixes included
909a89aaby Mike Tolkachev+215−15225 files
No security note in commit
Open full analysis →Source commit ↗
Low 42 AI analysisMessage 28 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

psbt: fix path size

This commit fixes a small but meaningful bug in how Jade, a hardware wallet, reads key paths from Bitcoin PSBT data. The code was passing the byte size of a buffer when it should have passed the number of 32-bit entries. Depending on how t…

Buffer-size semantic mismatch in security-critical PSBT parsingUse of sizeof() on uint32_t array where element count is expectedCode path involved in 2of3 multisig recovery key identification
9e0c3747by Mike Tolkachev+2−21 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 59 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_psbt: add early reject on wrong genesis blockhash

This commit fixes a bug in the Blockstream Jade hardware wallet's PSBT (Partially Signed Bitcoin Transaction) signing code. Previously, when the transaction's genesis block hash did not match the expected network, the code set an error mes…

Missing return in error path allows execution to continue after validation failureCross-network genesis hash mismatch not enforced as a hard failurePSBT signing logic accepts mismatched network parameters
56e130b0by Mike Tolkachev+1−01 file
No security note in commit
Open full analysis →Source commit ↗
Low 42 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

main: fix error handling during PIN change

This commit fixes a bug in the PIN-change flow on Blockstream Jade hardware wallets. Previously, if re-encrypting the wallet keys with a new PIN failed, or if the user abandoned the PIN change, the code did not jump to cleanup as intended.…

Missing error-path control flow in cryptographic key handlingPotential use of stale or partially initialized key material after PIN-change failureCleanup bypass in sensitive authentication code path
64c30823by Mike Tolkachev+2−01 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 59 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

attestation: harden error handling of challenge signing

This commit fixes a bug in the Blockstream Jade hardware wallet's attestation signing process. Previously, if signing the attestation challenge failed, the device would send an error message but then continue running the rest of the functi…

Missing return after error path allows fall-through to success-path replyUninitialized output.ext_signature_len could leak stack data or cause undefined behaviorAttestation signing failure could result in sending an invalid attestation reply
ecc5871bby Mike Tolkachev+2−01 file
No security note in commit
Open full analysis →Source commit ↗
Low 39 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

attestation: fix missing cleanup on failed efuse write

This commit fixes a small but real bug in the device attestation setup code for Blockstream Jade, a hardware crypto wallet. When a one-time programmable security fuse failed to burn, the code used to exit immediately without releasing memo…

Missing cleanup on error path in security-critical initializationResource leak on failed efuse writePotential inconsistent attestation state after partial initialization
d37d88b7by Mike Tolkachev+1−11 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 59 AI analysisMessage 77 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

wallet: fix unhandled wrong asset in wallet summaries

This commit fixes a bug in the Blockstream Jade hardware wallet where a function that tracks assets during transaction signing could fail silently. Previously, if an unexpected or wrong asset was encountered while building a summary of tra…

Unchecked return value from asset_summary_update() in signing pathPotential bypass of asset/balance validation during transaction signingWrong or unknown asset could be silently dropped from wallet summaries
b33cf02bby Mike Tolkachev+18−53 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 59 AI analysisMessage 85 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign: update output logic, rename and document output flags for clarity

This commit reworks how a Blockstream Jade hardware wallet labels transaction outputs. The key change is that the 'change' flag is now only set when the output is also confirmed as belonging to the wallet ('is ours'). Previously, downstrea…

Change output flag now gated by wallet-ownership flagUI hides change outputs based on single bit with runtime assertionGreen 2of3 outputs no longer marked as change because not marked as wallet-owned
cf79a3aaby Mike Tolkachev+32−245 files
Vendor flagged security relevance
Open full analysis →Source commit ↗
Moderate 57 AI analysisMessage 58 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

esp-idf: update to v5.5.4, take multisig bootloader component from https://github.com/Blockstream/esp-idf/tree/securebootv2_multisig_v5.5.4

This is a large update that pulls in Espressif's ESP-IDF v5.5.4 bootloader code, plus Blockstream's own multi-signature secure-boot patches. Most of the visible changes are routine: support for newer ESP32 chips, larger flash sizes, and a …

Anti-fault-injection assertion (ESP_FAULT_ASSERT) added around TEE flash address validationTEE flash write/erase now rejects operations targeting the active TEE partition rangeSecure Boot V2 extended to support ECDSA-P384 / SHA-384 digests
d931d543by Daniel Newton+3879−1437104 files
No security note in commit
Open full analysis →Source commit ↗
High 72 AI analysisMessage 85 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_tx: suppress validation/change attribution for green 2of3 outputs

This update fixes a security gap in how Blockstream Jade signs Bitcoin transactions for a specific wallet type called Green 2of3. Previously, the device trusted the connected app to supply a recovery public key and might silently treat an …

Host-supplied recovery_xpub was trusted for change attributionChange output could be misattributed without user confirmationFix suppresses automatic validation for Green 2of3 outputs
0243f239by Mike Tolkachev+17−11 file
Vendor flagged security relevance
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

ui: tidy up message/error activities

This commit is a straightforward code cleanup. It replaces a verbose way of showing on-screen messages and errors with simpler helper functions, and fixes a spelling mistake ('re-encypt' to 're-encrypt'). There is no change to security log…

No security-relevant logic changesRefactoring only: API simplification for UI message displaySpelling correction in user-facing error string
1914ace0by Daniel Newton+162−24625 files
No security note in commit
Open full analysis →Source commit ↗
Low 25 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

wire: reduce stack usage sending replies

This commit changes how message context is passed between functions in the Blockstream Jade hardware wallet firmware. Instead of copying the entire message context structure on the stack, functions now receive a pointer to it. The stated g…

Stack usage reduction in embedded firmwarePointer passing instead of structure copyingNo direct vulnerability described in commit message
c41f5fddby Jon Griffiths+65−6429 files
No security note in commit
Open full analysis →Source commit ↗
Informational 24 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: add show_bip85_bip39_entropy RPC command

This commit adds a new device command that lets a connected computer or phone ask a Blockstream Jade hardware wallet to display an encrypted BIP85 seed-entropy backup as a QR code. The change also tightens validation of the BIP32 index in …

New RPC exposes encrypted BIP85 entropy via on-device QR displayBIP32 index bounds checks added in multiple RPC parameter parsersSensitive stack buffers now marked with SENSITIVE_PUSH/POP in QR reply path
3392661cby Daniel Newton+115−277 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 62 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

docs: add show_bip85_bip39_entropy RPC documentation

This commit only adds documentation for an existing RPC command called show_bip85_bip39_entropy. It does not change any code, so it cannot introduce or fix a security vulnerability by itself.

2e829638by Daniel Newton+37−01 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 57 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

psbt: always confirm green outputs when recovery signing

This commit changes the logic in Blockstream Jade's PSBT signing flow so that, when the hardware wallet is acting as a 'recovery' key for a Green 2-of-3 wallet, it always asks the user to confirm outputs that belong to Green, rather than s…

Logic inversion in authorization/confirmation pathRecovery-key signing path previously trusted Green-classified outputs without user confirmationComment explicitly frames change around inability to verify output ownership in recovery path
a963f628by Jon Griffiths+2−21 file
No security note in commit
Open full analysis →Source commit ↗
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedlibjade: fix displayed LD_LIBRARY_PATHby Jon Griffiths · 7ec259fa · Mar 4, 2026 · 1 fileMessage 35 · OpaqueTriage 0Details
Commit message · Jon Griffiths

libjade: fix displayed LD_LIBRARY_PATH

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queueddocker: update jade_builderby Jon Griffiths · 1ca0a0a4 · Feb 26, 2026 · 3 filesMessage 35 · OpaqueTriage 0Details
Commit message · Jon Griffiths

docker: update jade_builder

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · 370b93d7 · Feb 20, 2026 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI review queuedbuild: migrate from verde to jade_builderby Jon Griffiths · c758f6dc · Feb 20, 2026 · 23 filesMessage 57 · ThinTriage 0Details
Commit message · Jon Griffiths

build: migrate from verde to jade_builder

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · 61e14f44 · Feb 17, 2026 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI review queuedbuild: update release script directoriesby Jon Griffiths · a9d475b9 · Feb 6, 2026 · 3 filesMessage 57 · ThinTriage 12Details
Commit message · Jon Griffiths

build: update release script directories

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · d70930c5 · Feb 5, 2026 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI review queuedutils: add util.c and functions is_potential_green_*_path()by Mihailo Milenkovic · e42b5c26 · Feb 2, 2026 · 4 filesMessage 65 · AdequateTriage 12Details
Commit message · Mihailo Milenkovic

utils: add util.c and functions is_potential_green_*_path()

Co-authored-by: Jon Griffiths <jon_p_griffiths@yahoo.com>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedconsistency: fix comment typoby Jon Griffiths · ea4222a5 · Feb 2, 2026 · 1 fileMessage 35 · OpaqueTriage 0Details
Commit message · Jon Griffiths

consistency: fix comment typo

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedbuild: standardize v2 scripts to use HWDIRS as per v1by Jon Griffiths · 810adaf2 · Dec 18, 2025 · 3 filesMessage 62 · AdequateTriage 12Details
Commit message · Jon Griffiths

build: standardize v2 scripts to use HWDIRS as per v1

No functional changes.

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedconfig: add a comment description to the top of sdkconfig filesby Daniel Newton · 11278425 · Dec 17, 2025 · 24 filesMessage 65 · AdequateTriage 0Details
Commit message · Daniel Newton

config: add a comment description to the top of sdkconfig files

This makes it easier to see which source config file was used when
sdkconfig.defaults was generated.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
second-pass: unusually broad change
AI review queuedgui: add missing headerby Jon Griffiths · 72140599 · Dec 17, 2025 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Jon Griffiths

gui: add missing header

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedconsistency: fix spellingby Jon Griffiths · 4239cb6c · Dec 16, 2025 · 8 filesMessage 35 · OpaqueTriage 0Details
Commit message · Jon Griffiths

consistency: fix spelling

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedquirc: fix compiler warningby Jon Griffiths · ea03ce7d · Dec 3, 2025 · 1 fileMessage 35 · OpaqueTriage 7Details
Commit message · Jon Griffiths

quirc: fix compiler warning

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · fb264239 · Nov 18, 2025 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · 6ad13bff · Nov 12, 2025 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI review queuedusb: simplify handle_ota_reply logicby Jon Griffiths · 1e51b96c · Oct 23, 2025 · 1 fileMessage 35 · OpaqueTriage 0Details
Commit message · Jon Griffiths

usb: simplify handle_ota_reply logic

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedtext fixesby Daniel Newton · 1f9b4b86 · Oct 22, 2025 · 2 filesMessage 0 · OpaqueTriage 0Details
Commit message · Daniel Newton

text fixes

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedgui: include semphr.hby Jon Griffiths · 6de067ff · Oct 9, 2025 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Jon Griffiths

gui: include semphr.h

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedbuild: initial re-work of the ci pipelineby Daniel Newton · 3025ce83 · Sep 23, 2025 · 39 filesMessage 100 · StrongTriage 0Details
Commit message · Daniel Newton

build: initial re-work of the ci pipeline

Split up and rename the various build stages to reflect what they do and
disambiguate e.g. building from flashing/testing. Use consistent naming
for jobs/config then leverage it to reduce boilerplate repetition.

Generate the CI build config from the developer build config, then remove
the developer build-only CI step.

Update the v2.0 developer build config to use JTAG so flashing between
it and CI builds doesn't require physically switching to JTAG mode.

Collate the build artifacts into a single download for release, pre-sign
the dev images for release automatically. Ensure sequential access to devices
using flock to prevent flaky failures.

Remove the CI use of ttgo as a substitute v2.0 device.

Co-authored-by: Jon Griffiths <jon_p_griffiths@yahoo.com>

100/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
second-pass: unusually broad change
AI review queuedconsistency: correct comment typosby Jon Griffiths · b0fc7a4c · Sep 9, 2025 · 1 fileMessage 35 · OpaqueTriage 0Details
Commit message · Jon Griffiths

consistency: correct comment typos

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedv2jadesign: allow giving the device serial port to sign withby Jon Griffiths · 882311d8 · Sep 4, 2025 · 1 fileMessage 50 · ThinTriage 12Details
Commit message · Jon Griffiths

v2jadesign: allow giving the device serial port to sign with

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedjadepy: fix logging nitby Jon Griffiths · fac46b7d · Sep 4, 2025 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Jon Griffiths

jadepy: fix logging nit

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedsign_tx: return the error message when additional_info parsing failsby Jon Griffiths · 3a8f6095 · Sep 4, 2025 · 4 filesMessage 50 · ThinTriage 12Details
Commit message · Jon Griffiths

sign_tx: return the error message when additional_info parsing fails

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedsign_tx: Strengthen liquid commitment checks against the tx being signedby Jon Griffiths · a454d1f4 · Sep 4, 2025 · 6 filesMessage 83 · StrongTriage 20Details
Commit message · Jon Griffiths

sign_tx: Strengthen liquid commitment checks against the tx being signed

This change ensures that the transaction and any commitment values
match, if an asset/value commitment pair are given.

Commitments given as part of tx input data must have these fields, while
they are optional (and should be discouraged) for tx outputs.

We move the validation checking which was spread over several unrelated
areas into the function fetching the commitment data. This ensures that
when fetching it, it is either fully validated from that point on or an
error is returned.

Following this we remove the commitment fields from the commitment_t struct
since they are now redundant for the remainder of sign_tx processing.

From experience debugging tests where the commitments mismatched, the
old error messages were not helpful. Update these to include 'trusted
commitment' in all messages to make it clearer when a mismatch is
detected.

Note This commit is deliberately minimal to make the core logic changes
easier to review.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path