BS
← All projectsBlockstream

Blockstream Jade

Firmware for Jade and Jade Plus Bitcoin hardware wallets.

BitcoinHardware walletsElevated watch
Repository coverage

557 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

120security candidates80second-pass queue462AI analyses
0commits · 30 days
47commits · 60 days
209commits · 180 days
423commits · 365 days
Backfill bands
Aug 5 → Feb 6216 seen38 candidatesComplete
Feb 6 → Jun 6131 seen9 candidatesComplete
Jun 6 → Jul 657 seen10 candidatesComplete
Jul 6 → Aug 510 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
37Strong · 80–100
204Adequate · 60–79
275Thin · 40–59
41Opaque · 0–39
5security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths32663289157
Mike Tolkachev541744153
Daniel Newton902078055
Mihailo Milenkovic878057
roderico633074
Valerio Vaccaro2226056
Jamie C. Driver525053
Gustavo Cateim917078
Austin-Fulbright414060
kkdao211068
quantpoet111072
cmiguelrn111045
Analysis record

Published AI watches

Last scanned 1 minute ago

Moderate 57 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: whitelist reply message function calls

This commit adds a whitelist of approved functions that can be used when sending reply messages from the Jade hardware wallet to a connected computer or phone. Previously, any function could be passed in, which could allow a bug or malicio…

Function-pointer whitelist added to reply pathMultiple static reply helpers made global to enable whitelist comparisonAssertion tightened to validate callback before use
a59d14c2by Jon Griffiths+53−1513 files
No security note in commit
Low 42 AI analysisMessage 30 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

temporary_stack: whitelist temporary task function calls

This commit adds a whitelist to a special helper that lets certain functions run with extra memory stack space. Previously, any function could be passed to this helper. Now only a small list of approved functions is allowed, except during …

Addition of function-pointer whitelistRemoval of static linkage on internal functions to enable whitelist comparisonConditional bypass of whitelist only for debug/selfcheck builds
6a0fea51by Jon Griffiths+26−54 files
No security note in commit
Informational 15 AI analysisMessage 43 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

consistency: fix typos

This commit is a large typo-fixing cleanup across 40 files. Almost every change corrects spelling mistakes in code comments, variable names, or user-facing text strings. There is no change to program logic, security behavior, or cryptograp…

251f7713by Jon Griffiths+96−9640 files
No security note in commit
Informational 15 AI analysisMessage 47 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

docs: document get_bip85_bip39_entropy

This commit only updates documentation and removes a single comment line. It documents an existing feature that lets a user request encrypted BIP85-based BIP39 entropy from the Jade hardware wallet after on-device confirmation. There is no…

05a578adby Jon Griffiths+52−12 files
No security note in commit
Low 28 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

bip85: expose get_bip85_bip39_entropy over rpc in addition to qr

This commit moves a feature that derives BIP85 BIP39 entropy from being available only in debug builds to being available over the normal RPC interface. BIP85 lets a hardware wallet derive child seed phrases from a master seed. Making this…

Feature moved from debug-only to production RPC surfaceNo accompanying access-control or input-sanitization changes visible in diffBIP85 entropy derivation is a sensitive cryptographic operation
c6c5e860by Jon Griffiths+3−41 file
No security note in commit
Informational 19 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

versioninfo: add JADE_INTERFACE field to show which connection source holds the unlocked wallet

This commit adds a new read-only field, JADE_INTERFACE, to the device's version information reply. It simply tells a connected computer which communication path (USB, Bluetooth, QR mode, etc.) currently has control of the unlocked wallet. …

No authentication or authorization logic changedNo cryptographic or key-management code changedNo input parsing or memory-unsafe code added
2fe9df0bby Daniel Newton+66−56 files
No security note in commit
Low 44 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_tx/sign_psbt: extra check for BTC inputs

This commit adds overflow protection when adding up the total value of Bitcoin transaction inputs in Blockstream Jade's signing code. Previously, the firmware used a plain addition that could silently wrap around if a specially crafted tra…

Integer overflow hardening in financial-amount accumulationDefensive checked_add_uint64() introduced where plain addition existedTransaction signing path now rejects overflowed input totals
41d7e8b4by Daniel Newton+15−32 files
No security note in commit
Informational 19 AI analysisMessage 62 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

build: move NVS cache objects that can pin the DRAM heap to SPIRAM if available

This commit changes how the Jade hardware wallet's firmware uses memory. It moves some internal storage cache objects from the main RAM (DRAM) to external RAM (PSRAM/SPIRAM) when available. This is a memory-optimization change, not a direc…

Memory layout change: moves NVS cache from DRAM to SPIRAMNo direct security fix or vulnerability patch present in diffNo mention of CVE, security researcher, or security advisory in commit
329f73c5by Daniel Newton+7−17 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: migrate pin action tests from test_jade to rpc tests

This commit simply moves existing test cases from one test file to another. It does not change any production code, security behavior, or fix any vulnerability. The tests check that the Jade device correctly rejects invalid parameters for …

be0e6b3dby Mike Tolkachev+42−402 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: add tests for pin actions via debug_set_pin

This commit only adds a new test file that exercises PIN-related features of the Jade hardware wallet using a debug-only RPC command. It does not change any production code, introduce new functionality, or alter security behavior. The test…

dd3d5b22by Mike Tolkachev+334−01 file
No security note in commit
Moderate 62 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: require user to permit get_identity_shared_key RPC

This commit adds a user confirmation step before a hardware wallet will share an identity-derived shared secret. Previously, the get_identity_shared_key RPC could compute and return the shared key without the user pressing approve on the d…

RPC that derives/releases a cryptographic shared secret now requires explicit on-device user approvalInput validation added: identity string must be printable before being shown in a security promptNew dedicated accept/reject button event IDs separate this flow from sign_identity
7ca0d26cby Daniel Newton+70−116 files
No security note in commit
Informational 20 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

auth: add unattended pin selection for rpc tests

This commit adds a debug-only feature that lets automated tests set or change the device's PIN over an internal RPC message. It only compiles when special debug flags are enabled and is not present in normal production firmware. The change…

New RPC endpoint debug_set_pin can set/change the unlock PINPIN-handling code path modified to read from a mutable debug context instead of a fixed constantCode is wrapped in CONFIG_DEBUG_UNATTENDED_CI and CONFIG_DEBUG_MODE preprocessor guards
309ee8bbby Mike Tolkachev+100−205 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

pin: disallow pin update on initialized units in debug mode

This commit removes a special debug-only exception that previously allowed the PIN server's public key to be changed on a Jade hardware wallet that already had a wallet set up. In normal operation, changing this public key on an initialize…

Removal of debug-mode bypass for a security-critical authorization checkProtection against pinserver public key substitution on initialized devicesDefense-in-depth for wallet PIN/server trust binding
a5667efdby Jon Griffiths+1−31 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 95 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: fix mnemonic handling following seed changes

This commit only changes test code for the Blockstream Jade hardware wallet. It fixes how tests set and reset the device mnemonic/seed so tests run correctly after earlier seed-handling changes. There is no change to the actual wallet firm…

85e87d4eby Jon Griffiths+32−377 files
No security note in commit
Low 32 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

malloc_ext: fix JADE_CALLOC_DRAM

This commit fixes a macro definition for a memory-allocation helper. The macro was accidentally written to take only one argument ('size') even though the underlying function it calls needs two arguments ('number of items' and 'size of eac…

Memory-allocation wrapper macro arity mismatch fixedPotential for undefined behavior if mismatched macro were usedNo explicit security claim or CVE referenced in commit
828835ccby Daniel Newton+1−11 file
No security note in commit
Low 43 AI analysisMessage 68 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_psbt: fix reply count for exact chunk sizes

This commit fixes a bug in how Blockstream Jade counts the number of message chunks needed to send back a signed Bitcoin transaction (PSBT). When the transaction size was an exact multiple of the chunk size, the device told the host there …

Integer division off-by-one in chunk/message countDevice abort on assertion when host requests non-existent chunkDenial-of-service-like symptom: valid signing flow can crash the device
4f1a1565by kkdao+38−22 files
No security note in commit
Low 37 AI analysisMessage 73 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

ui: allow tapping directly on touchscreen elements

This commit adds a new touchscreen mode for some Jade hardware wallets where users can tap on-screen buttons directly instead of only using the three virtual buttons below the screen. To reduce the risk of accidental or malicious confirmat…

New direct-touch input path added to GUI event handlingCritical-action buttons require long-press to mitigate stray or coerced tap confirmationsDestructive operations (reset, delete wallet, delete OTP) converted to critical yes/no prompts
a46aa30aby Bota+206−1111 files
Vendor flagged security relevance
Informational 13 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

urldecode: use plain strlen in self-tests of libjade

This commit only changes the internal test file for a URL-decoding helper. It swaps a custom string-length macro for the standard C strlen() function inside test data. The actual product code that users rely on is not changed, and there is…

b39a7a20by Mike Tolkachev+27−291 file
No security note in commit
Moderate 50 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: support tickers up to 24 characters

This commit updates the Blockstream Jade hardware wallet to support longer asset tickers (up to 24 characters) and adds validation to reject malformed tickers. It also fixes a potential display bug where a ticker longer than 8 characters c…

Buffer size increased from 8 to 25 bytes to match new ticker maximumNew input validation added for asset ticker length and character setsnprintf precision argument cast from size_t to int to avoid undefined behavior on some platforms
cc5859a6by Mike Tolkachev+36−53 files
No security note in commit
Low 29 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: improve empty ticker support

This commit hardens how the Blockstream Jade hardware wallet handles assets that have no ticker symbol. Previously, if an asset's ticker was missing (NULL), the code could pass a NULL pointer to string-length functions, which can cause cra…

NULL-pointer dereference risk in asset ticker handlingDefensive null-check added before strlen()New test fixture for NULL ticker asset path
9d0d74d0by Mike Tolkachev+30−23 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityjadepy: support new/old versions of cbor2by Jon Griffiths · 91cc2edb · Jun 23, 2026 · 1 fileMessage 68 · AdequateInformational 20Details
Commit message · Jon Griffiths

jadepy: support new/old versions of cbor2

Based on a change from @1-21gigasats.

cbor2 b0rkage seems assured while it transitions its underlying
implementation. Supply a workaround for library interface changes,
as distateful as requiring it is.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 20/100

This is a small compatibility fix for the Python Jade library so it works with both older and newer versions of the cbor2 serialization library. Newer cbor2 changed which exception it raises when data runs out, so the code now detects the available exception type and catches the right one. It is a robustness improvement rather than a fix for an active security vulnerability.

Lower-prioritytools: don't attempt to overwrite kconfig if checking failsby Jon Griffiths · 3dd9c4db · Jun 23, 2026 · 1 fileMessage 50 · ThinInformational 17Details
Commit message · Jon Griffiths

tools: don't attempt to overwrite kconfig if checking fails

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 17/100

This is a small fix to a developer helper script (format.sh) used during code formatting. It prevents the script from trying to move a temporary file into place when a configuration-file check fails or never creates that temporary file. The change is about avoiding a build-tool error, not about stopping an attacker or protecting user funds.

Lower-prioritylibjade: use existing frame buffer rectangle drawingby Jon Griffiths · ff0789f0 · Jun 23, 2026 · 3 filesMessage 50 · ThinInformational 12Details
Commit message · Jon Griffiths

libjade: use existing frame buffer rectangle drawing

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 12/100

This commit removes a custom bitmap-drawing function used only in the libjade build and makes that build use the same drawing path as other configurations. It is a code cleanup with no visible security relevance.

Lower-prioritywire: explicitly set nonblocking default to falseby Jon Griffiths · 3d28dccb · Jun 23, 2026 · 1 fileMessage 45 · ThinLow 35Details
Commit message · Jon Griffiths

wire: explicitly set nonblocking default to false

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 35/100

This commit fixes a small but real bug in Blockstream Jade's USB/serial message handling. A variable that decides whether a version-info message should get an immediate reply was not given a safe starting value. In C, that means it could accidentally contain leftover garbage data, causing the device to reply immediately when it shouldn't. The fix simply sets that variable to 'false' by default. This is a defensive hardening change; there is no public evidence it has been exploited.

Lower-priorityassets: explicitly allow precision field to be optionalby Mike Tolkachev · 36f997b9 · Jun 23, 2026 · 1 fileMessage 50 · ThinLow 26Details
Commit message · Mike Tolkachev

assets: explicitly allow precision field to be optional

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 26/100

This small change makes the 'precision' number in asset metadata optional, defaulting to 0 if missing. Previously, the code may have treated a missing precision field as a failure. The patch uses a wrapper that explicitly ignores any error from reading the field, which could hide unexpected parsing problems. There is no direct evidence this is exploitable, but silently ignoring errors can make future bugs harder to detect.

Security candidatebuild: annotate functions returning error codes to ensure they are checkedby Mike Tolkachev · 909a89aa · Jun 23, 2026 · 25 filesMessage 74 · AdequateLow 36Details
Commit message · Mike Tolkachev

build: annotate functions returning error codes to ensure they are checked

74/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Explains rationale or failure mode! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet pathboot or update pathauthentication pathparser or protocol path
AI analysis · Low 36/100

This commit is a preventive build-hardening change. It adds compiler annotations (WARN_UNUSED_RESULT) to many functions that return success/failure codes, so the compiler will warn if a caller ignores the result. The goal is to catch future bugs where an error return is silently dropped, but the commit itself does not fix any specific known bug or change runtime behavior.

Lower-prioritybuild: add build support for enforcing return codes are checkedby Mike Tolkachev · bb2e53d6 · Jun 23, 2026 · 3 filesMessage 62 · AdequateLow 26Details
Commit message · Mike Tolkachev

build: add build support for enforcing return codes are checked

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 26/100

This commit adds compiler flags and helper macros to make the build fail whenever a function's return value is ignored without explicit intent. It is a hardening change, not a fix for a specific known bug. By enforcing that programmers check or deliberately discard return values, it reduces the chance that silent failures (for example, a failed security check or memory operation) slip into future code. There is no direct evidence in the commit that an existing vulnerability is being patched.

AI review queuedidentity: add identity string validationby Mike Tolkachev · 53752b98 · Jun 23, 2026 · 2 filesMessage 45 · ThinLow 46Details
Commit message · Mike Tolkachev

identity: add identity string validation

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 46/100

This commit adds a safety check to Blockstream Jade's 'sign identity' feature. Before the change, the device would accept any identity string a connected app sent. Now it rejects identities that contain non-printable or unusual characters. This reduces the risk that a malicious or buggy app could trick the user into signing an identity they did not intend to, or could smuggle control characters into a string shown on the device's screen.

Security candidateotp: show error on invalid issuer, share logging stringsby Mike Tolkachev · 66c945f2 · Jun 23, 2026 · 2 filesMessage 50 · ThinInformational 22Details
Commit message · Mike Tolkachev

otp: show error on invalid issuer, share logging strings

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Informational 22/100

This commit tightens error handling when decoding the 'issuer' field of an OTP (one-time password) setup URI. Previously, a malformed issuer string could fail to decode silently; now the device shows an error and cancels the operation instead of continuing with potentially bad data. It also makes minor logging message changes and adds an assertion for the label/issuer decode in the display code.

Security candidatepsbt: fix path sizeby Mike Tolkachev · 9e0c3747 · Jun 23, 2026 · 1 fileMessage 28 · OpaqueLow 42Details
Commit message · Mike Tolkachev

psbt: fix path size

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 42/100

This commit fixes a small but meaningful bug in how Jade, a hardware wallet, reads key paths from Bitcoin PSBT data. The code was passing the byte size of a buffer when it should have passed the number of 32-bit entries. Depending on how the underlying library interprets that value, this could lead to reading truncated paths, rejecting valid transactions, or possibly reading past the intended buffer. It is a defensive fix in security-sensitive parsing code, but the commit itself does not claim a specific exploitable vulnerability.

Lower-priorityusb: remove unused return from usb top level actionsby Jon Griffiths · 2ff2b31d · Jun 23, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Jon Griffiths

usb: remove unused return from usb top level actions

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a minor code cleanup in the USB storage feature of the Blockstream Jade hardware wallet. It changes two functions so they return nothing (void) instead of a true/false value, because the returned value was never actually used. There is no security-relevant change here.

AI review queuedsign: match sign_tx logic for output commitment checkingby Jon Griffiths · be05deac · Jun 23, 2026 · 1 fileMessage 50 · ThinModerate 57Details
Commit message · Jon Griffiths

sign: match sign_tx logic for output commitment checking

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 57/100

This commit fixes a logic gap in how Blockstream Jade checks cryptographic commitments for transaction outputs during signing. Previously, the code treated a missing commitment the same as an invalid one, which could cause the device to reject valid transactions or accept improperly validated ones. The change aligns this code path with the existing sign_tx logic, making output commitment handling consistent and more secure.

AI review queuedutils: fix params_additional_info return typeby Jon Griffiths · 3d6cdbcb · Jun 23, 2026 · 2 filesMessage 45 · ThinLow 26Details
Commit message · Jon Griffiths

utils: fix params_additional_info return type

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 26/100

This commit changes the declared return type of a transaction-signing helper function from a transaction-type code (TxType_t) to a simple success/fail boolean (bool). The function body already appears to return true/false, so the change fixes a type mismatch between the function's implementation and its header. In plain terms, the code was telling the rest of the program 'I return a transaction type' while actually returning 'yes/no' answers; this patch makes the two match. That kind of mismatch can confuse the compiler and, in rare cases, lead to wrong decisions about what kind of transaction is being signed, but the diff itself is tiny and only shows the declaration/header change, not the full function body or any callers.

AI review queuedurl: improve bounds checkingby Mike Tolkachev · c045aeac · Jun 23, 2026 · 1 fileMessage 35 · OpaqueModerate 61Details
Commit message · Mike Tolkachev

url: improve bounds checking

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Moderate 61/100

This commit tightens bounds checks in URL encoding/decoding functions used in Blockstream Jade, a hardware wallet. The changes fix potential off-by-one/out-of-bounds memory reads and writes when handling percent-encoded characters. Because Jade processes untrusted data (e.g., QR codes, USB messages, or companion-app URLs), a malformed URL fragment could previously trigger a buffer overread or, in encoding, a truncated/overwritten output buffer. The patch is defensive and partial: it improves checks but does not fully restructure the API, so residual risks from caller misuse remain possible.

Lower-prioritydescriptor: improve validation of child key pathby Mike Tolkachev · 2fad63e7 · Jun 23, 2026 · 1 fileMessage 45 · ThinLow 42Details
Commit message · Mike Tolkachev

descriptor: improve validation of child key path

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 42/100

This commit tightens how a Bitcoin hardware wallet (Blockstream Jade) validates the length of a child key path string before copying it into a fixed-size buffer. The change adds an explicit length check and uses the already-computed length rather than recomputing it after the copy. This appears to be a defensive hardening fix against a potential buffer overflow when handling wallet descriptors, though the commit message does not call it a security fix and no exploit details are provided.

Security candidatesign_psbt: add early reject on wrong genesis blockhashby Mike Tolkachev · 56e130b0 · Jun 23, 2026 · 1 fileMessage 50 · ThinModerate 59Details
Commit message · Mike Tolkachev

sign_psbt: add early reject on wrong genesis blockhash

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 59/100

This commit fixes a bug in the Blockstream Jade hardware wallet's PSBT (Partially Signed Bitcoin Transaction) signing code. Previously, when the transaction's genesis block hash did not match the expected network, the code set an error message but accidentally continued processing instead of stopping. This one-line fix adds the missing 'return' so the device rejects mismatched transactions immediately. Without the fix, a user could potentially be tricked into signing a transaction on the wrong network, which might lead to loss of funds or confusion between mainnet and testnet/signet assets.

Lower-prioritykeychain: fix error handling for cached green service keysby Jon Griffiths · 15630d12 · Jun 23, 2026 · 1 fileMessage 50 · ThinLow 42Details
Commit message · Jon Griffiths

keychain: fix error handling for cached green service keys

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 42/100

This commit hardens error handling in a hardware wallet's key derivation code by wrapping two function calls with an assertion macro. Previously, if these functions failed silently, the device could continue with invalid or uninitialized cryptographic keys. Now the device will halt if those functions fail, preventing use of bad keys. The actual security impact depends on whether those failures were reachable in practice.

Lower-priorityqr: fix error handling for qr exportby Jon Griffiths · 5e9b791e · Jun 23, 2026 · 1 fileMessage 45 · ThinLow 33Details
Commit message · Jon Griffiths

qr: fix error handling for qr export

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 33/100

This commit fixes error handling in the QR-code backup feature of a hardware wallet. Previously, if generating QR fragments or scanning the verification QR failed, the code could continue with invalid data and wrongly tell the user the backup was verified. The patch now aborts on generation failure and only marks the backup as verified when the camera scan actually succeeds and matches the expected secret.

Lower-prioritymain: ensure seed is present before completing OTP registrationby Mike Tolkachev · 0d6536df · Jun 23, 2026 · 1 fileMessage 50 · ThinModerate 59Details
Commit message · Mike Tolkachev

main: ensure seed is present before completing OTP registration

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Moderate 59/100

This commit fixes a bug in the Blockstream Jade hardware wallet's one-time-password (OTP) registration feature. Previously, if no wallet seed existed, the device would log an error and show a reset message, but then accidentally continue with OTP registration anyway. Now it stops and cleans up properly. The direct security impact is moderate: continuing without a seed could have led to storing an OTP secret that the device could not properly protect or later use, but the commit itself does not show an attacker-controlled path to exploit this.

Lower-prioritymain: fix error handling for debug handshakeby Mike Tolkachev · 7fb5e90e · Jun 23, 2026 · 1 fileMessage 45 · ThinLow 42Details
Commit message · Mike Tolkachev

main: fix error handling for debug handshake

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 42/100

This commit fixes a missing 'goto cleanup' after a failed attempt to save encrypted key data during a debug handshake. Without the fix, the code would continue running after reporting an error, potentially leaving sensitive key material in memory or skipping cleanup steps. The change ensures the function exits cleanly and securely when storage fails.

Security candidatemain: fix error handling during PIN changeby Mike Tolkachev · 64c30823 · Jun 23, 2026 · 1 fileMessage 45 · ThinLow 42Details
Commit message · Mike Tolkachev

main: fix error handling during PIN change

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
access controlauthentication path
AI analysis · Low 42/100

This commit fixes a bug in the PIN-change flow on Blockstream Jade hardware wallets. Previously, if re-encrypting the wallet keys with a new PIN failed, or if the user abandoned the PIN change, the code did not jump to cleanup as intended. Instead, it could fall through and continue executing subsequent code paths that were meant to be skipped. This could lead to incorrect state handling, potential use of stale or invalid key material, or confusing behavior after a failed PIN change. The fix adds explicit 'goto cleanup' statements so the function exits the sensitive section safely in both error and abandonment cases.

Lower-prioritymain: check MAC address obtained successfully from efuseby Mike Tolkachev · 5ffaacc6 · Jun 23, 2026 · 1 fileMessage 50 · ThinLow 33Details
Commit message · Mike Tolkachev

main: check MAC address obtained successfully from efuse

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 33/100

This commit adds a safety check to ensure the device can read its unique hardware identifier (MAC address) from a special chip memory area (efuse) before continuing startup. Previously, the code read the MAC address but ignored whether it succeeded. If that read failed, the device would continue running with an uninitialized/empty MAC address, which could cause operational problems or weaken security features that rely on a unique device identity. The fix makes the device halt with an error if the MAC cannot be read.

AI review queuedmultisig: fix error handlingby Mike Tolkachev · 427c2083 · Jun 23, 2026 · 2 filesMessage 35 · OpaqueLow 42Details
Commit message · Mike Tolkachev

multisig: fix error handling

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 42/100

This commit fixes two error-handling bugs in Blockstream Jade's multisignature wallet code. In one case, an invalid multisig wallet record was detected but the function kept running instead of returning immediately, which could lead to using corrupted wallet data. In the other, a path-validation failure was silently ignored, so a bad signer path might be accepted. Both are correctness fixes that improve safety, but the diff alone does not prove they are exploitable attacks.

Lower-prioritydisplay: add check for screen power on statusby Mike Tolkachev · 1883d343 · Jun 23, 2026 · 1 fileMessage 45 · ThinInformational 18Details
Commit message · Mike Tolkachev

display: add check for screen power on status

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 18/100

This tiny change makes the device firmly check that the screen successfully powers on during startup, rather than silently continuing if something goes wrong. It is a defensive hardening fix, not a clear-cut vulnerability patch. The commit message and diff do not describe any attack or security incident.

Lower-prioritylog: gracefully ignore failed log printingby Jon Griffiths · 45897011 · Jun 23, 2026 · 1 fileMessage 45 · ThinInformational 18Details
Commit message · Jon Griffiths

log: gracefully ignore failed log printing

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 18/100

This commit hardens three logging functions so they stop immediately if formatting a log message fails, instead of continuing with a negative or zero length. Previously, a failed format could cause the code to pass an invalid length to network or serial send functions. The change is defensive and reduces the chance of unexpected behavior from malformed log data, but it does not appear to fix an active security vulnerability.