BS
← All projectsBlockstream

Blockstream Jade

Firmware for Jade and Jade Plus Bitcoin hardware wallets.

BitcoinHardware walletsElevated watch
Repository coverage

557 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

120security candidates80second-pass queue462AI analyses
0commits · 30 days
47commits · 60 days
209commits · 180 days
423commits · 365 days
Backfill bands
Aug 5 → Feb 6216 seen38 candidatesComplete
Feb 6 → Jun 6131 seen9 candidatesComplete
Jun 6 → Jul 657 seen10 candidatesComplete
Jul 6 → Aug 510 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
37Strong · 80–100
204Adequate · 60–79
275Thin · 40–59
41Opaque · 0–39
5security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths32663289157
Mike Tolkachev541744153
Daniel Newton902078055
Mihailo Milenkovic878057
roderico633074
Valerio Vaccaro2226056
Jamie C. Driver525053
Gustavo Cateim917078
Austin-Fulbright414060
kkdao211068
quantpoet111072
cmiguelrn111045
Analysis record

Published AI watches

Last scanned 36 minutes ago

Moderate 57 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: whitelist reply message function calls

This commit adds a whitelist of approved functions that can be used when sending reply messages from the Jade hardware wallet to a connected computer or phone. Previously, any function could be passed in, which could allow a bug or malicio…

Function-pointer whitelist added to reply pathMultiple static reply helpers made global to enable whitelist comparisonAssertion tightened to validate callback before use
a59d14c2by Jon Griffiths+53−1513 files
No security note in commit
Low 42 AI analysisMessage 30 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

temporary_stack: whitelist temporary task function calls

This commit adds a whitelist to a special helper that lets certain functions run with extra memory stack space. Previously, any function could be passed to this helper. Now only a small list of approved functions is allowed, except during …

Addition of function-pointer whitelistRemoval of static linkage on internal functions to enable whitelist comparisonConditional bypass of whitelist only for debug/selfcheck builds
6a0fea51by Jon Griffiths+26−54 files
No security note in commit
Informational 15 AI analysisMessage 43 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

consistency: fix typos

This commit is a large typo-fixing cleanup across 40 files. Almost every change corrects spelling mistakes in code comments, variable names, or user-facing text strings. There is no change to program logic, security behavior, or cryptograp…

251f7713by Jon Griffiths+96−9640 files
No security note in commit
Informational 15 AI analysisMessage 47 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

docs: document get_bip85_bip39_entropy

This commit only updates documentation and removes a single comment line. It documents an existing feature that lets a user request encrypted BIP85-based BIP39 entropy from the Jade hardware wallet after on-device confirmation. There is no…

05a578adby Jon Griffiths+52−12 files
No security note in commit
Low 28 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

bip85: expose get_bip85_bip39_entropy over rpc in addition to qr

This commit moves a feature that derives BIP85 BIP39 entropy from being available only in debug builds to being available over the normal RPC interface. BIP85 lets a hardware wallet derive child seed phrases from a master seed. Making this…

Feature moved from debug-only to production RPC surfaceNo accompanying access-control or input-sanitization changes visible in diffBIP85 entropy derivation is a sensitive cryptographic operation
c6c5e860by Jon Griffiths+3−41 file
No security note in commit
Informational 19 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

versioninfo: add JADE_INTERFACE field to show which connection source holds the unlocked wallet

This commit adds a new read-only field, JADE_INTERFACE, to the device's version information reply. It simply tells a connected computer which communication path (USB, Bluetooth, QR mode, etc.) currently has control of the unlocked wallet. …

No authentication or authorization logic changedNo cryptographic or key-management code changedNo input parsing or memory-unsafe code added
2fe9df0bby Daniel Newton+66−56 files
No security note in commit
Low 44 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_tx/sign_psbt: extra check for BTC inputs

This commit adds overflow protection when adding up the total value of Bitcoin transaction inputs in Blockstream Jade's signing code. Previously, the firmware used a plain addition that could silently wrap around if a specially crafted tra…

Integer overflow hardening in financial-amount accumulationDefensive checked_add_uint64() introduced where plain addition existedTransaction signing path now rejects overflowed input totals
41d7e8b4by Daniel Newton+15−32 files
No security note in commit
Informational 19 AI analysisMessage 62 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

build: move NVS cache objects that can pin the DRAM heap to SPIRAM if available

This commit changes how the Jade hardware wallet's firmware uses memory. It moves some internal storage cache objects from the main RAM (DRAM) to external RAM (PSRAM/SPIRAM) when available. This is a memory-optimization change, not a direc…

Memory layout change: moves NVS cache from DRAM to SPIRAMNo direct security fix or vulnerability patch present in diffNo mention of CVE, security researcher, or security advisory in commit
329f73c5by Daniel Newton+7−17 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: migrate pin action tests from test_jade to rpc tests

This commit simply moves existing test cases from one test file to another. It does not change any production code, security behavior, or fix any vulnerability. The tests check that the Jade device correctly rejects invalid parameters for …

be0e6b3dby Mike Tolkachev+42−402 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: add tests for pin actions via debug_set_pin

This commit only adds a new test file that exercises PIN-related features of the Jade hardware wallet using a debug-only RPC command. It does not change any production code, introduce new functionality, or alter security behavior. The test…

dd3d5b22by Mike Tolkachev+334−01 file
No security note in commit
Moderate 62 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: require user to permit get_identity_shared_key RPC

This commit adds a user confirmation step before a hardware wallet will share an identity-derived shared secret. Previously, the get_identity_shared_key RPC could compute and return the shared key without the user pressing approve on the d…

RPC that derives/releases a cryptographic shared secret now requires explicit on-device user approvalInput validation added: identity string must be printable before being shown in a security promptNew dedicated accept/reject button event IDs separate this flow from sign_identity
7ca0d26cby Daniel Newton+70−116 files
No security note in commit
Informational 20 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

auth: add unattended pin selection for rpc tests

This commit adds a debug-only feature that lets automated tests set or change the device's PIN over an internal RPC message. It only compiles when special debug flags are enabled and is not present in normal production firmware. The change…

New RPC endpoint debug_set_pin can set/change the unlock PINPIN-handling code path modified to read from a mutable debug context instead of a fixed constantCode is wrapped in CONFIG_DEBUG_UNATTENDED_CI and CONFIG_DEBUG_MODE preprocessor guards
309ee8bbby Mike Tolkachev+100−205 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

pin: disallow pin update on initialized units in debug mode

This commit removes a special debug-only exception that previously allowed the PIN server's public key to be changed on a Jade hardware wallet that already had a wallet set up. In normal operation, changing this public key on an initialize…

Removal of debug-mode bypass for a security-critical authorization checkProtection against pinserver public key substitution on initialized devicesDefense-in-depth for wallet PIN/server trust binding
a5667efdby Jon Griffiths+1−31 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 95 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: fix mnemonic handling following seed changes

This commit only changes test code for the Blockstream Jade hardware wallet. It fixes how tests set and reset the device mnemonic/seed so tests run correctly after earlier seed-handling changes. There is no change to the actual wallet firm…

85e87d4eby Jon Griffiths+32−377 files
No security note in commit
Low 32 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

malloc_ext: fix JADE_CALLOC_DRAM

This commit fixes a macro definition for a memory-allocation helper. The macro was accidentally written to take only one argument ('size') even though the underlying function it calls needs two arguments ('number of items' and 'size of eac…

Memory-allocation wrapper macro arity mismatch fixedPotential for undefined behavior if mismatched macro were usedNo explicit security claim or CVE referenced in commit
828835ccby Daniel Newton+1−11 file
No security note in commit
Low 43 AI analysisMessage 68 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_psbt: fix reply count for exact chunk sizes

This commit fixes a bug in how Blockstream Jade counts the number of message chunks needed to send back a signed Bitcoin transaction (PSBT). When the transaction size was an exact multiple of the chunk size, the device told the host there …

Integer division off-by-one in chunk/message countDevice abort on assertion when host requests non-existent chunkDenial-of-service-like symptom: valid signing flow can crash the device
4f1a1565by kkdao+38−22 files
No security note in commit
Low 37 AI analysisMessage 73 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

ui: allow tapping directly on touchscreen elements

This commit adds a new touchscreen mode for some Jade hardware wallets where users can tap on-screen buttons directly instead of only using the three virtual buttons below the screen. To reduce the risk of accidental or malicious confirmat…

New direct-touch input path added to GUI event handlingCritical-action buttons require long-press to mitigate stray or coerced tap confirmationsDestructive operations (reset, delete wallet, delete OTP) converted to critical yes/no prompts
a46aa30aby Bota+206−1111 files
Vendor flagged security relevance
Informational 13 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

urldecode: use plain strlen in self-tests of libjade

This commit only changes the internal test file for a URL-decoding helper. It swaps a custom string-length macro for the standard C strlen() function inside test data. The actual product code that users rely on is not changed, and there is…

b39a7a20by Mike Tolkachev+27−291 file
No security note in commit
Moderate 50 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: support tickers up to 24 characters

This commit updates the Blockstream Jade hardware wallet to support longer asset tickers (up to 24 characters) and adds validation to reject malformed tickers. It also fixes a potential display bug where a ticker longer than 8 characters c…

Buffer size increased from 8 to 25 bytes to match new ticker maximumNew input validation added for asset ticker length and character setsnprintf precision argument cast from size_t to int to avoid undefined behavior on some platforms
cc5859a6by Mike Tolkachev+36−53 files
No security note in commit
Low 29 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: improve empty ticker support

This commit hardens how the Blockstream Jade hardware wallet handles assets that have no ticker symbol. Previously, if an asset's ticker was missing (NULL), the code could pass a NULL pointer to string-length functions, which can cause cra…

NULL-pointer dereference risk in asset ticker handlingDefensive null-check added before strlen()New test fixture for NULL ticker asset path
9d0d74d0by Mike Tolkachev+30−23 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritydocs: add security caveat and @DarkNavyOrg thanks to changelogby Jon Griffiths · 619baa1b · Dec 3, 2025 · 1 fileMessage 67 · AdequateInformational 7Details
Commit message · Jon Griffiths

docs: add security caveat and @DarkNavyOrg thanks to changelog

67/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 7/100

This commit only edits the project's changelog. It adds a note saying version 1.0.38 contains important security updates and thanks an outside security research group called DARKNAVY. The actual code fixes are not shown in this commit, so we cannot evaluate what the security problem is or how serious it is from the diff alone.

Lower-prioritylog: added CONFIG_LOG_CBOR (default off) to control logging via jade serial APIby Daniel Newton · 95653c19 · Dec 3, 2025 · 2 filesMessage 50 · ThinLow 29Details
Commit message · Daniel Newton

log: added CONFIG_LOG_CBOR (default off) to control logging via jade serial API

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 29/100

This commit adds a new build-time setting (CONFIG_LOG_CBOR) that is off by default. Previously, the Jade hardware wallet could send log messages over its serial interface; now that behavior is gated behind an explicit opt-in flag. The change reduces the risk that diagnostic logs leak sensitive information over the serial port in normal production builds.

Lower-prioritybuild: only check hashes that are presentby Jon Griffiths · 895bab82 · Dec 3, 2025 · 1 fileMessage 57 · ThinLow 29Details
Commit message · Jon Griffiths

build: only check hashes that are present

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 29/100

This is a small fix to a release verification script. Previously, the script would try to compare a firmware file against its expected hash even when the hash file was missing, which could cause the script to crash or behave unpredictably. Now it only performs the comparison when the hash file actually exists. This is a build/release hygiene improvement rather than a fix for an active security vulnerability in the device itself.

Lower-prioritybuild: only generate deltas that are 1/2 the firmware size or lessby Jon Griffiths · 239b9c14 · Dec 3, 2025 · 3 filesMessage 62 · AdequateLow 26Details
Commit message · Jon Griffiths

build: only generate deltas that are 1/2 the firmware size or less

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 26/100

This commit changes the build tooling that creates over-the-air (OTA) firmware update patches for the Blockstream Jade hardware wallet. It now refuses to generate a delta patch if the patch would be larger than half the size of the full new firmware, unless the caller explicitly uses a new '--force' flag. The CI scripts were updated to pass '--force' for their existing self-to-self test patches, so those tests still run. The change is a build/operational hardening measure: it prevents the release pipeline from shipping oversized delta updates that could be inefficient or potentially problematic, but it does not by itself fix a runtime vulnerability in the device.

AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · fb264239 · Nov 18, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates the project's CHANGELOG.md file, adding release notes for version 1.0.37. It does not change any source code, configuration, or executable files. There is no security-relevant change in the diff itself.

Lower-prioritybuild: increment the firmware secure versionby Jon Griffiths · 3457a52c · Nov 18, 2025 · 6 filesMessage 57 · ThinLow 33Details
Commit message · Jon Griffiths

build: increment the firmware secure version

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 33/100

This commit changes the build settings for all production variants of the Blockstream Jade hardware wallet to set a 'secure version' to 1. This is part of the device's anti-rollback protection: once this version is set, the bootloader will refuse to run older firmware that has a lower secure version. On its own, this change does not fix a bug or add a feature users interact with; it is a build-time policy change that affects which firmware versions the device will accept in the future. It could be a routine hardening step, or it could be a response to a known vulnerability that the vendor wants to ensure cannot be exploited by downgrading to an older, vulnerable firmware. The commit message and diff do not say which is the case.

Lower-priorityremove qr guide icons and draw qr guide directlyby Daniel Newton · 3212faea · Nov 12, 2025 · 13 filesMessage 45 · ThinInformational 15Details
Commit message · Daniel Newton

remove qr guide icons and draw qr guide directly

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a straightforward user-interface cleanup: it removes pre-made QR guide corner images and instead draws the same corner guides directly using simple rectangles. There is no security change visible in the code.

AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · 6ad13bff · Nov 12, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates the project's CHANGELOG.md file. It documents what was added, changed, and fixed in firmware versions 1.0.36 and 1.0.37, but does not modify any source code, build scripts, or configuration. There is no direct security-relevant code change to review in this commit itself.

Lower-priorityusb: refactor usb handlingby Jon Griffiths · c0606dc3 · Nov 6, 2025 · 4 filesMessage 58 · ThinLow 32Details
Commit message · Jon Griffiths

usb: refactor usb handling

- Simplify the USB caller interface down to start() and stop().
- Simplify the internal state machine to a single loop
- Remove multiple synchronization primatives in favour of a single mutex
- Prevent freezing when JTAG and logging are both enabled
- Remove UI-based logging support
- Load the next data block while the current one is processing
- Time-out if ota_data messages are not forthcoming
- Reduce stack usage

Co-authored-by: Daniel Newton <dnewton@blockstream.com>

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
AI analysis · Low 32/100

This commit is a major internal rewrite of how Blockstream Jade handles USB storage and firmware updates over USB. It simplifies the code, removes several old synchronization mechanisms, and adds timeouts and better error handling. The changes appear to be defensive hardening and reliability fixes rather than a patch for a known active security flaw. There is no mention of a CVE, security advisory, or external researcher in the commit itself.

Lower-priorityci: include sdkconfig.defaults in firmware build artifactsby Jon Griffiths · 0d883e1e · Nov 6, 2025 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Jon Griffiths

ci: include sdkconfig.defaults in firmware build artifacts

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This change only adjusts the project's automated build pipeline to include an extra configuration file (sdkconfig.defaults) in the published firmware build artifacts. It does not modify the actual firmware code, device behavior, or security controls. There is no indication of a security vulnerability or fix.

Lower-prioritychange name of usb_connected() to usb_is_powered()by Daniel Newton · 61690c66 · Nov 6, 2025 · 18 filesMessage 50 · ThinInformational 15Details
Commit message · Daniel Newton

change name of usb_connected() to usb_is_powered()

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a simple rename of a function from usb_connected() to usb_is_powered() across 18 files. There are no logic changes, no security fixes, and no behavioral differences. It appears to be a code-clarity refactor to make the function's purpose clearer.

Lower-priorityota: share error handling codeby Jon Griffiths · 3f207eeb · Oct 30, 2025 · 4 filesMessage 60 · AdequateLow 34Details
Commit message · Jon Griffiths

ota: share error handling code

Attempt to be more careful about replying without a current message or
replying to a given message twice.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 34/100

This commit refactors the firmware-update (OTA) error-handling code in Blockstream Jade so both the normal and delta update paths use the same cleanup logic. The stated goal is to avoid replying when there is no current message or replying to the same message twice. The change centralizes final checks and error replies, but the diff alone does not prove a specific exploitable vulnerability; it looks like a defensive code-quality fix.

Lower-priorityota: add missing jumps to cleanup codeby Jon Griffiths · 3700ef34 · Oct 30, 2025 · 2 filesMessage 45 · ThinModerate 61Details
Commit message · Jon Griffiths

ota: add missing jumps to cleanup code

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Moderate 61/100

This commit fixes three places in the firmware update (OTA) code where an error was recorded but the code kept running instead of jumping to cleanup. After an update error, the device could continue to process messages and potentially finalize or report a successful update when it should have aborted. This is a logic bug in error handling that could lead to a corrupted or incomplete firmware being accepted.

Lower-priorityota: make user validation set the ota and confirmation statusby Jon Griffiths · 9314a4f9 · Oct 30, 2025 · 4 filesMessage 73 · AdequateLow 42Details
Commit message · Jon Griffiths

ota: make user validation set the ota and confirmation status

This makes confirmation status easier to reason about as it is only set
in one place after ota_init().

Following this, it is clear that if the decompressed data callback is initially
called with less than the full custom header, then user validaton will
never be called. Document the code that catches this case and how it can
happen.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 42/100

This commit restructures how a Blockstream Jade hardware wallet confirms firmware updates. It moves the 'user has approved' flag into the validation routine itself and adds a safety check: if the first chunk of firmware data is smaller than expected, the device now aborts rather than risk skipping the user-approval step. The change is defensive hardening, not a confirmed exploit fix, because the commit message only calls it a theoretical case.

Lower-priorityota: perform the happy path processing in ota_finalize()by Jon Griffiths · 04198416 · Oct 30, 2025 · 4 filesMessage 50 · ThinLow 28Details
Commit message · Jon Griffiths

ota: perform the happy path processing in ota_finalize()

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 28/100

This commit moves the 'success' handling of firmware updates (sending an OK reply, showing a success message, and rebooting) into a shared helper function called ota_finalize(). Previously, this success logic was duplicated in two places after calling ota_finalize(). The change is a code cleanup and does not appear to alter security behavior, but it does mean the success path now lives inside the finalization routine rather than after it returns.

Lower-priorityota: initial refactor of ota processingby Jon Griffiths · b1437349 · Oct 30, 2025 · 4 filesMessage 68 · AdequateLow 32Details
Commit message · Jon Griffiths

ota: initial refactor of ota processing

Push all state into the ota context struct, allocate it from the heap
and free it consistently on process exit. Use the context to simplify
error handling rather than forcing callers to maintain their own external
context variables.

Share the initial message processing and ota setup code between the
full and delta ota tasks since its almost completely identical.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 32/100

This commit is a code cleanup that rewrites how the Blockstream Jade hardware wallet handles firmware updates. It moves all update-related state into a single heap-allocated structure and makes the cleanup logic more consistent. The change itself is a refactor, not an obvious security fix, but it touches sensitive firmware-update code where mistakes can have serious consequences. There is no direct evidence in the commit message or diff that a specific vulnerability was being fixed.

Lower-priorityota: make finalization set the ota statusby Jon Griffiths · 8a710d86 · Oct 30, 2025 · 4 filesMessage 45 · ThinLow 45Details
Commit message · Jon Griffiths

ota: make finalization set the ota status

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 45/100

This commit refactors how firmware update finalization works in the Blockstream Jade hardware wallet. Previously, the final verification and boot-partition switch only ran if the update had already been marked successful. Now the finalization routine always runs and sets the success/failure status itself. The change is mostly a code-cleanup, but it removes a guard that could have silently skipped final checks when an earlier error was already recorded. There is no direct evidence in the commit that this fixes an exploitable vulnerability, but it hardens the OTA flow so that final verification and boot-partition selection are consistently applied.

Lower-priorityota: ensure error replies are sent if firmware sizes mismatchby Jon Griffiths · 495f6278 · Oct 30, 2025 · 2 filesMessage 73 · AdequateLow 45Details
Commit message · Jon Griffiths

ota: ensure error replies are sent if firmware sizes mismatch

If ota_complete is not seen, return directly. This code path does not
set an error into the context, and so never enters the cleanup code.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 45/100

This commit fixes a bug in the firmware update (OTA) code for Blockstream Jade hardware wallets. Previously, if the device received an unexpected message after a firmware upload whose size did not match expectations, it could return without sending an error reply to the host. The fix ensures the device always sends an error response in those cases, so the host app knows something went wrong instead of being left hanging.

Lower-priorityota: remove write-through pointer members from ota context structby Jon Griffiths · 6e2c00ec · Oct 28, 2025 · 4 filesMessage 65 · AdequateInformational 15Details
Commit message · Jon Griffiths

ota: remove write-through pointer members from ota context struct

We are already writing through the context pointer, the extra
indirection uses more stack with no benefit.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup in the firmware update (OTA) module. It removes an unnecessary layer of pointers inside the OTA context structure, storing values directly instead of pointing to separate local variables. There is no indication this fixes a security bug or changes security behavior.

Lower-priorityusb: use usbstorage_register_callback to unregisterby Jon Griffiths · 057dd310 · Oct 28, 2025 · 1 fileMessage 50 · ThinLow 32Details
Commit message · Jon Griffiths

usb: use usbstorage_register_callback to unregister

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 32/100

This commit changes how a USB storage callback is unregistered when a background task shuts down. Instead of directly clearing two internal variables while holding a mutex, the code now calls the existing registration function with NULL values. This is a cleanup/refactoring change that likely fixes a potential race condition or inconsistent state, but the diff alone does not show an exploitable vulnerability.

Lower-priorityusb: restore the previous activity before running a usbstorage actionby Jon Griffiths · 7483976f · Oct 28, 2025 · 1 fileMessage 50 · ThinLow 29Details
Commit message · Jon Griffiths

usb: restore the previous activity before running a usbstorage action

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 29/100

This commit fixes a small user-interface bug in Blockstream Jade's USB storage mode. When a user plugs in a USB drive and the device mounts it, the code now restores the previous on-screen activity before running the requested action. It also swaps a generic message screen for a proper error screen when USB storage fails, and removes an unnecessary short delay after an earlier error. There is no clear security vulnerability being patched here; it reads as a UI polish and robustness improvement.

AI review queuedusb: simplify handle_ota_reply logicby Jon Griffiths · 1e51b96c · Oct 23, 2025 · 1 fileMessage 35 · OpaqueLow 34Details
Commit message · Jon Griffiths

usb: simplify handle_ota_reply logic

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 34/100

This commit simplifies how a Blockstream Jade hardware wallet handles an over-the-air (OTA) firmware update reply received over USB. Previously, the code checked whether a CBOR boolean 'result' field existed and only updated the success flag if it did. Now it updates the success flag regardless of whether the field is present, and no longer treats a missing 'result' as a failure. This could mean a malformed or unexpected reply leaves the success flag set to its previous value rather than being explicitly cleared, potentially making an unsuccessful update appear successful.

Lower-priorityusb: use a mutex for usb state context reading and writingby Jon Griffiths · 9764cda8 · Oct 23, 2025 · 1 fileMessage 73 · AdequateLow 31Details
Commit message · Jon Griffiths

usb: use a mutex for usb state context reading and writing

This ensures we don't perform dirty reads of the usb state.

Also wait up to 5 seconds before prompting the user to insert a
USB storage device.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 31/100

This commit fixes a race condition in the way Blockstream Jade handles USB storage state. Previously, the device could read the USB storage state while it was being updated by another task (a 'dirty read'), which could lead to incorrect decisions such as trying to use a USB drive before it was fully mounted, or missing an error. The fix introduces a mutex (a locking mechanism) so that reads and writes of the USB state cannot happen at the same time. It also increases the wait time before prompting the user to insert a USB device from about 3 seconds to 5 seconds.

Lower-priorityusb: avoid memory allocations for ota chunk databy Jon Griffiths · f0ebdd09 · Oct 23, 2025 · 1 fileMessage 45 · ThinInformational 23Details
Commit message · Jon Griffiths

usb: avoid memory allocations for ota chunk data

Prevents fragmentation.

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 23/100

This commit changes how firmware-update (OTA) messages are passed internally in the Blockstream Jade hardware wallet's USB code. Instead of using a helper that allocates extra memory and copies the message, the code now embeds a one-byte source tag at the start of a single fixed buffer and passes that buffer directly. The stated goal is to reduce memory fragmentation. The change itself does not obviously fix a security bug, but it removes a memory-allocation path during firmware updates, which could indirectly reduce the chance of update failures or instability caused by low memory.

Lower-priorityusb: avoid stdio overhead and buffering when reading ota databy Jon Griffiths · acac6fa5 · Oct 23, 2025 · 1 fileMessage 50 · ThinInformational 16Details
Commit message · Jon Griffiths

usb: avoid stdio overhead and buffering when reading ota data

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 16/100

This commit changes how a Blockstream Jade hardware wallet reads firmware update files from USB storage. It switches from using standard C file reading (fopen/fread/fclose) to lower-level Unix file reading (open/read/close). The stated goal is to reduce memory overhead and buffering during over-the-air (OTA) firmware updates. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a performance or robustness improvement.